Commit graph

265 commits

Author SHA1 Message Date
Treehugger Robot
317e9d4e22 Merge changes I2ca96002,I8f9c076e into main
* changes:
  Add the abstraction layer for the camera classes
  Add EVS Camera Device Type to the Default Implementation
2023-09-15 00:21:34 +00:00
Hao Chen
c5d5d7565d Add the abstraction layer for the camera classes
Test: Build
Bug: 277861838
Change-Id: I2ca960022916ef5db2896625208e74d4c0db5d36
2023-09-14 22:19:48 +00:00
Hao Chen
02a1825028 Add EVS Camera Device Type to the Default Implementation
Test: Build
Bug: 277861838
Change-Id: I8f9c076e0d03f541587015c71aeb8a9335d37733
2023-09-14 22:19:13 +00:00
Changyeon Jo
88ef0d64bc Merge "Update the default EVS HAL implementation" into main 2023-09-06 17:13:30 +00:00
Changyeon Jo
d095b7aafa Update OWNERS file am: bacdd1ec09
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2740885

Change-Id: Ie6784053acee05538e6d328d98c7cea1730291a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-06 04:55:17 +00:00
Changyeon Jo
bacdd1ec09 Update OWNERS file
This change updates OWNERS file for EVS interface.

Bug: 299195329
Test: Manual
Change-Id: Ife421b8aa4a380d8585e6d8476f0a24f31bc2633
2023-09-06 00:57:59 +00:00
Changyeon Jo
130d5a3aa0 Update the default EVS HAL implementation
Remove H2BGraphicBufferProducer usages from the default EVS HAL
implementation.

Bug: 297601247
Bug: 298091684
Test: Run evs_app on the cuttlefish emulator.
Change-Id: Ibca21d8e9cf87deb79c0050f9adcf02b5f16d34b
2023-08-31 13:12:39 -07:00
Changyeon Jo
f018e5213d Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: 4bf0cb2c5f am: b484054880 am: f1c67f57e9
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ibc853cb9ad6ab961b3140c69efeb1c024f91006a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:46:28 +00:00
Changyeon Jo
9e8d44aba4 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6 am: e0868c4484 am: ca64f5b140
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: If414ff886a8c2e6c336289e89f73719d740ac73c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 02:24:19 +00:00
Changyeon Jo
4bf0cb2c5f Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b am: 55baee93d6
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I8ac30fb5abe6c6205d099d089e769ffb477ddc7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 00:32:36 +00:00
Changyeon Jo
55baee93d6 Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c am: c070b5a14b
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ic0db29743b092a5a2d01860e76356a38e3e4788b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16 00:04:30 +00:00
Changyeon Jo
c070b5a14b Increase frame counters in the same critical section am: 928a4535c8 am: a343d0cf0c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: Ibcaac170949c319d2cff5b45bc8114238d0ada7b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 23:21:50 +00:00
Changyeon Jo
a343d0cf0c Increase frame counters in the same critical section am: 928a4535c8
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2594993

Change-Id: I8a59e6173179a284bb90960b30e2e5a35de075a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15 22:39:21 +00:00
Changyeon Jo
928a4535c8 Increase frame counters in the same critical section
Bug: 275049370
Test: atest VtsHalEvsV1_0TargetTest
Change-Id: I814aac4edec142027d3802f5ee0d7a444ae2ee86
2023-06-15 21:11:09 +00:00
Hao Chen
6cfe1f86e9 VTS: Skip the Check if getDisplayStateById is not Supported
Test: atest VtsHalEvsTargetTest
Bug: 276974949
Change-Id: I44d41b937611e06823fe8d2c8ef9d1da783bd17a
2023-04-14 16:07:08 -07:00
Alex Buynytskyy
ec1198d941 UpsideDownCake is now 34
Ignore-AOSP-First: UpsideDownCake Finalization
Bug: 275409981
Test: build
Change-Id: I832ab7a8b5445ba85e27bbcf5be64906bfa0e5be
2023-04-07 23:41:20 +00:00
TreeHugger Robot
9074fdc1da Merge "Correct comments" into udc-dev 2023-04-03 16:08:28 +00:00
Changyeon Jo
bc433a0d5b Correct comments
- Fix a typo on ExposureParameters.coarseIntegrationTimeLShift.
- Add a comment that describes a descriptor field of GridStatistics.

Bug: 276675923
Test: build
Change-Id: Ida93c21c9de7f7c1d661c790d82342750d5f29fe
2023-04-03 05:20:18 +00:00
Hao Chen
be81939285 Add VTS testcases for getDisplayStateById
Test: build
Bug: 275626422
Change-Id: I27dfced8f0040e6604baeed37df7e12f5ec5d73d
2023-03-29 16:20:09 -07:00
Hao Chen
ac8e696207 Uprev the EVS AIDL NDK Version
Bug: 262779341
Test: build
Change-Id: I39d2e6b969db11b03d4e1fe929b19d65f75e72ff
2023-03-29 15:50:00 -07:00
Hao Chen
96ca65804e Merge "Add VTS for EVS Display" into udc-dev 2023-03-29 20:05:39 +00:00
Hao Chen
e708da89b5 Add VTS for EVS Display
They are mostly copied from the HIDL 1.0 display test cases, with some minor changes.

Test: `atest VtsHalEvsTargetTest`
Bug: 275626422
Change-Id: Ica5379e7f021083b65ad8abf320f7751c1432c9e
2023-03-28 23:33:14 +00:00
Changyeon Jo
c9e4122f5b Implement incomplete or missing IEvsCamera methods
This CL completes IEvsCamera interface implementation by adding
following methods to a default AIDL EVS HAL implementation.
- IEvsCamera::importExternalBuffers()
- IEvsCamera::getIntParameterRange()
- IEvsCamera::setIntParameter()
- IEvsCamera::getIntParameter()

Fix: 275101894
Test: 1. Launch CVD in accelerated graphics mode (gfxstream).
      2. atest VtsHalEvsTargetTest --iteration 3
Change-Id: I70ed2a97f49d27146ce00cdaab9ca3f41a59fc98
2023-03-27 18:19:51 +00:00
Changyeon Jo
7e62631ea4 Revert "Revert "Add default implementation of AIDL EVS interface""
This reverts commit d12e05929a.

Bug: 218588089
Test: 1. Build cf_x86_64_auto lunch target.
      2. Launch cvd in the accelerated graphics mode.
      3. atest VtsHalEvsTargetTest and confirm that EVS HAL
         implementation passes all test cases except
         CameraStreamExternalBuffering that is not supported yet in new
         implementation.
      4. Run evs_app and confirm the color bar pattern is shown on the
         display.
         > adb root && adb shell evs_app --test
      5. Do the same on sdk_car_x86_64 lunch target.
Change-Id: I4647d0ef7a2bd98fdfcb3833bfb060b4063bc42e
2023-03-24 21:03:12 +00:00
Hao Chen
0e55469db9 Add Display ID when Getting Display State
Multiple displays can be opened concurrently, so display ID
is needed when getting status of active displays.

Test: build
Bug: 262779341

Change-Id: I12af698be85ba72f0fb81f143441956dd0bfe1d2
2023-03-16 11:23:21 -07:00
Kevin Han
d12e05929a Revert "Add default implementation of AIDL EVS interface"
Revert submission 21585493-b218588089

Reason for revert: b/273324345

Reverted changes: /q/submissionid:21585493-b218588089

Change-Id: I2826a16105f8e7b03f852f9babffb03d78d53fd0
2023-03-13 21:18:28 +00:00
Changyeon Jo
20dbc58c25 Add default implementation of AIDL EVS interface
This implementation is used for the emulators.

Bug: 218588089
Bug: 270753093
Test: 1. Build cf_x86_64_auto lunch target
      2. Launch cvd in the accelerated graphics mode
      3. Run evs_app and confirm the color bar pattern is shown on the
         display.
         > adb root && adb shell evs_app --test
Change-Id: I8179e74fc9f0b9547316368fca507e5c62ca5680
2023-03-11 01:51:13 +00:00
Treehugger Robot
b366b65df3 Merge "Update OWNERS file" am: 83248af588 am: d41829ab33 am: 4edb0654f5
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2458408

Change-Id: I0f5edfc62b289662601d0d694cee148fd0baa483
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-01 06:49:59 +00:00
Changyeon Jo
24d22eb9df Update OWNERS file
Bug: 270900095
Test: Treehugger
Change-Id: Ieb0bf7eacb039db53da61207f2cb4ff70641bf75
2023-02-27 16:05:58 +00:00
Changyeon Jo
08a8a722dd Add APIs for the sensor embedded data
To make the sensor embedded data available to EVS clients, this change
adds new fields to BufferDesc and declare necessary data types.

Bug: 191939108
Test: build
Change-Id: Iaa41554e49c7ff30c11d391b00eae12dfef9e99b
2023-02-15 12:43:31 -08:00
Changyeon Jo
7793baab67 Explicitly close the EVS display
A test case closes the EVS display explicitly to make sure an associated
EGL surface is destoryed before running a next test case.

Fix: 266098494
Test: atest VtsHalEvsTargetTest
Change-Id: I4079242884ed436bca95c983b3e4475f2cef1464
2023-01-19 13:18:47 -08:00
Xin Li
34eab1cf79 Merge Android 13 QPR1
Bug: 261731544
Merged-In: I4fe9ddd1c22ebfff03f5660ec9b01de2521f8533
Change-Id: Ic59ecf4fbb0438607c4069829426fbdfa7c7abd1
2022-12-09 10:29:52 -08:00
Steven Moreland
2e37f01273 Merge "graphics.common V3 -> V4" 2022-12-09 17:21:59 +00:00
Changyeon Jo
42c3c902f5 Fix how displays are used in test cases am: 017cb98ee9 am: 1186b99120 am: ed6ebed9f3 am: 819113071d
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2305821

Change-Id: I41e5a4059d7e0b56c6329b63d86cea0e4d495552
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 01:44:56 +00:00
Changyeon Jo
819113071d Fix how displays are used in test cases am: 017cb98ee9 am: 1186b99120 am: ed6ebed9f3
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2305821

Change-Id: I687ff1d38a350929060476001efd289ef5ca507a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 01:16:37 +00:00
Changyeon Jo
ed6ebed9f3 Fix how displays are used in test cases am: 017cb98ee9 am: 1186b99120
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2305821

Change-Id: Iad80f724c545d9d0e75a785a686e1ff5830a748d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-12-09 00:54:29 +00:00
Marc Kassis
132900f4e1 graphics.common V3 -> V4
Bug: 251177105
Test: m
Change-Id: I1cb84ec85f98789d0737207a1661b39a25538c96
Merged-In: I1cb84ec85f98789d0737207a1661b39a25538c96
Merged-In: I2e1561f4ccb59a2a833af9a7afd07840ab2ebfa4
2022-12-08 13:20:59 +00:00
Marc Kassis
9c428fe3ed graphics.common V3 -> V4
Bug: 251177105
Test: m
Change-Id: I816b8e14a0741402090cdc4732c2a904e830ff4e
Merged-In: I1cb84ec85f98789d0737207a1661b39a25538c96
Merged-In: I2e1561f4ccb59a2a833af9a7afd07840ab2ebfa4
2022-12-07 10:53:12 +00:00
Changyeon Jo
017cb98ee9 Fix how displays are used in test cases
Open and close the display for each camera instance.

Bug: 259449376
Test: atest VtsHalEvsTargetTest VtsHalEvsV1_1TargetTest
Change-Id: I0f3d2c0b2c9f8a5e527d0abd5c9b248c84dddfbb
2022-12-04 08:17:44 +00:00
Steven Moreland
ed27779d14 graphics.common V3 -> V4
Bug: 251177105
Test: builds
Change-Id: I1cb84ec85f98789d0737207a1661b39a25538c96
2022-10-29 00:51:21 +00:00
Changyeon Jo
a6e880a398 Remove color format constraints am: e6bb228dc6 am: 9b60ecd229
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2188343

Change-Id: I16002aae2f76e58380f72a131229a381cb11ca56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 22:36:12 +00:00
Changyeon Jo
4cbdc86584 Corrects color format requirements am: bfbbba6300 am: 217a6ff310
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2182380

Change-Id: I5320446feba732ffdfeb14b8305634afa6506aad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-15 22:34:28 +00:00
Changyeon Jo
7f5ad61254 Remove color format constraints
VtsHalEvsTargetTest does not verify any behavior depending on
a frame buffer's color format.

Bug: 240685726
Test: atest VtsHalEvsTargetTest
Change-Id: If8b8c595cfc7404a8122728593f778528b45af15
(cherry picked from commit 849d0f370c)
2022-09-09 16:05:53 +00:00
Sally Qi
784c253a05 Add cc_defaults as wrapper for graphics composer/common AIDL
interfaces.

- Add new Android.bp in graphics folder and wrap composer and common
  AIDL in to separate cc_defaults.
- remove composer3 dependency from allocator's VTS .bp file.

Bug: 243429120
Test: builds
Change-Id: Ia91e4ab87b7ac86248094317185b317d5604e654
2022-08-26 15:18:42 -07:00
Treehugger Robot
5143b555e3 Merge "Remove color format constraints" am: 463d08394e am: 6e9d53e9c0 am: 3499c17506 am: 7d81c3fd9c am: 2232247c21
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2183884

Change-Id: Id94d5cd15c98e339ca33574a3159099aa0e20f6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 05:51:25 +00:00
Treehugger Robot
2232247c21 Merge "Remove color format constraints" am: 463d08394e am: 6e9d53e9c0 am: 3499c17506 am: 7d81c3fd9c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2183884

Change-Id: Iadb36e37af878c6e6974931a5905fd841958940c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 05:15:38 +00:00
Changyeon Jo
cc5daf4a3c Remove color format constraints am: e6bb228dc6 am: 9b60ecd229 am: ec0d97c86b am: b9244570e4 am: 61fba264e6 am: 47e6310528 am: f058d2bf1a
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2188343

Change-Id: If682515572a93942a8768b5ab79429efa0c8f263
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 03:50:22 +00:00
Changyeon Jo
f058d2bf1a Remove color format constraints am: e6bb228dc6 am: 9b60ecd229 am: ec0d97c86b am: b9244570e4 am: 61fba264e6 am: 47e6310528
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2188343

Change-Id: I6db838d2afe76a059800bad02c0936d10d72f6f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 03:20:42 +00:00
Treehugger Robot
463d08394e Merge "Remove color format constraints" 2022-08-25 02:28:02 +00:00
Changyeon Jo
ec0d97c86b Remove color format constraints am: e6bb228dc6 am: 9b60ecd229
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2188343

Change-Id: Ife0695367cc56876e595275d26096cc329535c4e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 00:39:27 +00:00