Commit graph

25 commits

Author SHA1 Message Date
Chih-Hung Hsieh
a5d28736f4 Use -Werror in hardware/interfaces/biometrics/fingerprint
am: 5631258f07

Change-Id: I6c81b78c4d00faccefdaa3e40ebcecc26222c5e9
2017-11-29 00:02:41 +00:00
Chih-Hung Hsieh
5631258f07 Use -Werror in hardware/interfaces/biometrics/fingerprint
* Fix warning of unused function call result.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I91da207b80d0715d015195357d645f8cf324fa1e
2017-11-28 13:40:33 -08:00
Xin Li
bb9e38fef9 Merge commit '1a06284b24f5eb7bb9c1fea0817da8898b3b1bff' from
oc-mr1-dev-plus-aosp into stage-aosp-master

Change-Id: I2a044eb8c9981d0a8198ffe2df55559afbd76341
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
2017-11-14 12:08:38 -08:00
Steven Moreland
90e3a50f03 Automatic mk -> bp.
Automatic mk -> bp conversion for all modules here
which can be converted and built automatically.

Test: Soong resolves all dependencies
Bug: 37512442
Change-Id: Ib789212cb88d55731397c600d132e7c672c0d8be
2017-11-03 16:30:28 +00:00
Nick Desaulniers
e637aa32b8 biometrics: fingerprint: add locking to default impl
There exists the following race condition:
a). thread A receives setNotify and sets the callback to some object
b). thread B of the wrapped implementation calls
BiometricsFingerprint::notify which it was given a handle to. Thread B
executes past the nullptr check:
c). thread A receives setNotify and sets the callback to some other
object (or nullptr)
d). thread B resumes in notify with unknown state

Add mutex to protect access to mClientCallback.

Change-Id: I9163204ff5802e9246056caeb2a7857e6138531c
Fixes: 64802340
Test: VtsHalBiometricsFingerprintV2_1IfaceFuzzer
2017-08-18 17:14:53 +00:00
Kevin Chyn
10dfcc14dc Add onAcquired log back
It was in fingerprintd, which is replaced now

Fixes: 37677260
Test: touch FP when enrolling/authenticating and make sure
onAcquired log is there

Change-Id: Iadecdfa1c18b0aaa083de18dbe7f701c78465ace
2017-04-25 15:05:32 -07:00
TreeHugger Robot
04b086dd08 Merge "setActiveGroup null, 0 length, unwritable dir should fail" into oc-dev 2017-04-14 23:10:32 +00:00
Kevin Chyn
d7e9b0fdc7 setActiveGroup null, 0 length, unwritable dir should fail
with this change, VTS test needs to run in /data/system/
due to SELinux policy + Linux directory permissions

Test: run VTS tests and make sure they all pass
Fixes 37153318

Change-Id: Ib1f19ce7fc0d08ae2941aec5c08c5857c7a9f2fd
2017-04-14 14:10:19 -07:00
Steven Moreland
750ede4cf9 fingerprint: clean up includes
Bug: 33241851
Test: links
Test: works with BOARD_VNDK_VERSION := current
Change-Id: I7cfec2b8459964edf9a180d01cfdd90dae376fb9
2017-04-13 16:13:47 -07:00
Jim Miller
d361f033d4 Log errno
Bug 36790737

Test: ensure errno is logged
Change-Id: Ifa9a0b6ee0baebfdfce894622ef40888dd83dddf
2017-04-06 17:07:48 -07:00
Nick Desaulniers
8174a847f2 fingerprint: check return status of hwbinder calls
If system_server dies, and return codes of hwbinder calls are not
checked, an abort of the HAL service will occur.  In this case,
warn in the logs, but allow system_server to reopen HAL.

Bug: 34867134
Change-Id: I9fe1c2c0f1c03e8debafb56bff8a7490ccbbcec0
2017-03-20 14:12:43 -07:00
Yifan Hong
4681ab8b21 IBiometricsFingerprint uses "default" service name
The getService() and registerAsService() methods of interface objects
now have default parameters of "default" for the service name. HALs
will not have to use any service name unless they want to register
more than one service.

Test: fingerprint works

Bug: 33844934
Change-Id: I6383c43b4b05469cb986e4f10129a0921f401464
2017-03-16 15:39:08 -07:00
Steven Moreland
7e73d5b908 Remove viral dependency on libhwbinder. (2/2)
find hardware/interfaces -name Android.mk -exec sed -i -e '/libhwbinder
\\/d' {} \;
find hardware/interfaces -name Android.bp -exec sed -i -e
'/"libhwbinder"/d' {} \;
./hardware/interfaces/update-makefiles.sh

Note, automotive has some actual dependencies on libhwbinder, filed
b/35758626 for this.

Test: everything links
Test: (sanity) booted marlin on internal master with these changes
Bug: 35710429
Change-Id: I6d0726c8130d00684b978efbdd48e3ae396f12e5
2017-02-24 12:18:01 -08:00
Steven Moreland
a0da1a1c3d Move hidl shims to the vendor partition. (2/2)
We need google shims on the vendor partition because they are providing
an implementation of a vendor defined interface. They were written by
google just as a courtesy/to make the transition easier. They're
basically a set for vendors to assemble their hal implementations
from.

Bug: 34135607
Test: marlin persist.hal.binderization on/off
Change-Id: I2e2af5af39264cf290259755bb9b2eb9827a21f5
2017-02-13 15:03:41 -08:00
Nick Desaulniers
20105c8b71 Fingerprint VTS
Bug: 34179855
Test:
  make vts;
  adb push
    out/host/linux-x86/vts/android-vts/testcases/DATA/nativetest64/fingerprint_hidl_hal_test/fingerprint_hidl_hal_test
    /data/local/tmp/.;
  adb shell /data/local/tmp/fingerprint_hidl_hal_test;

Change-Id: If9174dc34d0802388a9af8cda88b28329248bc42
2017-02-07 12:21:38 -08:00
Yifan Hong
2b60a7d5e1 nit fix: compiler warning for BiometricsFingerprint.cpp
Test: make -j64 compiles without warning
Change-Id: Ieb8e9cd081a4e0511031b7a01deb0f7368a9d70e
2017-01-31 14:51:37 -08:00
Jim Miller
5f26c1ace2 clean up default fingerprint HIDL@2.1 implementation
- remove Binder dependency by passing keystore token to onAuthenticated()
- move notify() to cpp file

Test: recovers from killing keystore, fingerprint unlocks device,
FingerprintDialog works with crypto objects.

Fixes bug 34264028

Change-Id: Ic0de31603f4bc4147d6faf014af89e787b1ef244
2017-01-25 15:09:37 -08:00
Janis Danisevskis
a47afa9439 Adjust for minor changes in the native keystore client interface
Test: boot and use fingerprint to get an auth token
Change-Id: Ib5089457f31d17b73842e5aa4c73e61b590e6fbd
2017-01-20 13:51:53 +00:00
Jim Miller
7f7eb474ce Fix fingerprint crypto operations.
This fixes a bug introduced in the HIDL port where fingerprint no
longer notifies keystore of authentications.

Test: keyguard, FingerprintDialog

Fixes bug 34200870

Change-Id: I5227a5f7feb9eee926ea1511001d0303c90dc594
2017-01-19 13:20:05 -08:00
Jim Miller
902de51533 have hal2.1 register as the fingerprint service
Test: fingerprint's should be add-able.
Bug: 33199080
Change-Id: I30dd26c484848163ad63ee9bbd45f1d1ae869a14
2017-01-17 11:45:41 -08:00
Mark Salyzyn
3ff5260601 liblog: use log/log.h when utilizing ALOG macros
Test: compile
Bug: 30465923
Change-Id: I67046a75be057e7905570748a1ed6bfd03c0e1c8
2017-01-11 15:47:40 -08:00
Yifan Hong
f9d303435d Update to use the correct logging library.
Test: mma compiles
Change-Id: Idb33dea5faaf1a5e54719c2a5a683d2d47e9b8e8
2016-12-01 17:47:02 -08:00
Yifan Hong
6b920e43d3 Split libhidl into base and transport.
Bug: 32756130

Test: mma
Change-Id: Id21cf23abe2910f26bb7895511862443b93dc112
2016-11-18 00:00:54 -08:00
Sasha Levitskiy
52640ee9e1 Fingerprint: Treble: Fix compatibility in the interface description
Bug: 31973669
Test: Human functionality test
Change-Id: I7e3ef8eb9fbcd88a1a22e2e8bbae71756e079862
Signed-off-by: Sasha Levitskiy <sanek@google.com>
2016-11-15 17:04:51 -08:00
Sasha Levitskiy
965bd32a70 Fingerprint: HIDL: add default HAL 2.1 implementation
Test: Manual fingerprint functionality verification.

Bug: 31973669
Change-Id: Ib8bcf602ba0c8884b13d31eb23baa88a912ace20
Signed-off-by: Sasha Levitskiy <sanek@google.com>
2016-11-07 13:09:08 -08:00