Commit graph

245 commits

Author SHA1 Message Date
Steven Moreland
e489590628 specify import version (I)
Required to automate AIDL finalization - makes errors show up
now instead of later.

Bug: 188871598
Test: build
Change-Id: I6f46a39f76a73f27a71bc36e600941249ccbe8ee
Merged-In: Ic544707bac671d8327d8cc704a9d453470141e8e
2022-12-23 03:49:06 +00:00
Tim Murray
712f48c217 Fix WorkerThreadTest
Queue capacity needs to be NUM_TASKS + 1 for the extra final cv.notify
at the end.

Test: atest --host --rerun-until-failure 1000 WorkerThreadTest
Bug: b/229801892
Change-Id: I95eb07680fe80cfc3bfafaa2de81c48d61d14b4b
2022-04-20 03:33:16 +00:00
Jiyong Park
703e97920e Freeze AIDL APIs for TM
Bug: 225941299
Test: m
Change-Id: Ie41cc0797710f813f92c65c387f247c7806d8394
2022-03-31 12:01:39 +09:00
Chih-hung Hsieh
34593d4e2a Merge "Add timed out test files to tidy_timeout_srcs" am: ff54f73b4f am: fa83970b3a am: 581616e658
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1992232

Change-Id: I2eac13fe3b5ab0b4f15d6ceadf376e5e74124a81
2022-02-24 01:32:09 +00:00
Chih-Hung Hsieh
ad1bf31b78 Add timed out test files to tidy_timeout_srcs
* Timed out runs do not show any warning messages.
* These test files cannot finish clang-tidy runs with
  the following settings:
    TIDY_TIMEOUT=90
    WITH_TIDY=1
    CLANG_ANALYZER_CHECKS=1
* When TIDY_TIMEOUT is set, in Android continuous builds,
  tidy_timeout_srcs files will not be compiled by clang-tidy.
  When developers build locally without TIDY_TIMEOUT,
  tidy_timeout_srcs files will be compiled.
* Some of these test modules may be split into smaller ones,
  or disable some time consuming checks, and then
  enable clang-tidy to run within limited time.

Bug: 201099167
Test: make droid tidy-hardware-interfaces_subset
Change-Id: I1de28f1572fff368f67eab512fffec9f2e5c2a9b
2022-02-18 17:25:41 -08:00
Ilya Matyukhin
f6e0f39cde Add new fields to fingerprint PointerContext
The new fields provide additional information to the HAL about the touch
events originating from the framework.

Bug: 205915651
Test: m android.hardware.biometrics.common-update-api
Test: m android.hardware.biometrics.fingerprint-update-api
Test: lunch cf_x86_phone-userdebug && m
Change-Id: I987e26ac03e3268eea30feb9bbddffe6ca8d0035
2022-02-07 16:05:32 -08:00
Joe Bolinger
25e9823f63 Add update context method to face and fingerprint HAL.
This is needed for changes that occur mid-operation and was lost
from the previous changes when switching from the single context
method to the overloaded approach.

Bug: 204584403
Test: atest VtsHalBiometricsFingerprintTargetTest VtsHalBiometricsFaceTargetTest

Change-Id: Ie917bce9de910a421e19130b6e518bd6fc85298e
2022-01-25 01:19:56 +00:00
Joe Bolinger
13cb0fb235 Update common and fingerprint AIDL for session logging.
This also partially reverts commit 1988b3825bc95a0e7e3bb86bfa5bf70ea5323a61 which unnecessarily froze the interface during a prior interface addition.

Bug: 204585936
Bug: 204584403
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: Ibc9934390a487f5bfb9d3678ad65e7b1c3740ae7
2022-01-12 12:31:19 -08:00
Steven Moreland
77b74ffc0a Merge "CHECK -> CHECK_EQ copy pasta" am: a8138bfbf6 am: dd39b5c9d0 am: f711c9d406 am: 53c7517b02
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1921302

Change-Id: I3f32bf37c1c025e82e14ee6c9f0ffde87f6bcbd6
2021-12-14 18:40:32 +00:00
Steven Moreland
ffb03995e6 CHECK -> CHECK_EQ copy pasta
Hey did I start this? We can take a little bit better errors. :)

Bug: N/A
Test: N/A
Change-Id: I0e96f7f49dae9968904333da9b8269694058c11c
2021-12-14 01:45:47 +00:00
Joe Bolinger
ce02213c6a Update fingerprint AIDL with additional display id field.
This enables the HAL to use stable display ids (i.e. config_displayUniqueIdArray).

Bug: 174868353
Test: builds
Change-Id: Ib02e9d026d116df3f9acadf6c083f44b37b4169c
2021-10-25 20:48:04 +00:00
Yiming Pan
b692d61e3d Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" am: 9f62451015 am: 29828bc55a am: ad7f738d63 am: 8165cd5d57 am: dfe32de916
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1793837

Change-Id: Ib74eaf8e191a45e3a1dab4fcc01227231986fc7b
2021-10-01 01:30:57 +00:00
Yiming Pan
29828bc55a Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" am: 9f62451015
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1793837

Change-Id: I928b4b4c013f9109190538871b67dade51547fae
2021-10-01 00:36:41 +00:00
Yiming Pan
9f62451015 Merge "Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest" 2021-10-01 00:34:46 +00:00
Treehugger Robot
9bd4c2fa54 Merge "Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest." am: 80d2664e96 am: 1ade669804 am: b71f0a7c41 am: 232efecddc am: f6c290fc31
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1814069

Change-Id: I899b0584883d7fd44969db1ca3173df276479803
2021-09-10 18:19:45 +00:00
Treehugger Robot
1ade669804 Merge "Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest." am: 80d2664e96
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1814069

Change-Id: I3c6bd792c8c7a85ef4f31921d997f13d7d18fc9a
2021-09-10 17:22:21 +00:00
Yiming Pan
e06fdd73c0 Backfill owner information for VTS module VtsHalBiometricsFingerprintV2_2TargetTest.
Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: Id9f854295ab38c07a65d87ec32251dd5c2d687cf
2021-08-30 12:58:13 -07:00
Yiming Pan
538c89c06d Add OWNERS for VTS module VtsHalBiometricsFingerprintV2_1TargetTest
Each VTS module is required to have OWNERS file. The ownership is based on
go/vts-owners. For more information about ownership policy, please visit
go/xts-owners-policy.

Test: Tree Hugger
Bug: 143903671
Change-Id: Idebf408aad47b57901336baecbc2cbfc1cd501b0
2021-08-11 16:38:22 -07:00
Jiyong Park
d55d28a1d0 Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Merged-In: I0652f1efe920111d79dd8c2ecd52e55dda54538f
Change-Id: Ib58c9f1cb80d083a3c62d03415610be855b80f03
(cherry picked from commit c426c6dbdc)
2021-08-09 11:20:04 +09:00
Jiyong Park
c426c6dbdc Remove ndk_platform backend. Use the ndk backend.
The ndk_platform backend will soon be deprecated because the ndk backend
can serve the same purpose. This is to eliminate the confusion about
having two variants (ndk and ndk_platform) for the same ndk backend.

Bug: 161456198
Test: m
Change-Id: I0652f1efe920111d79dd8c2ecd52e55dda54538f
2021-08-04 12:48:07 +09:00
Ilya Matyukhin
f073d4a64c Merge "Update comments for IBiometricsFingerprint@2.3" into sc-dev am: 70b9c17191 am: 0a97ea1364
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15364786

Change-Id: I8912831a1dae9841b3d37c582bcd5e2a2db53385
2021-07-24 03:21:01 +00:00
Ilya Matyukhin
ca3f4c0ac1 Merge "Update comments for IBiometricsFingerprint@2.3" into sc-dev am: 70b9c17191
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15364786

Change-Id: If1aae2740b54c5539d7bced35a47bda6e5022358
2021-07-24 03:08:17 +00:00
Ilya Matyukhin
ac11a2e824 Update comments for IBiometricsFingerprint@2.3
This CL adds a comment that discourages use of this interface. The AIDL
interface, IFingerprint, should be used instead.

Bug: 160189286
Test: hidl-gen -L check android.hardware.biometrics.fingerprint@2.3::IBiometricsFingerprint
Change-Id: Ifafb191ac16e03e60d677fce6dc9e41e87bad0c0
2021-07-22 19:39:21 -07:00
Ilya Matyukhin
22e5ec680c IFingerprint: update VTS tests am: 04247248ce am: 6bf1146fb6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192112

Change-Id: I3a20e045e8a1913408f854c2001643e42fd8666c
2021-07-03 02:04:25 +00:00
Ilya Matyukhin
76b8048610 IFingerprint: update VTS tests am: 04247248ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192112

Change-Id: I7b00ebb888973faf2a06af1b2e8a8f95ef626654
2021-07-03 01:49:54 +00:00
Ilya Matyukhin
af6a74151e IFingerprint: update default implementation am: 1d52438592 am: 37ff41de0b
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192111

Change-Id: I51f9b8f9a5edc92dfb1e260dbf92e957c8aa61f8
2021-07-03 00:26:49 +00:00
Ilya Matyukhin
f3c53e9c55 IFingerprint: update default implementation am: 1d52438592
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15192111

Change-Id: I9072ef742649bb4258071c43f1fda7cc6d75db0d
2021-07-03 00:11:41 +00:00
Ilya Matyukhin
04247248ce IFingerprint: update VTS tests
Bug: 166799066
Test: VtsHalBiometricsFingerprintTargetTest
Change-Id: I2bf765890203a4edc016d1b7f0abd1d205b2a0ba
2021-07-02 23:58:58 +00:00
Ilya Matyukhin
1d52438592 IFingerprint: update default implementation
Bug: 166800618
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I0ac3a019081f4f5db6943fc019165ad1aa2e0bc8
2021-07-02 23:58:14 +00:00
Ilya Matyukhin
30f67f2b0d Merge "IFingerprint: update comments" into sc-dev am: b09f62d6a6 am: 9eeff5b010 am: e73a0e3863
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15159443

Change-Id: I5b233030274c895d2ccbc5ca7c3430d6421e7acf
2021-06-30 22:20:20 +00:00
Ilya Matyukhin
e73a0e3863 Merge "IFingerprint: update comments" into sc-dev am: b09f62d6a6 am: 9eeff5b010
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15159443

Change-Id: If38b2a274cdcb7a3387fd307f3de8e9b101c367c
2021-06-30 22:08:00 +00:00
Ilya Matyukhin
d66c3dd174 Merge "IFingerprint: update comments" into sc-dev am: b09f62d6a6
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/interfaces/+/15159443

Change-Id: Iabc733dff0c8b9c8fdff90c4eb1e083fc54ffa04
2021-06-30 21:53:49 +00:00
Ilya Matyukhin
ea8115d85d IFingerprint: update comments
Bug: 166824758
Test: N/A
Change-Id: Ie77034b88bea1c1317e8d057f19f57167d48d2c3
2021-06-30 18:27:27 +00:00
Treehugger Robot
11af040bab Merge "Replace writepid with task_profiles command for cgroup migration" am: a43f14bdac am: 7151796908 am: 555c368ddb am: f3f5630a8c
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1740279

Change-Id: I4dd443b8c75e330a6003796083501077ca1f2d07
2021-06-23 23:38:03 +00:00
Treehugger Robot
555c368ddb Merge "Replace writepid with task_profiles command for cgroup migration" am: a43f14bdac am: 7151796908
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/1740279

Change-Id: I8c9ebb5de59a2b8a87c8045cfc8c64b71eac0f10
2021-06-23 23:09:57 +00:00
Suren Baghdasaryan
dd50b2f45d Replace writepid with task_profiles command for cgroup migration
writepid command usage to join a cgroup has been deprecated in favor
of a more flexible approach using task_profiles. This way cgroup path
is not hardcoded and cgroup changes can be easily made. Replace
writepid with task_profiles command to migrate between cgroups.

Bug: 191283136
Test: build and boot
Signed-off-by: Suren Baghdasaryan <surenb@google.com>
Change-Id: I249ecc45a001a69d73b06b77154f9b6e5f9964d9
2021-06-23 18:43:27 +00:00
Evgenii Stepanov
9624ae08ae Fingerprint service example - import all deps.
Must include all parent classes in HIDL. As is, this code breaks in
HWASan, and most likely will break with -O0.

Bug: none
Test: build aosp_cf_arm64_phone-userdebug with SANITIZE_TARGET=hwaddress
Change-Id: I93e6990e758e5ae899ba15606e53f6ad7993d01d
2021-06-21 15:47:59 -07:00
Ilya Matyukhin
916410f1b1 Deflake WorkerThreadTest
Bug: 187402940
Test: atest --host --rerun-until-failure 1000 WorkerThreadTest
Change-Id: I65dc183d7a616a684a42a3780b32f6f8f55ae9c4
2021-06-09 17:55:19 -07:00
Jiyong Park
72b6359859 Freeze AIDL APIs for SC
Ignore-AOSP-First: part of SC finalization

Bug: 188713899
Test: m
Change-Id: Iee18cd05954dc8ea08cc4f985499a70977d1af4f
2021-05-25 10:13:26 +09:00
Kevin Chyn
7435e8d77c Add Error::BAD_CALIBRATION
Bug: 189133688
Test: make -j56 android.hardware.biometrics.fingerprint-update-api
Change-Id: Iea26fa2efb8e60fb5d89e89762dc76f0f0c6dce1
2021-05-24 16:53:53 -07:00
Ilya Matyukhin
77160fad8a Deflake WorkerThreadTest
Bug: 187402940
Test: atest --host --retry-until-failure 100 WorkerThreadTest
Change-Id: Ie4abd413e9cf18f73c2a4e22004dc33561006e72
2021-05-10 10:08:26 -07:00
Ilya Matyukhin
d85ab6f7a7 Add halHandlesDisplayTouches and halControlsIllumination
Bug: 185522754
Test: m android.hardware.biometrics.fingerprint-update-api
Change-Id: I3a1e71951e202212c0a0951d1b64249436619f56
2021-04-22 23:00:42 +00:00
Ilya Matyukhin
a6d4024cb2 Merge changes from topic "IFace-anapic-review" into sc-dev
* changes:
  Add enum defaults and remove placeholder constants
  Add Session#getEnrollmentConfig and better enum defaults
2021-04-22 22:58:59 +00:00
Ilya Matyukhin
c316f63cbb Add enum defaults and remove placeholder constants
Bug: 181358178
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I7acc4796cb56234280a8ec97dd3cb7921553955f
2021-04-22 12:05:37 -07:00
Ilya Matyukhin
fa6900abbd Fix IFingerprint VTS unable to link default HAL
Bug: 184614916
Test: on device without AIDL HAL
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: Iff6bebbd2f7a6ce6172d4b9b23f63073165730bc
2021-04-15 03:03:19 +00:00
Kevin Chyn
0ec2e0c3ec Change default IFingerprint HAL back to STRONG
This way, cuttlefish presubmit can run tests that require
multiple strong sensors

Bug: 163058911
Test: atest CtsBiometricsTestCases
Change-Id: I8ce66d3bc9fe8ea91465a6fcd5e7e75369b1a90f
2021-03-26 18:07:24 -07:00
Kevin Chyn
904b4f8a1e Merge "Add AcqiredInfo.RETRYING_CAPTURE to IFingerprint" into sc-dev 2021-03-25 22:59:07 +00:00
Kevin Chyn
4e9f2f79cb Add AcqiredInfo.RETRYING_CAPTURE to IFingerprint
Bug: 183154058
Test: make -j android.hardware.biometrics.fingerprint-update-api
Change-Id: I76c9f157975af5c354136e0ec9d1b04dd1098b2a
2021-03-25 12:25:21 -07:00
Ilya Matyukhin
aea213b401 Remove SessionState from IFingerprint example
Bug: 183570051
Test: atest VtsHalBiometricsFingerprintTargetTest
Change-Id: I1dd4aa0dc8bd622824ad4c0c0dde78914c49838c
2021-03-24 15:29:48 -07:00
Ilya Matyukhin
caa67677bd Remove SessionState from IFingerprint VTS
Bug: 183570051
Test: atest VtsHalBiometricsFingerprintTargetTes
Change-Id: I75d7d2e9f52db681538f6627ab4cc541ac260dd6
2021-03-24 15:29:48 -07:00