Commit graph

1544 commits

Author SHA1 Message Date
Sarah Chin
8ab8f0d1d8 Backport VTS fixes to previous test versions
Network scan check periodicity only if scan type is PERIODIC.
Fix MCC/MNC checks to handle null strings.

Test: atest VTS
Bug: 259674407
Change-Id: I77e0706f413ce9defb174f00ee145dcc01f5d780
Merged-In: I77e0706f413ce9defb174f00ee145dcc01f5d780
2023-04-28 16:28:09 -07:00
Sarah Kim
2facc26b0c Merge "Fix broken and flaky VTS tests" 2023-04-28 18:29:25 +00:00
Sarah Chin
658fdaaa2a Require SIM card for all VTS tests
We check SIM card status is PRESENT before running any VTS tests, so
ensure that it's enforced in the configs as well.

Test: atest VtsHalRadioTargetTest
Bug: 237504027
Change-Id: I1b2c317e21db118e4b957804feb76f266d887b20
Merged-In: I1b2c317e21db118e4b957804feb76f266d887b20
2023-04-27 18:44:23 -07:00
Sarah Chin
ddaea2e5a4 Fix broken and flaky VTS tests
1. nvResetConfig takes some time to reset the modem, causing subsequent
   tests to fail with a timeout since the modem is unavailabe.
   Add a timeout after nvResetConfig to allow the modem to be up again
   before running the next test.
2. Remove invalid errors for start/stopKeepalive. These tests should
   fail due to invalid arguments, so remove NONE as a possible error.
   RADIO_NOT_AVAILABLE should also be removed.
3. Fix incorrect startNetworkScan_InvalidInterval tests, since we only
   check the interval when the scan type is PERIODIC.
4. Save and reset the previous allowed network type bitmap after the
   test. Combine get/set into one test that tests both behaviors.
5. Fix checks for MCC/MNC in getDataRegistrationState

Bug: 277626718
Bug: 240953393
Bug: 264913330
Bug: 259674407
Bug: 242801688
Test: atest VtsHalRadioTargetTest
Change-Id: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
Merged-In: Ic7188f9d8ccfcd90d844b45e3b370a3be3c515d6
2023-04-27 18:43:06 -07:00
Zhang Yuan
961b3dccde Fix fail on RadioConfigTest#checkPortInfoExistsAndPortActive for dual-SIM detection
The code currently uses 'dsds' to detect dual-SIM configurations,
but it misses 'dsda' configurations, resulting in test failures.
Should use the detection mechanism by adding handling for 'dsda',
ensuring accurate detection of all dual-SIM configurations.

Bug: 277705768
Test: vts -m VtsHalRadioTargetTest -t PerInstance/RadioConfigTest#checkPortInfoExistsAndPortActive/0_android_hardware_radio_config_IRadioConfig_default

Change-Id: Ie73a958ff14e86f440831e18291b6599b6eac30b
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-04-25 21:14:42 +00:00
Pavan Kumar M
8b5cf0ca14 Update Vts for getSlicingConfig
Currently getSlicingConfigAPI always returns NOT_SUPPORTED.
But GetSlicingConfig is supported in Android U. and VTS will fail.

This change updates the expected errorcodes for getSlicingConfig API.

Tests: Builds, Boots, RadioDataTest
Bug: 228996685
Change-Id: I10cf7b0b9ba09e56605d5a498ec48c4b8972f00b
2023-04-05 16:44:49 +05:30
Chen Baoyu
2154b45320 Fix crash issue on test case RadioHidlTest_v1_5#startNetworkScan. am: a2881ffbd0
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2496776

Change-Id: I59fa870664976566743a608e857cb91d7907efa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 18:27:43 +00:00
Chen Baoyu
a2881ffbd0 Fix crash issue on test case RadioHidlTest_v1_5#startNetworkScan.
Bad safe_union access is raised by calling the GET method of
eutranBands(), because in default ctor of safe_union RadioAccessSpecifier::Bands
hidl_d is assigned with hidl_discriminator::geranBands, which conflicts
with hidl_discriminator::eutranBands, and leads to crash.

Should use the SET method of eutranBands(&) for assignment purpose.

Fix: 275077563
Bug: 271642958
Change-Id: Ie241e8968eb7f9a1297203be2ab4e0a1bf738dea
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-03-24 17:56:53 +00:00
Jack Yu
ba41b92e54 Used LTE bands for network scan am: 87abf6a366
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2493495

Change-Id: I437d499c79368cbc6a35c9a730bbcc94adde8060
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-17 03:16:19 +00:00
Jack Yu
87abf6a366 Used LTE bands for network scan
Test with LTE bands, which are supported by every device
in the world.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Change-Id: Ibc71a69b1a9aeec506a35fac9f64ecad80371155
2023-03-17 00:05:34 +00:00
Zhang Yuan
399c257ece Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed.
For those devices which does not support GSM, returning is not
supported or invalid arguments are the expected behavior.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Merged-In: I3ac7407fdee82348411db99d340613e62f36a277
Change-Id: I3ac7407fdee82348411db99d340613e62f36a277
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
(cherry picked from commit 5bf6d5777a)
2023-03-14 19:08:46 +00:00
Zhang Yuan
5bf6d5777a Add REQUEST_NOT_SUPPORTED and INVALID_ARGUMENTS to be allowed.
For those devices which does not support GSM, returning is not
supported or invalid arguments are the expected behavior.

Bug: 271642958
Test: atest VtsHalRadioTargetTest
Change-Id: I3ac7407fdee82348411db99d340613e62f36a277
Signed-off-by: Jia Jia <jia.jia@zte.com.cn>
2023-03-13 19:01:10 -07:00
Treehugger Robot
ff3de20b90 Merge "Fix setupDataCall tests for osAppid" into android13-tests-dev 2023-02-09 16:25:05 +00:00
Sarah Chin
91e2e5196f Fix setupDataCall tests for osAppid
Test: atest VtsHalRadioTargetTest
Bug: 265830733
Change-Id: I1b342bb7a829585607db4518bf4017e28b6db84f
Merged-In: I1b342bb7a829585607db4518bf4017e28b6db84f
2023-02-09 09:22:56 +00:00
Treehugger Robot
62d87cb2da Merge "VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap" into android12L-tests-dev am: 78cdf668a8 am: 221de90c16
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375494

Change-Id: Ifdf2a54524931654a4668b3a2e482541afb7e1a3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-04 02:07:30 +00:00
Treehugger Robot
221de90c16 Merge "VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap" into android12L-tests-dev am: 78cdf668a8
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2375494

Change-Id: I9a4715bfea07ec34c9cb0fe8f31360c778e172c8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-02-04 01:35:00 +00:00
Sarah Chin
47213a189c Fix setupDataCall tests for osAppid
Test: atest VtsHalRadioTargetTest
Bug: 265830733
Change-Id: I1b342bb7a829585607db4518bf4017e28b6db84f
Merged-In: I1b342bb7a829585607db4518bf4017e28b6db84f
2023-01-19 13:07:04 -08:00
Pomai Ahlo
abb09bd477 Allow Uninstantiated Test SapTest
Correct "RadioSapTest" to "SapTest"

Bug: 262975243
Test: atest VtsHalRadioTargetTest
Change-Id: I56c957d3b74f76e00cccde0012863c9080c78368
2023-01-06 10:42:18 -08:00
Bo Hu
249e4eb80e Merge changes from topic "isap_hidl2aidl"
* changes:
  Make Sap Interface Apex Available
  [ISap hidl2aidl] VTS Tests
  [ISap hidl2aidl] Compat Support
  Radio: hidl2aidl for ISap interface
2023-01-06 16:05:25 +00:00
James-YT.lin
e3d77fb6d0 VtsHalRadioV1_4Target.setPreferredNetworkTypeBitmap
Add mode not support check for setPreferredNetworkTypeBitmap.

Bug: 142369230
Test: run vts -m VtsHalRadioV1_4Target

Change-Id: I17b07f40b313f9b04e2f73d9b4a235ede891f8ea
(cherry picked from commit 16e7bf5ce3)
2023-01-04 08:43:04 +00:00
Steven Moreland
e489590628 specify import version (I)
Required to automate AIDL finalization - makes errors show up
now instead of later.

Bug: 188871598
Test: build
Change-Id: I6f46a39f76a73f27a71bc36e600941249ccbe8ee
Merged-In: Ic544707bac671d8327d8cc704a9d453470141e8e
2022-12-23 03:49:06 +00:00
Pomai Ahlo
00579368f8 Make Sap Interface Apex Available
Tag: #feature
Bug: 241969533
Test: atest com.android.bluetooth.sap
Change-Id: Ia58fb9201b37cc6b4050d1662008cf681e82bc79
2022-12-21 17:41:00 +00:00
Pomai Ahlo
f3ce10bd6c [ISap hidl2aidl] VTS Tests
Add VTS tests for the new AIDL interface

Test: atest VtsHalRadioTargetTest:PerInstance/SapTest
Bug: 241969533
Change-Id: Ia4a6be9aa0fd61c310fb539b44cc4d6a2e6e3852
Merged-In: Ia4a6be9aa0fd61c310fb539b44cc4d6a2e6e3852
2022-12-21 17:40:52 +00:00
Pomai Ahlo
1d10db6063 [ISap hidl2aidl] Compat Support
Add support for ISap in the compat shim.

Test: atest VtsHalRadioTargetTest:PerInstance/SapTest
Bug: 241969533
Change-Id: I9fe5fe194de877bcd2b85ccfa822bd6565e2dc72
Merged-In: I9fe5fe194de877bcd2b85ccfa822bd6565e2dc72
2022-12-21 17:40:43 +00:00
Myles Watson
26ae127557 Radio: hidl2aidl for ISap interface
Convert the ISap HIDL interface to AIDL using the script
Move ISap into android.hardware.radio.sap

Bug: 241969533
Test: new VTS Test
Change-Id: Ifee8c16e939f02ee4bbdb2fee23ce78b5e48df50
Merged-In: Ifee8c16e939f02ee4bbdb2fee23ce78b5e48df50
2022-12-21 17:40:19 +00:00
Steven Moreland
13666147e9 Mark modules frozen explicitly.
Makes it easier to see which versions are available.

Bug: 188871598
Test: N/A
Change-Id: Iec656df1d0008d95ab50f9bd8806517b95242f00
Merged-In: Ica76a8225fec8dc5267362cbfd43e06e65ad3f1e
2022-12-14 01:47:26 +00:00
Zhang Yuan
50f12068b8 Adding DSDA configuration for VTS.
Some of the devices which supports DSDA configuration is failing with IRadioConfig.setSimSlotsMapping() VTS. Hence improving the Test case to support.
Test: atest VtsHalRadioTargetTest
Bug: 253337352

Change-Id: I66314124dbf410d8344025aa45529652e126368a
2022-11-09 15:21:12 +00:00
Zhang Yuan
2910082f89 Adding DSDA configuration for VTS.
Some of the devices which supports DSDA configuration is failing with IRadioConfig.setSimSlotsMapping() VTS. Hence improving the Test case to support.
Test: atest VtsHalRadioTargetTest
Bug: 253337352

Change-Id: I66314124dbf410d8344025aa45529652e126368a
2022-11-09 14:39:13 +00:00
Hunsuk Choi
7fb051700a Move OWNERS from radio/aidl/vts to radio/aidl
Test: build
Bug: 210712359
Change-Id: Iceabd7663a3c9a7170b3bcf9c1baacaa1dd9564c
2022-09-21 16:33:33 +00:00
William Escande
2591c3d0cf [Bluetooth apex] Use new apex name
The Bluetooth apex name is now called com.android.btservices

Bug: 243054261
Test: Build
Change-Id: Ib63646722cbef948b5198fc5f2a9b5ac2ca52ae3
2022-08-22 11:27:58 -07:00
Treehugger Robot
fe65055051 Merge "Don't use C-style cast." am: d08759dc42
Original change: https://android-review.googlesource.com/c/platform/hardware/interfaces/+/2178554

Change-Id: If6bda47a289661afd84d40201d9beaa56f07d245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-09 06:16:31 +00:00
Tomasz Wasilczyk
b542add5c7 Don't use C-style cast.
I thought Type{valueOfOtherPrimitiveType} is a fancy way of doing static
cast. It's not. In fact, it's the same as (Type)valueOfOtherType.

Bug: 241599082
Test: make -k100 tidy-hardware-interfaces-radio
Change-Id: I85ddbe54601b9111030013be85226b90f3d2fe6f
2022-08-08 19:04:26 +00:00
Sarah Chin
e5e0792e97 VTS setSystemSelectionChannels maintain current state
Test: atest VtsHalRadioTargetTest
Bug: 231271472
Change-Id: If261f548da102963130b8cd669eb6392c9270f9a
Merged-In: If261f548da102963130b8cd669eb6392c9270f9a
2022-07-20 00:16:45 -07:00
Jooyung Han
d81d6a12be Remove AIDL-libs from VNDK
Some are still in VNDK because they are used in other VNDK libs.

Bug: 234181591
Test: m
Merged-In: If999df9c78a20df931177da11742b1c5de19bc08
Change-Id: If999df9c78a20df931177da11742b1c5de19bc08
2022-06-14 16:42:42 +09:00
Jooyung Han
c0b24f4f13 Remove AIDL-libs from VNDK
Some are still in VNDK because they are used in other VNDK libs.

Ignore-AOSP-First: some libs are still in internal master only.

Bug: 234181591
Test: m
Merged-In: If999df9c78a20df931177da11742b1c5de19bc08
Change-Id: If999df9c78a20df931177da11742b1c5de19bc08
(cherry picked from commit 5527adfd7f)
2022-06-14 14:08:59 +09:00
Sarah Chin
479ec9e172 VTS setSystemSelectionChannels maintain current state
Test: atest VtsHalRadioTargetTest
Bug: 231271472
Change-Id: If261f548da102963130b8cd669eb6392c9270f9a
2022-05-18 16:38:29 -07:00
Devin Moore
e8b22c1da1 Add changes to Radio V1 AIDL interfaces
During the API freeze some of the sub-interfaces of radio were frozen
without the latest change adding "@Javaderive(toString=true)".
Instead of creating V2 with these changes, we are updating V1 to include
these changes instead. The change will not break anyone downstream, and
any devices built with the previous V1 will continue to work. The hashes
of the original V1 interfaces are still included in the .hash files, so
VTS will allow both.

Steps taken:
m android.hardware.radio.config-freeze-api
rm aidl_api/android.hardware.radio.config/2/.hash
cp -r aidl_api/android.hardware.radio.config/2/*
    aidl_api/android.hardware.radio.config/1/
rm -rf aidl_api/android.hardware.radio.config/2/
vim Android.bp # remove the newly created version 2
system/tools/aidl/build/hash_gen.sh aidl_api/android.hardware.radio.config/1/
    latest-version aidl_api/android.hardware.radio.config/1/.hash

Test: atest hal_implementation_test
Bug: 225941299
Change-Id: Id14cfffd326bd664acb678f15f4129d85ce251b2
Merged-In: Id14cfffd326bd664acb678f15f4129d85ce251b2
2022-05-12 15:52:53 +00:00
Rambo Wang
64b9f3fdb6 Add VTS test case to cover multiple RANs per request
Test IRadioNetwork.setSignalStrengthReportingCriteria should
support multiple RANs per request.

Bug: 206857183
Test: atest VtsHalRadioTargetTest
Merged-In: I9d48029b4c2f5c36c7f48c9712c17dbdcf890dc4
Change-Id: I9d48029b4c2f5c36c7f48c9712c17dbdcf890dc4
(cherry picked from commit 926d66ed00)
2022-05-02 11:33:14 -07:00
Jiyong Park
70f5837e1f Freeze AIDL APIs for TM
Bug: 225941299
Test: m
Change-Id: I61eb51c0334eb99489c6f1570110d7e18c350c99
2022-04-16 07:03:24 +09:00
Tim Lin
118816d298 check all active ports
Bug: 226018537
Test: run vts -m VtsHalRadioTargetTest

Change-Id: Ie3d8f7387ebb2846ea772d4f879039a127282c9a
Merged-In: Ie3d8f7387ebb2846ea772d4f879039a127282c9a
2022-04-13 00:28:45 +00:00
Tim Lin
3c4b22cef2 check all active ports
Bug: 226018537
Test: run vts -m VtsHalRadioTargetTest
Change-Id: Ie3d8f7387ebb2846ea772d4f879039a127282c9a
2022-04-12 21:24:03 +08:00
Tim Lin
148303775a wait for response before running next TC
All TCs store RadioResponseInfo in a shared variable and
read it to verify the result. So there is race condition
problem if we don't wait for responses.

Bug: 228593077
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I45e60f324926588c55abd0a719fd55352767a3eb
Merged-In: I45e60f324926588c55abd0a719fd55352767a3eb
2022-04-11 10:03:50 +08:00
Tim Lin
1a55fff64b set SIM slots mapping based on current mapping
If we set the SIM slots mapping arbitrarily on single SIM enabled
device, the SIM state could become absent and cause other TCs fail.

Bug: 227693614
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I2c8d3a162e1dca5a0bd6cfe93a1cc269f4c25188
Merged-In: I2c8d3a162e1dca5a0bd6cfe93a1cc269f4c25188
2022-04-11 10:03:31 +08:00
Tim Lin
9597360e20 fix infinite loop in enableModem TC
Bug: 227585563
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I879faa5ecef026865d17ad1a23e52cb9f8f70454
Merged-In: I879faa5ecef026865d17ad1a23e52cb9f8f70454
2022-04-11 10:03:01 +08:00
Rambo Wang
8431b21a7b Merge "Add VTS test case to cover multiple RANs per request" into tm-dev 2022-04-09 01:05:07 +00:00
Rambo Wang
926d66ed00 Add VTS test case to cover multiple RANs per request
Test IRadioNetwork.setSignalStrengthReportingCriteria should
support multiple RANs per request.

Bug: 206857183
Test: atest VtsHalRadioTargetTest
Change-Id: I9d48029b4c2f5c36c7f48c9712c17dbdcf890dc4
2022-04-08 11:40:44 -07:00
Tim Lin
4370ecf4e7 wait for response before running next TC
All TCs store RadioResponseInfo in a shared variable and
read it to verify the result. So there is race condition
problem if we don't wait for responses.

Bug: 228593077
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I45e60f324926588c55abd0a719fd55352767a3eb
2022-04-08 22:54:51 +08:00
Tim Lin
c19a0bb019 set SIM slots mapping based on current mapping
If we set the SIM slots mapping arbitrarily on single SIM enabled
device, the SIM state could become absent and cause other TCs fail.

Bug: 227693614
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I2c8d3a162e1dca5a0bd6cfe93a1cc269f4c25188
2022-04-08 22:30:47 +08:00
Tim Lin
62cf454638 fix infinite loop in enableModem TC
Bug: 227585563
Test: run vts -m VtsHalRadioTargetTest
Change-Id: I879faa5ecef026865d17ad1a23e52cb9f8f70454
2022-04-07 09:35:15 +08:00
Sarah Chin
354140fd8c DeactivateDataCall remove network on all errors
Remove network on all errors instead of only RADIO_NOT_AVAIALBLE.

Test: atest DataNetworkTest
Bug: 219998284
Change-Id: I9e36829c627c7fa1286174e536ef5ff561e8b142
Merged-In: I9e36829c627c7fa1286174e536ef5ff561e8b142
2022-04-05 16:11:55 -07:00