Commit graph

11054 commits

Author SHA1 Message Date
Yifan Hong
e9fc235eb4 health: registerCallback() and getHealthInfo() does not notify all callbacks
registerCallback() and getHealthInfo() unintentionally broadcast
health info to all callbacks, which has a performance impact.

* registerCallback() still invokes the new callback immediately
* getHealthInfo() does not call any callbacks at all.

Test: VTS test call getHealthInfo does not invoke update()
Bug: 117167903
Change-Id: Ida99fdd73831e747fbf2d65089c7c0e7661fe7c4
2018-10-02 14:30:03 -07:00
Yifan Hong
a46c0dae81 health: use recursive_mutex.
Need to use an reentrant lock.

Bug: 117167903
Test: vts
Change-Id: I25a366e06ed9d983823f7276668b7f45ddcf1c2b
2018-10-02 14:30:03 -07:00
Ng Zhi An
2f5884c94c Skip hal v1 check after p on low ram devices
am: a0eb7e415c

Change-Id: I7e60e9faf24be23bf08ef65c5f0c074d4e7da2a4
2018-10-02 14:02:09 -07:00
Hridya Valsaraju
04ba91ef05 Merge "Revert "Set vendor: true for boot control HAL"" 2018-10-02 20:43:12 +00:00
Hridya Valsaraju
f8169cc2bc Revert "Set vendor: true for boot control HAL"
This reverts commit f009da1bf5.

Reason for revert: Breaking presubmit boot test on walleye

Change-Id: Ibeebb94b22cf81087b2ee60407a33e9d7e8a4d18
2018-10-02 20:09:17 +00:00
Ng Zhi An
a0eb7e415c Skip hal v1 check after p on low ram devices
Bug: 116546417
Test: vts-tradefed run commandAndExit vts
-m VtsHalCameraProviderV2_4Target
-t VtsHalCameraProviderV2_4Target#CameraHidlTest.noHal1AfterP

Change-Id: I28782b560975b49e20d6b42d599d689f819a9383
2018-10-02 19:52:50 +00:00
Treehugger Robot
c5b3b00618 Merge "Initialize healthd_mode_ops in recovery default Health HAL impl." 2018-10-02 05:21:45 +00:00
Treehugger Robot
b2fa66c4c9 Merge "Set vendor: true for boot control HAL" 2018-10-02 00:20:16 +00:00
Hridya Valsaraju
f009da1bf5 Set vendor: true for boot control HAL
Test: make boot image and check if boot contol HAL implementation
is present in vendor and recovery.
Bug: 117072247

Change-Id: Id05563fc3b4bdf135bf7e1ae75d23f34a98845ab
2018-10-01 16:11:59 -07:00
Chih-Hung Hsieh
19a5da4c13 Add noexcept to move constructors and assignment operators.
Bug: 116614593
Test: build with WITH_TIDY=1
Change-Id: Ib50ced82d650737cf99a9757133119945a3409f3
2018-10-01 20:30:38 +00:00
WyattRiley
dc4f6c49e8 Merge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev
am: 23874c7ae9

Change-Id: I957af82082f7e3dbff01159740455c71b5aaddcb
2018-10-01 08:45:04 -07:00
Treehugger Robot
23874c7ae9 Merge "Allow more time to un-blacklist strongest satelite" into pie-vts-dev 2018-10-01 15:38:05 +00:00
Hridya Valsaraju
bf0b9faaad Initialize healthd_mode_ops in recovery default Health HAL impl.
This is required for correct functioning of getHealthInfo() API
in recovery since BatteryMonitor requires healthd_mode_ops to be
initialized to update battery properties.

Bug: 78793464
Test: fastboot getvar battery-voltage
Change-Id: I9ff77664cada22e4aa3668bfb7d28d5f1d45590b
2018-09-28 21:30:20 +00:00
Hridya Valsaraju
9d2c581e8c Add command to check whether off-mode-charging is enabled.
Bug: 78793464
Bug: 79480454
Test: fastboot getvar off-mode-charge
Change-Id: I1bd4148ff3476acf110e4aa95a40084300608875
Merged-In: I1bd4148ff3476acf110e4aa95a40084300608875
(cherry picked from commit 3d76cf0d8e)
2018-09-28 14:17:48 -07:00
Hridya Valsaraju
338b0c70ef Add command to read fastboot variable 'variant'
Bug: 79480454
Test: fastboot getvar variant
Change-Id: I04f588f09d03e121c066449b0a7223f51d2e59af
Merged-In: I04f588f09d03e121c066449b0a7223f51d2e59af
(cherry picked from commit 3f27a7b373)
2018-09-28 11:44:00 -07:00
WyattRiley
074a27e28f Allow more time to un-blacklist strongest satelite
Also fixes a few intermediate values and confusing
logging discovered during weak GPS signal testing.

Change-Id: I2d3c5113956132ef4b60e28653aacf89f1159d83
Fixes: 116170859
Test: Deep indoor fail and windowledge pass of VTS on
test phone, and logcat values check.
2018-09-28 07:12:40 -07:00
Wei Wang
c45ef0e920 Add atrace HAL 1.0
Bug: 111098596
Test: vts, atrace and systrace

(cherry picked from commit db895ad8da)

Change-Id: Iea4ee4bff7509031a6daaf7c9570d0583a59affa
2018-09-27 16:35:31 -07:00
jiabin
c17b71ff83 Test getActiveMicrophones API when mic is found on the device.
am: 497edcc026

Change-Id: I55a1ab98ef141b9834ec22491b31e09f581fca1a
2018-09-27 11:39:22 -07:00
jiabin
497edcc026 Test getActiveMicrophones API when mic is found on the device.
Before this patch the default microphone was required to have characteristics
although it is not always an attached device, thus its characteristics can not
be known by the HAL. Additionally, the HAL might not know the active
microphone info of a input stream if it has not been started yet.

This patch only tests microphones which characteristics are reported by the HAL
and start the input stream before requesting active microphones.

Bug: 109787938
Test: vts-tradefed run vts --module VtsHalAudioV4_0Target
Change-Id: If55bfc8210d4f9443d34951f717c6772b46dde04
Merged-In: If55bfc8210d4f9443d34951f717c6772b46dde04
2018-09-26 10:05:15 -07:00
Rob Barnes
2c46b2e3b8 Fixed minor comment typos in IKeymasterDevice.hal
Test: 'make checkbuild' finished successfully.
Change-Id: I4ceb39475fff176bfcd57e10335aa1af64849739
2018-09-26 06:10:20 +00:00
Hridya Valsaraju
f5fda3976a Reland "Add command to pass oem commands to HAL"
Test: make

This reverts commit 2e880493d6.
Change-Id: I7cdfa6a01b5d776659dd4e7595915574b341cd9c
Merged-In: I7cdfa6a01b5d776659dd4e7595915574b341cd9c
(cherry picked from commit 3c2443ec29)
2018-09-25 23:23:36 +00:00
Steven Moreland
0d30daba94 Merge changes from topic "current-on-aosp"
* changes:
  Add health filesystem HAL to compatibility matrix
  Update power hidl to version 1.3 in compatibility_matrix.current.xml.
  Add configstore@1.1 to current matrix.
  Add compatibility_matrix.current.xml for Android Q.
2018-09-25 17:49:56 +00:00
Miao Wang
936b3a01ff Remove NNAPI 1.2 HAL hash
The interface is not finalized yet, and so it isn't frozen.

Test: mm
Change-Id: Ib4925afe2c3230c8727b3122ab21780b2f22489c
2018-09-25 01:08:53 +00:00
Yifan Hong
b58edcd198 Add health filesystem HAL to compatibility matrix
Test: no build errors
Bug: 111655771
Change-Id: I4cc6308f969840996560ac65143744d37cbf0b14
(cherry picked from commit 62ca53926e)
Merged-In: I4cc6308f969840996560ac65143744d37cbf0b14
2018-09-24 17:44:05 -07:00
Peiyong Lin
73da92ea9a Update power hidl to version 1.3 in compatibility_matrix.current.xml.
BUG: 110112323
Test: adb shell /data/nativetest/VtsHalPowerV1_3TargetTest/VtsHalPowerV1_3TargetTest
Change-Id: I397a30044850ffa8d078dce7ef201073ae65c940
(cherry picked from commit 9475cc240b)
Merged-In: I397a30044850ffa8d078dce7ef201073ae65c940
2018-09-24 17:44:05 -07:00
Steven Moreland
54ed395017 Add configstore@1.1 to current matrix.
This was added late in P. Go ahead and require
configstore@1.1 since it is built from a universal source
for all devices as well.

Bug: 69691076
Test: N/A
Change-Id: I0203ecc2e70127c11f596896f71c869d12cd3973
(cherry picked from commit 74274cfbc6)
Merged-In: I0203ecc2e70127c11f596896f71c869d12cd3973
2018-09-24 17:44:05 -07:00
Steven Moreland
3c86d9adb0 Add compatibility_matrix.current.xml for Android Q.
HAL development is starting for Andorid Q, so we need this.

Test: m compatibility_matrix.current.xml
Test: assemble_vintf (but b/78895849)
Test: boot a Pixel device after setting its target-level to 4
    and verify that the compatibility check passes, and the
    file is in the correct location (system/etc/vintf) and that
    the dependencies are setup properly.
Change-Id: I42426d0145a97c719092306abc4f7ce8fa2b51bd
(cherry picked from commit 2d2e2d5c05)
Merged-In: I42426d0145a97c719092306abc4f7ce8fa2b51bd
2018-09-24 17:38:08 -07:00
Treehugger Robot
9c6b9bf7c3 Merge "Don't use initializer_list as return type" 2018-09-24 21:24:33 +00:00
Slava Shklyaev
af528bc51c Sync docs with NeuralNetworks.h
Bug: 115855152
Test: none
Change-Id: I15b5207f3ffbea57a4c8313ce744a22ce72b402e
2018-09-24 12:31:03 +00:00
Przemyslaw Szczepaniak
96e08aa749 Merge changes from topic "nnapisync_1.2"
* changes:
  Add VTS tests for NeuralNetworks v1.2
  Create NeuralNetworks HAL v1.2 for new OperationTypes
2018-09-24 12:25:55 +00:00
Treehugger Robot
8f8c756522 Merge "Revert "Add command to pass oem commands to HAL"" 2018-09-22 00:05:37 +00:00
Hridya Valsaraju
d604080c58 Revert "Add command to pass oem commands to HAL"
This reverts commit ddaa8ecb37.

Reason for revert: This needs to go to master first to prevent build breaks.

Change-Id: I6418f1ba5dab492dc11b8c24e5d83ea7257d9699
2018-09-21 22:38:57 +00:00
Yi Kong
7392175ccd Don't use initializer_list as return type
The underlying array may be cleaned up once its lifetime has ended,
the initializer_list would become ill-formed. Return as std::vector
instead.

This fixes "-Wreturn-stack-address" (clang) / "-Winit-list-lifetime"
(gcc) warning.

Test: mma
Bug: 111998531
Change-Id: Ie5bb6bc3d0d7689744fd573c5683b22e6fb6b178
2018-09-21 15:36:57 -07:00
Yifan Hong
10becafa1e Merge "health.storage: Add VTS test." 2018-09-21 22:20:24 +00:00
Yifan Hong
14eea6bb3f health.storage: Add VTS test.
Test: run test
Bug: 111655771
Change-Id: I353026bcf882fcdafa9986e4f60d5853abac7e54
2018-09-21 12:25:24 -07:00
Slava Shklyaev
feb87a9cf8 Add VTS tests for NeuralNetworks v1.2
This is a copy the v1.1 tests since we don't have any new ops
implemented in v1.2 yet.

Bug: 114365802
Test: mm
Test: NNAPI VTS
Change-Id: Ida7525fcd3ae0fd6f88ff9591e06aba922bdae64
Merged-In: Ida7525fcd3ae0fd6f88ff9591e06aba922bdae64
(cherry-picked from 871be94770)
2018-09-21 14:46:24 +01:00
Slava Shklyaev
8e139a7a11 Create NeuralNetworks HAL v1.2 for new OperationTypes
Bug: 114365802
Test: mm
Change-Id: I86b9261729a64d02ed30dc822a0226de11473ac8
Merged-In: I86b9261729a64d02ed30dc822a0226de11473ac8
(cherry-picked from 060a9acb3b)
2018-09-21 14:41:55 +01:00
Yifan Hong
c0263aa0e4 health.storage: Add default implementation.
Test: lshal show default implementation when installed
Test: `lshal debug` (read and write successfully)
Test: `adb shell sm idle-maint run`
Bug: 111655771
Change-Id: Ibb09836b99310b6bc21e87be9c0177175efa29df
2018-09-20 17:18:53 -07:00
Amruth Ramachandran
c922f43176 Merge "Radio HAL: Add VoPS network support" 2018-09-20 18:11:22 +00:00
Kevin Rocard
921724c2c9 Audio VTS: Workaround async HIDL destructor by sleeping
am: d87a288e82

Change-Id: I6af4b725b9917d99c450287ba4bfce864371a104
2018-09-20 10:48:42 -07:00
Yifan Hong
b670abc941 Merge "health.filesystem::IFileSystem -> health.storage::IStorage" 2018-09-20 17:26:53 +00:00
Amruth Ramachandran
d146a72e2f Radio HAL: Add VoPS network support
Update 1.3 HAL:
 - Added DataRegStateResult
 - Added LteVopsInfo
 - Added getDataRegistrationStateResponse_1_3

Bug:112194535
Test: Compiled. VTS tests to be added in separate gerrit

Change-Id: I1996bb0dbfb1c585668b097c206296d5d8e3c8d0
2018-09-20 09:37:01 -07:00
Treehugger Robot
c369d81965 Merge "Add command to pass oem commands to HAL" 2018-09-20 04:19:12 +00:00
Yifan Hong
ec75d33d9c health.filesystem::IFileSystem -> health.storage::IStorage
Rename the HAL because it is regarding 'storage health',
not 'filesystem health'.

Bug: 111655771
Test: compiles
Change-Id: I07072c876fb07c88be8bd74cf6b84aec6020a697
Merged-In: I07072c876fb07c88be8bd74cf6b84aec6020a697
2018-09-19 13:11:59 -07:00
Kevin Rocard
d87a288e82 Audio VTS: Workaround async HIDL destructor by sleeping
The test creates an instance of the Audio HAL then destroys it and create it again.
The test assumed that the destruction was synchronous when in fact it is async with
no way of knowing when the object has been destroyed.

As a result, until a better solution is found, sleep for 100ms to hopefully let enouth
time for the HAL destructor to return.

Bug: 112566489
Test: adb shell /data/nativetest64/VtsHalAudioV4_0TargetTest/VtsHalAudioV4_0TargetTest --gtest_filter=*OpenPrimaryDeviceUsingGetDevice
      atest VtsHalAudioV4_0TargetTest
Change-Id: I0ec75c12007d39060232632708722df5bf0f99d7
Signed-off-by: Kevin Rocard <krocard@google.com>
2018-09-19 18:27:15 +00:00
Kevin Rocard
c23b3a5dda Merge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev
am: 2070f8b0b8

Change-Id: Icf4a294d1fef7626b8248500dffc6bcd0189571e
2018-09-18 10:57:50 -07:00
Treehugger Robot
2070f8b0b8 Merge "Audio VTS: Always check for Result::isOk()" into pie-vts-dev 2018-09-18 17:49:08 +00:00
Hridya Valsaraju
ddaa8ecb37 Add command to pass oem commands to HAL
Bug: 79480454
Bug: 78793464
Test: fastboot oem command

Change-Id: Ifa20badace91550812742702f3b16f5abe56be72
2018-09-17 15:37:42 -07:00
Treehugger Robot
9667078a6c Merge "ISafeUnion: add case w/ enum" 2018-09-14 02:50:22 +00:00
Steven Moreland
429faabc73 ISafeUnion: add case w/ enum
Bug: 115638948
Test: hidl_test
Test: hidl_test_java
Change-Id: I26b5cc25bd29c420160686b5572a005a7629784c
2018-09-13 16:38:25 -07:00