Commit graph

16 commits

Author SHA1 Message Date
Nick Desaulniers
91e1687dcc [hardware][interfaces][renderscript] fix -Wreorder-init-list
C++20 will require members in a designated initializer to be in order
unlike C99.

Bug: 139945549
Test: mm
Change-Id: I9529dba0fe407f0d16f7aee10e3629f0175b8e3e
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
2019-10-14 11:05:57 -07:00
Steven Moreland
b3a4d3832e Remove libhwbinder/libhidltransport deps
Since these were combined into libhidlbase.

Bug: 135686713
Test: build only (libhwbinder/libhidltransport are empty)
Change-Id: I075670b64eebbbbd6a6ae0e84ad51bf1c6f5ba36
2019-09-06 01:07:02 +00:00
Miao Wang
da4882059b Add missing copyright info to RS default implementation.
Bug: 118068536
Test: none
Change-Id: I896f8f4734d5bf76a889198255d5851bcd696714
2018-10-29 16:34:58 -07:00
Brian Carlstrom
3f2d71fb2d Log dlerror on dlopen related failures
Bug: 72300913
Bug: 72342986
Bug: 72462122
Test: manually confirmed logging on failure
Change-Id: I401587311e5c3e3d1ef69516645ebb2dd4479c51
2018-01-24 19:53:36 -08:00
Jae Shin
6a70875ba8 Fix cpp style cast and variable name
Test: run vts -m VtsHalRenderscriptV1_0TargetTest
Change-Id: I0c902aea13da7d4af2357ec42d8f712fda7269d4
2017-10-26 05:22:06 +00:00
Jiyong Park
0f70905b7d Load libRS_internal.so from the rs namespace
Bug: 64747884
Test: VtsHalRenderscriptV1_0TargetTest successful on the device built
with BOARD_VNDK_VERSION=current and [system] namespace config is applied
to /data/nativetest[64]/* processes.

Merged-In: I9e967c80ac2dba718cd47e1f378bcbf18abe9ad2
Change-Id: I9e967c80ac2dba718cd47e1f378bcbf18abe9ad2
(cherry picked from commit a7ef697a0a)
2017-10-26 05:21:57 +00:00
Miao Wang
0fd82f993e Merge "[RenderScript] Use OVERRIDE_RS_DRIVER string in the default implementation." into oc-dev
am: 827e291043

Change-Id: I1b6548be61440b195d283b929792a2342810120d
2017-06-02 23:28:07 +00:00
Miao Wang
41d8a44280 [RenderScript] Use OVERRIDE_RS_DRIVER string in the default
implementation.

Bug: 37035983
Test: mm
Test: manually push to sailfish & angler, verify GPU driver successfully
load, and tests are passing.

Change-Id: Ic55c74228e7eae599702365c513009aa3454656b
Merged-In: Ic55c74228e7eae599702365c513009aa3454656b
2017-06-02 23:17:31 +00:00
Steven Moreland
ee1d248ae2 Remove redundant dependencies
android.hidl.base@1.0 and android.hidlmanager@1.0 are built into libhidltransport.

Test: links
Bug: 33276472
Change-Id: I424371932af129bba9d58dcf8652c64297f35f05
2017-05-01 09:47:58 -07:00
Michael Butler
1791d9bfab Fix RS HIDL server, pass data by bytes instead of by elements.
Our current stack:
  API->API_TO_HAL_translator->HAL
          ->HAL_TO_Implementation_translator->Implementation

  For most APIs:
  - API passes objectCount.
  - HAL expects objectCount.
  - Implementation expects objectCount.

  For APIs like ScriptGroupCreate:
  - API passes byteCount. And unfortunately, these APIs are part of
    NDK, we could not make them also passing objectCount like others.
  - HAL expects objectCount.
  - Implementation expects byteCount.

  So that both API_TO_HAL_translator and
  HAL_TO_Implementation_translator should correctly convert input
  objectCount/byteCount to byteCount/objectCount.

  This CL only fixes the HAL_TO_Implementation_translator part,
  whereas aosp/356395 fixes the API_TO_HAL_translator part. Both
  parts were mistakenly using byteCount as objectCount, causing
  potential out-of-bound access.

Bug: 36404879
Test: mm on angler
Change-Id: I28541a8926aeafece40e2a3f664bda67e26a34a2
(cherry picked from commit fd14e27b89)
2017-03-29 17:42:33 -07:00
Michael Butler
fd14e27b89 Fix RS HIDL server, pass data by bytes instead of by elements.
Our current stack:
  API->API_TO_HAL_translator->HAL
          ->HAL_TO_Implementation_translator->Implementation

  For most APIs:
  - API passes objectCount.
  - HAL expects objectCount.
  - Implementation expects objectCount.

  For APIs like ScriptGroupCreate:
  - API passes byteCount. And unfortunately, these APIs are part of
    NDK, we could not make them also passing objectCount like others.
  - HAL expects objectCount.
  - Implementation expects byteCount.

  So that both API_TO_HAL_translator and
  HAL_TO_Implementation_translator should correctly convert input
  objectCount/byteCount to byteCount/objectCount.

  This CL only fixes the HAL_TO_Implementation_translator part,
  whereas aosp/356395 fixes the API_TO_HAL_translator part. Both
  parts were mistakenly using byteCount as objectCount, causing
  potential out-of-bound access.

Bug: 36404879
Test: mm on angler
Change-Id: I28541a8926aeafece40e2a3f664bda67e26a34a2
2017-03-29 17:09:57 -07:00
Steven Moreland
691a455b9f Add hidl_default and make modules use hidl_default.
find hardware/interfaces -type f -not -path "*/.git/*" \
-exec sed -i -e '/cc_[A-Za-z_]\+/ { N; s/$/\n    defaults:
\["hidl_defaults"\],/ }' {} \;
./hardware/interfaces/update-makefiles.sh

Test: no warnings
Bug: 35840847
Change-Id: I468b76893bf3f4b62ad610d1d9603bcb8797a702
2017-03-08 16:22:00 -08:00
Steven Moreland
96d2e3e9df renderscript: fix unused variable warning
Test: pass
Change-Id: I1f87c4430a908a41f7fd117de0d669420d508a69
2017-03-08 16:22:00 -08:00
Steven Moreland
d28a3dce40 Remove viral dependency on libhwbinder.
find hardware/interfaces -name Android.mk -exec sed -i -e '/libhwbinder
\\/d' {} \;
find hardware/interfaces -name Android.bp -exec sed -i -e
'/"libhwbinder"/d' {} \;
./hardware/interfaces/update-makefiles.sh

Test: everything links
Test: (sanity) booted marlin on internal master with these changes
Bug: 35710429
Change-Id: I6b0b5ae318422b7a9be17a19a79e039ffc0f9272
2017-02-24 12:01:06 -08:00
Stephen Hines
746f3cd894 Fix mips-related build breakage.
Bug: http://b/34396220
Test: Builds successfully.

MIPS targets predefine _mips to 1, which will conflict with the _mips
variable name that was being used in the HAL here. Rename it to _amips
instead, so that it won't conflict.

Merged-In: Id13f34b740959852dff600259e3405eb72d0983a
Change-Id: Id13f34b740959852dff600259e3405eb72d0983a
2017-02-21 11:56:20 -08:00
Miao Wang
b78b2f4ee6 RenderScript HIDL HAL definition and server-side implementation.
Contains the definition and implementation of the HAL.

Bug: 34396220

Test: mm, all cts tests pass on bullhead and sailfish
Merged-In: Ic560efef34f647f441c32ba01ca29d83a3d98b69
Change-Id: Ic560efef34f647f441c32ba01ca29d83a3d98b69
2017-02-21 11:55:32 -08:00