Commit graph

114 commits

Author SHA1 Message Date
Kevin Chyn
b480f01178 Add face acquired constants
Fixes: 118382625

Test: Builds
Change-Id: I3c9203c7e593aee3b110dd00e31687e364ff78bc
2018-10-25 10:53:58 -07:00
Kevin Chyn
ba9ec8795a Add IBiometricsFace#userActivity
Fixes: 116821097

Test: builds
Change-Id: I88363e186a41ce65665122606b357c7d31d8c18d
2018-10-03 18:16:30 -07:00
Kevin Chyn
2acfd2aab6 Add timeout parameter to generateChallenge
Fixes: 115925222

Test: builds
Change-Id: Idac1730b36eadb5acdb6420cc330585ebb2f3197
2018-09-24 15:27:03 -07:00
Kevin Chyn
0a9e402efe Update FaceAcquiredInfo comments
Fixes: 110887097

Test: builds
Change-Id: Ia38043cf292401aea15a34118c2cc59cacd743f0
2018-09-19 17:01:49 -07:00
Kevin Chyn
af5d0a6d1d Add setter/getter for requireAttention
Also renames pre/postEnroll to get/revokeChallenge

Bug: 110597778

Test: builds
Change-Id: I5547504b27e0f6d304f016e02be91aa15e548e5f
2018-09-05 01:46:36 -07:00
Kevin Chyn
57acf9749a Update Face HIDL enroll method
Bug: 110597778

Test: builds
Change-Id: I61e4f4a61ad0561448bc50a29b84b668e9569551
2018-09-05 00:32:11 -07:00
Steven Moreland
7a8b83e1ee vts fingerprint: IWYU utils/Condition.h am: 75023074cf am: 7f55da96a7 am: 342802f1f5
am: c11f6da572

Change-Id: I48596a08a52e3661d05c52edcd7e79d48bcbbed5
2018-08-08 11:12:39 -07:00
Steven Moreland
75023074cf vts fingerprint: IWYU utils/Condition.h
The standard library should be used instead of this class in new code,
but for simplicity, just IWYU (exposed by removing some headers from
some HIDL).

Bug: 65843592
Test: m only
Change-Id: Ib27c4c89a6aae551ebaeed05fc1bbadd780f4ba0
2018-08-07 21:36:11 +00:00
Zachary Iqbal
1f7007465d Added initial HIDL interface for the biometric face HAL.
Notes:
- Added a basic interface, a stub callback interface and a stubs for
  needed public types.
- Ran make hidl-gen -j64 && hardware/interfaces/update-makefiles.sh
  to create build files for the interface.

Bug: 79577138
Test: None added. This commit simply adds a new interface.
Change-Id: I14b7238dd9ee1076f77c1b60117bdaa156a4f0f5
2018-06-19 12:04:43 -07:00
joshmccloskey
7897d0f573 Modified tests to account for different directories being used based on
different first API levels

Fixes: 80028983
Test: Ran tests on P17 and P18
Change-Id: I2752c5b8e15dc5e3ee386b0079a75b482a21543f
2018-05-29 21:44:10 +00:00
Tim Murray
d0fdb4431d fpc: keep fpc in system-background
The fingerprint HAL is insensitive to increased CPU throughput, but it also
has a tendency to spin while waiting for FP hardware. Limit FPC to the
system-background cpuset in order to avoid increased power consumption
when accidentally touching the fingerprint sensor.

bug 76115243
Test: fingerprint in system-background cpuset on taimen

Change-Id: Iaffe6f63bd76b7a1c4acaf0cae980840af515961
2018-03-21 15:42:09 -07:00
Zhuoyao Zhang
4d413de2e7 Convert fingerprint hal test to use VtsHalHidlTargetTestEnvBase am: e95d49ac44 am: 8c85bdb217
am: 1d56f169e2

Change-Id: Icc48f25f2800a5780f467c406c8d7a59e483ad04
2018-02-09 17:50:28 +00:00
Zhuoyao Zhang
e95d49ac44 Convert fingerprint hal test to use VtsHalHidlTargetTestEnvBase
Bug: 64203181
Test: make vts
      vts-tradefed run vts -m VtsHalBiometricsFingerprintV2_0Target

Change-Id: Ia5be72669a8abae64009c659b6c991a0e64c2d0d
2018-02-08 22:24:04 -08:00
TreeHugger Robot
7d7eae9f78 Merge "Remove subdirs" into stage-aosp-master 2017-11-29 01:16:32 +00:00
TreeHugger Robot
fb9588efc0 Merge "Remove subdirs" 2017-11-29 00:48:42 +00:00
Chih-Hung Hsieh
bbeae6fe23 Use -Werror in hardware/interfaces/biometrics/fingerprint am: 5631258f07 am: a5d28736f4
am: f5f555522b

Change-Id: Ic3bc06c4a3a404f395ced8a64b04d4d27905d3b7
2017-11-29 00:19:02 +00:00
Chih-Hung Hsieh
a5d28736f4 Use -Werror in hardware/interfaces/biometrics/fingerprint
am: 5631258f07

Change-Id: I6c81b78c4d00faccefdaa3e40ebcecc26222c5e9
2017-11-29 00:02:41 +00:00
Steven Moreland
e5c6548346 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:23:43 -08:00
Steven Moreland
fcca4e23b7 Remove subdirs
Removing whenever I see these in code reviews.

Test: none
Merged-In: I4322f533a837d55618ec2ed2125e8966ace9d61d
Change-Id: I4322f533a837d55618ec2ed2125e8966ace9d61d
2017-11-28 14:22:43 -08:00
Chih-Hung Hsieh
5631258f07 Use -Werror in hardware/interfaces/biometrics/fingerprint
* Fix warning of unused function call result.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I91da207b80d0715d015195357d645f8cf324fa1e
2017-11-28 13:40:33 -08:00
Xin Li
bb9e38fef9 Merge commit '1a06284b24f5eb7bb9c1fea0817da8898b3b1bff' from
oc-mr1-dev-plus-aosp into stage-aosp-master

Change-Id: I2a044eb8c9981d0a8198ffe2df55559afbd76341
Merged-In: I4fb9f18884f7ef21162015a0032c4431444f7025
2017-11-14 12:08:38 -08:00
Steven Moreland
8db261bc99 Updating makefiles for hidl_interface.
Bug: 64487114
Test: manual
Merged-In: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
Change-Id: Ie13d9e014cf2b81c18c67f551b4644fb9f0ba812
2017-11-13 10:00:18 -08:00
Steven Moreland
a1169dd600 Update makefiles for hidl_interface.
Bug: 35570956
Test: manual
Change-Id: I7a220b78ee081240e1dc30ef5672ba39e3e98375
2017-11-10 09:06:55 -08:00
Steven Moreland
d28c1bdf62 Merge "Automatic mk -> bp." am: e5fd969f19 am: 72c720a4e3
am: 26013bf6ac

Change-Id: Id936fb4806d122045c771c951220361efeef10c6
2017-11-07 21:24:49 +00:00
Steven Moreland
26013bf6ac Merge "Automatic mk -> bp." am: e5fd969f19
am: 72c720a4e3

Change-Id: Icfc8b46117e94461906806023852836a0ace3a55
2017-11-07 21:21:40 +00:00
Steven Moreland
90e3a50f03 Automatic mk -> bp.
Automatic mk -> bp conversion for all modules here
which can be converted and built automatically.

Test: Soong resolves all dependencies
Bug: 37512442
Change-Id: Ib789212cb88d55731397c600d132e7c672c0d8be
2017-11-03 16:30:28 +00:00
Tri Vo
dce01a0e64 Merge "Change tmp dir to /data/system/users/0/fpdata/." am: 3f4e982fbc am: 05a6820b76 am: 245ae95aa1
am: 75a193f6dc

Change-Id: Ic0a809c865d5bc4546483fff5dc34609ab024915
2017-10-15 04:00:09 +00:00
Tri Vo
75a193f6dc Merge "Change tmp dir to /data/system/users/0/fpdata/." am: 3f4e982fbc am: 05a6820b76
am: 245ae95aa1

Change-Id: I351a9f8bd8c4b7eeb311c4379f3ee21860ea0e3f
2017-10-15 03:43:18 +00:00
Tri Vo
3f4e982fbc Merge "Change tmp dir to /data/system/users/0/fpdata/." 2017-10-12 16:08:05 +00:00
Tri Vo
7314d858bf Change tmp dir to /data/system/users/0/fpdata/.
FP hal service can now access test tmp files without selinux denials.

Bug: 67665189
Test: VtsHalBiometricsFingerprintV2_1Target
Change-Id: Ie0a46513524c27bdb7bb42b08eabb57e943b26c6
2017-10-11 14:59:28 -07:00
Steven Moreland
1d7374c5e1 Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1 am: 6c811964a1
am: 116161d94e

Change-Id: I33643636e2511de77fdf7de57777eb67edee2e52
2017-10-11 16:39:21 +00:00
Steven Moreland
116161d94e Update for Soong java makefiles. am: c3e80fa01e am: 0fff75dee1
am: 6c811964a1

Change-Id: I85ccbb4a15cd18938607f5bca4e065b9d7e0182b
2017-10-11 16:31:07 +00:00
Steven Moreland
c3e80fa01e Update for Soong java makefiles.
Test: pass
Bug: 33420795
Change-Id: Id9b1919a19b8ff682738cfb0869a479b4dbb4293
2017-10-10 23:07:20 +00:00
Steven Moreland
70bfb9d250 Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f am: b53e6ad535
am: 9a17f41f6f

Change-Id: I78d9292068b372238554fd9d35128e69f5b5f9d2
2017-10-04 21:54:11 +00:00
Steven Moreland
9a17f41f6f Merge "Update for hidl adapter module defaults." am: 988c977079 am: 861651985f
am: b53e6ad535

Change-Id: I23269fb7a9bdd352e670a80f390527d9eef31412
2017-10-04 21:51:00 +00:00
Steven Moreland
527fd76a0e Update for hidl adapter module defaults.
Test: pass
Change-Id: Idc6a943149a279bf17cfcfd0f2571473e53bbbbf
2017-10-04 12:47:03 -07:00
Steven Moreland
91799c6cc7 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3 am: 71a193a425
am: 9fdd241905

Change-Id: I1c852fa6600fecc44d5afd1a65a5f51c43ecf71c
2017-09-27 00:02:52 +00:00
Steven Moreland
9fdd241905 Merge "Fix typo in update makefiles." am: 9960148420 am: f07e364ce3
am: 71a193a425

Change-Id: I45ae43f07323254212532acbf0f891d11143b05f
2017-09-26 23:58:51 +00:00
Steven Moreland
a5299ee739 Fix typo in update makefiles.
Bug: 37518178
Test: pass
Change-Id: Ic401b3a473f15ca4c01e58b3072e19db7c31b653
2017-09-26 21:59:43 +00:00
Steven Moreland
7741c0e17b Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e am: b94d0c7290
am: 97228c0b7d

Change-Id: Ic4b459b7c1a4325453945b0b00db8f44e4e77c26
2017-09-26 13:36:09 +00:00
Steven Moreland
97228c0b7d Update makefiles for hidl adapter. am: 26a0bb2762 am: 73949c1d7e
am: b94d0c7290

Change-Id: If766cffbcc003cc0cc5eb98969b924aa918fff44
2017-09-26 12:53:13 +00:00
Steven Moreland
26a0bb2762 Update makefiles for hidl adapter.
Bug: 37518178
Test: manual
Change-Id: I50e999907d3c64d2b039272b823971998da64d1b
2017-09-25 18:35:56 +00:00
Jaekyun Seok
81104ae5ef Add 'vendor.' prefix to a vendor HAL service name
To prevent property name collisions between properties of system and
vendor, 'vendor.' prefix must be added to a vendor HAL service name.
You can see the details in http://go/treble-sysprop-compatibility.

Test: succeeded building and tested on a walleye device
Bug: 36796459
Change-Id: I4e8fbee791ec917a8f627a1366f4d44ec7e6febc
2017-09-12 08:01:42 +09:00
Tri Vo
b65c5ceff2 VTS tests now static link to HAL def libs.
And use VtsHalTargetTestDefaults.
This is a partial cherry-pick of ag/2657080.

Bug: 64040096
Test: compiles, works fine in internal master
Merged-In: I8f6995e9536a9aefe283ee3effec9f5a7f03b620
Change-Id: I76d47d8546416b57055841851a9d343026cd3210
2017-08-25 11:48:10 -07:00
Nick Desaulniers
3c739df264 biometrics: fingerprint: add locking to default impl
am: e637aa32b8

Change-Id: Ib9f1d713917a87520353d67b8cdabfcdd1f20048
2017-08-18 21:22:46 +00:00
Nick Desaulniers
e637aa32b8 biometrics: fingerprint: add locking to default impl
There exists the following race condition:
a). thread A receives setNotify and sets the callback to some object
b). thread B of the wrapped implementation calls
BiometricsFingerprint::notify which it was given a handle to. Thread B
executes past the nullptr check:
c). thread A receives setNotify and sets the callback to some other
object (or nullptr)
d). thread B resumes in notify with unknown state

Add mutex to protect access to mClientCallback.

Change-Id: I9163204ff5802e9246056caeb2a7857e6138531c
Fixes: 64802340
Test: VtsHalBiometricsFingerprintV2_1IfaceFuzzer
2017-08-18 17:14:53 +00:00
Steven Moreland
dfd8287506 Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Merged-In: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
Merged-In: Ifdc3c17cb2b85c18b37dac2d03bb5c8935c23180
Change-Id: I170fa1c4fe39f8109b1670db58ef99bb11afc0be
2017-08-14 20:25:09 +00:00
Steven Moreland
4f25c2a143 Revert "Revert "Updating all makefiles.""
Relanding without automotive/vehicle/2.0+2.1 changes.

This reverts commit 1020ebedfb.

Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: Icc49df42c2bedf443d878d5d8fbaa53441ea65db
2017-08-11 23:02:01 +00:00
Steven Moreland
1020ebedfb Revert "Updating all makefiles."
This reverts commit 8ac1971678.

Reason for revert: Didn't remove automotive changes from this CL.

Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: I1c660cffc8817ad0b33da9f6eceb3d88e7c48416
2017-08-11 22:56:56 +00:00
Steven Moreland
8ac1971678 Updating all makefiles.
Bug: 64487114
Test: none
Merged-In: I8608c8f636c35f21e4246a805a9eff6d14124e0a
Change-Id: I2fa89b6661c39859ec4fb62c4bb0a05a35e645f0
2017-08-10 22:40:04 +00:00