926a8e7440
Failed cases:
AttestationTest.RsaAttestation
AttestationTest.EcAttestation
Analysis:
The verify_attestation_record() in Keymaster_hidl_hal_test.cpp calls
parse_attestation_record() to set the value of att_challenge. It fails
to compare att_challenge with challenge by memcmp.
Because setToExternal() method uses buffer pointer to local variable
(record), not use memcpy to copy into itself buffer in
parse_attestation_record(). When it leaves the parse_attestation_record(),
we will get the att_challenge which is null buffer to compare with challenge
incorrectly.
Fix: use memcpy to copy the buffer.
Bug: 65039571
Test: build passed. VtsHalKeymasterV3_0Target -> PASSED: 106, FAILED: 0.
Change-Id: I700a9242cc9a5f4cb196b62860823601e4088531
Merged-In: I700a9242cc9a5f4cb196b62860823601e4088531
(cherry picked from
|
||
|---|---|---|
| .. | ||
| Android.mk | ||
| attestation_record.cpp | ||
| attestation_record.h | ||
| authorization_set.cpp | ||
| authorization_set.h | ||
| key_param_output.cpp | ||
| key_param_output.h | ||
| keymaster_hidl_hal_test.cpp | ||
| keymaster_tags.h | ||
| keystore_tags_utils.cpp | ||
| openssl_utils.h | ||