3847ffcc0e
The default Treble boot HAL implementation currently can only work in recovery on devices that specifically build their libhardware implementation as a shared library for recovery. This CL adds the option to statically link the libhardware implementation in recovery instead of finding it using hw_get_module(). This new approach allows devices that define PRODUCT_STATIC_BOOT_CONTROL_HAL to begin using the Treble HAL in recovery without requiring device-specific changes. A previous version of this CL broke some device builds by omitting libbase.recovery from LOCAL_SHARED_LIBRARIES. This version fixes that issue. Test: adb sideload succeeds Bug: 78598708 Change-Id: I1c2ef7fa59575ac7975129f7544f741459b8540e Signed-off-by: Connor O'Brien <connoro@google.com>
134 lines
4.1 KiB
C++
134 lines
4.1 KiB
C++
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
#define LOG_TAG "android.hardware.boot@1.0-impl"
|
|
|
|
#include <log/log.h>
|
|
|
|
#include <hardware/hardware.h>
|
|
#include <hardware/boot_control.h>
|
|
#include "BootControl.h"
|
|
|
|
#ifdef BOOT_CONTROL_RECOVERY
|
|
extern const hw_module_t HAL_MODULE_INFO_SYM;
|
|
#endif
|
|
|
|
namespace android {
|
|
namespace hardware {
|
|
namespace boot {
|
|
namespace V1_0 {
|
|
namespace implementation {
|
|
|
|
BootControl::BootControl(boot_control_module_t *module) : mModule(module){
|
|
}
|
|
|
|
// Methods from ::android::hardware::boot::V1_0::IBootControl follow.
|
|
Return<uint32_t> BootControl::getNumberSlots() {
|
|
return mModule->getNumberSlots(mModule);
|
|
}
|
|
|
|
Return<uint32_t> BootControl::getCurrentSlot() {
|
|
return mModule->getCurrentSlot(mModule);
|
|
}
|
|
|
|
Return<void> BootControl::markBootSuccessful(markBootSuccessful_cb _hidl_cb) {
|
|
int ret = mModule->markBootSuccessful(mModule);
|
|
struct CommandResult cr;
|
|
cr.success = (ret == 0);
|
|
cr.errMsg = strerror(-ret);
|
|
_hidl_cb(cr);
|
|
return Void();
|
|
}
|
|
|
|
Return<void> BootControl::setActiveBootSlot(uint32_t slot, setActiveBootSlot_cb _hidl_cb) {
|
|
int ret = mModule->setActiveBootSlot(mModule, slot);
|
|
struct CommandResult cr;
|
|
cr.success = (ret == 0);
|
|
cr.errMsg = strerror(-ret);
|
|
_hidl_cb(cr);
|
|
return Void();
|
|
}
|
|
|
|
Return<void> BootControl::setSlotAsUnbootable(uint32_t slot, setSlotAsUnbootable_cb _hidl_cb) {
|
|
int ret = mModule->setSlotAsUnbootable(mModule, slot);
|
|
struct CommandResult cr;
|
|
cr.success = (ret == 0);
|
|
cr.errMsg = strerror(-ret);
|
|
_hidl_cb(cr);
|
|
return Void();
|
|
}
|
|
|
|
Return<BoolResult> BootControl::isSlotBootable(uint32_t slot) {
|
|
int32_t ret = mModule->isSlotBootable(mModule, slot);
|
|
if (ret < 0) {
|
|
return BoolResult::INVALID_SLOT;
|
|
}
|
|
return ret ? BoolResult::TRUE : BoolResult::FALSE;
|
|
}
|
|
|
|
Return<BoolResult> BootControl::isSlotMarkedSuccessful(uint32_t slot) {
|
|
int32_t ret = mModule->isSlotMarkedSuccessful(mModule, slot);
|
|
if (ret < 0) {
|
|
return BoolResult::INVALID_SLOT;
|
|
}
|
|
return ret ? BoolResult::TRUE : BoolResult::FALSE;
|
|
}
|
|
|
|
Return<void> BootControl::getSuffix(uint32_t slot, getSuffix_cb _hidl_cb) {
|
|
hidl_string ans;
|
|
const char *suffix = mModule->getSuffix(mModule, slot);
|
|
if (suffix) {
|
|
ans = suffix;
|
|
}
|
|
_hidl_cb(ans);
|
|
return Void();
|
|
}
|
|
|
|
#ifdef BOOT_CONTROL_RECOVERY
|
|
IBootControl* HIDL_FETCH_IBootControl(const char * /* hal */) {
|
|
boot_control_module_t* module;
|
|
|
|
// For devices that don't build a standalone libhardware bootctrl impl for recovery,
|
|
// we simulate the hw_get_module() by accessing it from the current process directly.
|
|
const hw_module_t* hw_module = &HAL_MODULE_INFO_SYM;
|
|
if (!hw_module ||
|
|
strcmp(BOOT_CONTROL_HARDWARE_MODULE_ID, hw_module->id) != 0) {
|
|
ALOGE("Error loading boot_control HAL implementation: %d.", -EINVAL);
|
|
return nullptr;
|
|
}
|
|
module = reinterpret_cast<boot_control_module_t*>(const_cast<hw_module_t*>(hw_module));
|
|
module->init(module);
|
|
return new BootControl(module);
|
|
}
|
|
#else
|
|
IBootControl* HIDL_FETCH_IBootControl(const char* /* hal */) {
|
|
int ret = 0;
|
|
boot_control_module_t* module = NULL;
|
|
hw_module_t **hwm = reinterpret_cast<hw_module_t**>(&module);
|
|
ret = hw_get_module(BOOT_CONTROL_HARDWARE_MODULE_ID, const_cast<const hw_module_t**>(hwm));
|
|
if (ret)
|
|
{
|
|
ALOGE("hw_get_module %s failed: %d", BOOT_CONTROL_HARDWARE_MODULE_ID, ret);
|
|
return nullptr;
|
|
}
|
|
module->init(module);
|
|
return new BootControl(module);
|
|
}
|
|
#endif
|
|
} // namespace implementation
|
|
} // namespace V1_0
|
|
} // namespace boot
|
|
} // namespace hardware
|
|
} // namespace android
|