platform_hardware_interfaces/audio/aidl/default/r_submix/SubmixRoute.cpp
Mikhail Naganov 9eb3314a24 audio: Improve logging in remote submix module
Implement IModule::dump to display the current state in
the audioflinger dump.

Throttle repetitive logging when there is nothing to read.

Remove stale comment for already fixed b/307586684.

Bug: 307586684
Test: adb shell dumpsys media.audio_flinger
Change-Id: I1f1f6e1658d035d46af3a933a825b20a78c7f297
2024-01-09 14:13:15 -08:00

298 lines
10 KiB
C++

/*
* Copyright (C) 2023 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#include <mutex>
#define LOG_TAG "AHAL_SubmixRoute"
#include <android-base/logging.h>
#include <media/AidlConversionCppNdk.h>
#include <Utils.h>
#include "SubmixRoute.h"
using aidl::android::hardware::audio::common::getChannelCount;
using aidl::android::media::audio::common::AudioDeviceAddress;
namespace aidl::android::hardware::audio::core::r_submix {
// static
SubmixRoute::RoutesMonitor SubmixRoute::getRoutes(bool tryLock) {
static std::mutex submixRoutesLock;
static RoutesMap submixRoutes;
return !tryLock ? RoutesMonitor(submixRoutesLock, submixRoutes)
: RoutesMonitor(submixRoutesLock, submixRoutes, tryLock);
}
// static
std::shared_ptr<SubmixRoute> SubmixRoute::findOrCreateRoute(const AudioDeviceAddress& deviceAddress,
const AudioConfig& pipeConfig) {
auto routes = getRoutes();
auto routeItr = routes->find(deviceAddress);
if (routeItr != routes->end()) {
return routeItr->second;
}
auto route = std::make_shared<SubmixRoute>();
if (::android::OK != route->createPipe(pipeConfig)) {
LOG(ERROR) << __func__ << ": create pipe failed";
return nullptr;
}
routes->emplace(deviceAddress, route);
return route;
}
// static
std::shared_ptr<SubmixRoute> SubmixRoute::findRoute(const AudioDeviceAddress& deviceAddress) {
auto routes = getRoutes();
auto routeItr = routes->find(deviceAddress);
if (routeItr != routes->end()) {
return routeItr->second;
}
return nullptr;
}
// static
void SubmixRoute::removeRoute(const AudioDeviceAddress& deviceAddress) {
getRoutes()->erase(deviceAddress);
}
// static
std::string SubmixRoute::dumpRoutes() {
auto routes = getRoutes(true /*tryLock*/);
std::string result;
if (routes->empty()) result.append(" <Empty>");
for (const auto& r : *(routes.operator->())) {
result.append(" - ")
.append(r.first.toString())
.append(": ")
.append(r.second->dump())
.append("\n");
}
return result;
}
// Verify a submix input or output stream can be opened.
bool SubmixRoute::isStreamConfigValid(bool isInput, const AudioConfig& streamConfig) {
// If the stream is already open, don't open it again.
// ENABLE_LEGACY_INPUT_OPEN is default behaviour
if (!isInput && isStreamOutOpen()) {
LOG(ERROR) << __func__ << ": output stream already open.";
return false;
}
// If either stream is open, verify the existing pipe config matches the stream config.
if (hasAtleastOneStreamOpen() && !isStreamConfigCompatible(streamConfig)) {
return false;
}
return true;
}
// Compare this stream config with existing pipe config, returning false if they do *not*
// match, true otherwise.
bool SubmixRoute::isStreamConfigCompatible(const AudioConfig& streamConfig) {
std::lock_guard guard(mLock);
if (streamConfig.channelLayout != mPipeConfig.channelLayout) {
LOG(ERROR) << __func__ << ": channel count mismatch, stream channels = "
<< streamConfig.channelLayout.toString()
<< " pipe config channels = " << mPipeConfig.channelLayout.toString();
return false;
}
if (streamConfig.sampleRate != mPipeConfig.sampleRate) {
LOG(ERROR) << __func__
<< ": sample rate mismatch, stream sample rate = " << streamConfig.sampleRate
<< " pipe config sample rate = " << mPipeConfig.sampleRate;
return false;
}
if (streamConfig.format != mPipeConfig.format) {
LOG(ERROR) << __func__
<< ": format mismatch, stream format = " << streamConfig.format.toString()
<< " pipe config format = " << mPipeConfig.format.toString();
return false;
}
return true;
}
bool SubmixRoute::hasAtleastOneStreamOpen() {
std::lock_guard guard(mLock);
return (mStreamInOpen || mStreamOutOpen);
}
// We DO NOT block if:
// - no peer input stream is present
// - the peer input is in standby AFTER having been active.
// We DO block if:
// - the input was never activated to avoid discarding first frames in the pipe in case capture
// start was delayed
bool SubmixRoute::shouldBlockWrite() {
std::lock_guard guard(mLock);
return (mStreamInOpen || (mStreamInStandby && (mReadCounterFrames != 0)));
}
long SubmixRoute::updateReadCounterFrames(size_t frameCount) {
std::lock_guard guard(mLock);
mReadCounterFrames += frameCount;
return mReadCounterFrames;
}
void SubmixRoute::openStream(bool isInput) {
std::lock_guard guard(mLock);
if (isInput) {
if (mStreamInOpen) {
mInputRefCount++;
} else {
mInputRefCount = 1;
mStreamInOpen = true;
}
mStreamInStandby = true;
mReadCounterFrames = 0;
if (mSink != nullptr) {
mSink->shutdown(false);
}
} else {
mStreamOutOpen = true;
}
}
void SubmixRoute::closeStream(bool isInput) {
std::lock_guard guard(mLock);
if (isInput) {
if (--mInputRefCount == 0) {
mStreamInOpen = false;
if (mSink != nullptr) {
mSink->shutdown(true);
}
}
} else {
mStreamOutOpen = false;
}
}
// If SubmixRoute doesn't exist for a port, create a pipe for the submix audio device of size
// buffer_size_frames and store config of the submix audio device.
::android::status_t SubmixRoute::createPipe(const AudioConfig& streamConfig) {
const int channelCount = getChannelCount(streamConfig.channelLayout);
const audio_format_t audioFormat = VALUE_OR_RETURN_STATUS(
aidl2legacy_AudioFormatDescription_audio_format_t(streamConfig.format));
const ::android::NBAIO_Format format =
::android::Format_from_SR_C(streamConfig.sampleRate, channelCount, audioFormat);
const ::android::NBAIO_Format offers[1] = {format};
size_t numCounterOffers = 0;
const size_t pipeSizeInFrames =
r_submix::kDefaultPipeSizeInFrames *
((float)streamConfig.sampleRate / r_submix::kDefaultSampleRateHz);
LOG(VERBOSE) << __func__ << ": creating pipe, rate : " << streamConfig.sampleRate
<< ", pipe size : " << pipeSizeInFrames;
// Create a MonoPipe with optional blocking set to true.
sp<MonoPipe> sink = sp<MonoPipe>::make(pipeSizeInFrames, format, true /*writeCanBlock*/);
if (sink == nullptr) {
LOG(FATAL) << __func__ << ": sink is null";
return ::android::UNEXPECTED_NULL;
}
// Negotiation between the source and sink cannot fail as the device open operation
// creates both ends of the pipe using the same audio format.
ssize_t index = sink->negotiate(offers, 1, nullptr, numCounterOffers);
if (index != 0) {
LOG(FATAL) << __func__ << ": Negotiation for the sink failed, index = " << index;
return ::android::BAD_INDEX;
}
sp<MonoPipeReader> source = sp<MonoPipeReader>::make(sink.get());
if (source == nullptr) {
LOG(FATAL) << __func__ << ": source is null";
return ::android::UNEXPECTED_NULL;
}
numCounterOffers = 0;
index = source->negotiate(offers, 1, nullptr, numCounterOffers);
if (index != 0) {
LOG(FATAL) << __func__ << ": Negotiation for the source failed, index = " << index;
return ::android::BAD_INDEX;
}
LOG(VERBOSE) << __func__ << ": Pipe frame size : " << streamConfig.frameSize
<< ", pipe frames : " << sink->maxFrames();
// Save references to the source and sink.
{
std::lock_guard guard(mLock);
mPipeConfig = streamConfig;
mPipeConfig.frameCount = sink->maxFrames();
mSink = std::move(sink);
mSource = std::move(source);
}
return ::android::OK;
}
// Release references to the sink and source.
AudioConfig SubmixRoute::releasePipe() {
std::lock_guard guard(mLock);
mSink.clear();
mSource.clear();
return mPipeConfig;
}
::android::status_t SubmixRoute::resetPipe() {
return createPipe(releasePipe());
}
void SubmixRoute::standby(bool isInput) {
std::lock_guard guard(mLock);
if (isInput) {
mStreamInStandby = true;
} else if (!mStreamOutStandby) {
mStreamOutStandby = true;
mStreamOutStandbyTransition = true;
}
}
void SubmixRoute::exitStandby(bool isInput) {
std::lock_guard guard(mLock);
if (isInput) {
if (mStreamInStandby || mStreamOutStandbyTransition) {
mStreamInStandby = false;
mStreamOutStandbyTransition = false;
mReadCounterFrames = 0;
}
} else {
if (mStreamOutStandby) {
mStreamOutStandby = false;
mStreamOutStandbyTransition = true;
}
}
}
std::string SubmixRoute::dump() NO_THREAD_SAFETY_ANALYSIS {
const bool isLocked = mLock.try_lock();
std::string result = std::string(isLocked ? "" : "! ")
.append("Input ")
.append(mStreamInOpen ? "open" : "closed")
.append(mStreamInStandby ? ", standby" : ", active")
.append(", refcount: ")
.append(std::to_string(mInputRefCount))
.append(", framesRead: ")
.append(mSource ? std::to_string(mSource->framesRead()) : "<null>")
.append("; Output ")
.append(mStreamOutOpen ? "open" : "closed")
.append(mStreamOutStandby ? ", standby" : ", active")
.append(", framesWritten: ")
.append(mSink ? std::to_string(mSink->framesWritten()) : "<null>");
if (isLocked) mLock.unlock();
return result;
}
} // namespace aidl::android::hardware::audio::core::r_submix