platform_hardware_interfaces/sensors/common/utils/EventMessageQueueWrapper.h
Jintao Zhu cfefc7b5e8 Fix RefBase Explicit destruction
For an object to be managed by std smart pointer, its base class should NOT be "RefBase".  It is not only unnecessary but also risking the object being owned by android smart pointer as well, which may destroy the object two times.

This issue may be detected by the destructor of class RefBase, with the log complaint "RefBase: Explicit destruction,..."

Test: monkey test for one day and one night

Signed-off-by: Jintao Zhu <zhujtcsieee@gmail.com>
Change-Id: If7736770983e17f5a4125b19dfbd1745ee5a9589
2021-03-18 23:39:11 +08:00

145 lines
No EOL
5.2 KiB
C++

/*
* Copyright (C) 2020 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
#ifndef ANDROID_HARDWARE_SENSORS_V2_1_EVENTMESSAGEQUEUEWRAPPER_H
#define ANDROID_HARDWARE_SENSORS_V2_1_EVENTMESSAGEQUEUEWRAPPER_H
#include "convertV2_1.h"
#include <android/hardware/sensors/2.1/types.h>
#include <fmq/MessageQueue.h>
#include <hidl/MQDescriptor.h>
#include <hidl/Status.h>
#include <log/log.h>
#include <atomic>
namespace android {
namespace hardware {
namespace sensors {
namespace V2_1 {
namespace implementation {
class EventMessageQueueWrapperBase {
public:
virtual ~EventMessageQueueWrapperBase() {}
virtual std::atomic<uint32_t>* getEventFlagWord() = 0;
virtual size_t availableToRead() = 0;
virtual size_t availableToWrite() = 0;
virtual bool read(V2_1::Event* events, size_t numToRead) = 0;
virtual bool write(const V2_1::Event* events, size_t numToWrite) = 0;
virtual bool write(const std::vector<V2_1::Event>& events) = 0;
virtual bool writeBlocking(const V2_1::Event* events, size_t count, uint32_t readNotification,
uint32_t writeNotification, int64_t timeOutNanos,
android::hardware::EventFlag* evFlag) = 0;
virtual size_t getQuantumCount() = 0;
};
class EventMessageQueueWrapperV1_0 : public EventMessageQueueWrapperBase {
public:
using EventMessageQueue = MessageQueue<V1_0::Event, kSynchronizedReadWrite>;
EventMessageQueueWrapperV1_0(std::unique_ptr<EventMessageQueue>& queue)
: mQueue(std::move(queue)) {}
const ::android::hardware::MQDescriptorSync<V1_0::Event>* getDesc() {
return mQueue->getDesc();
}
virtual std::atomic<uint32_t>* getEventFlagWord() override {
return mQueue->getEventFlagWord();
}
virtual size_t availableToRead() override { return mQueue->availableToRead(); }
size_t availableToWrite() override { return mQueue->availableToWrite(); }
virtual bool read(V2_1::Event* events, size_t numToRead) override {
return mQueue->read(reinterpret_cast<V1_0::Event*>(events), numToRead);
}
bool write(const V2_1::Event* events, size_t numToWrite) override {
return mQueue->write(reinterpret_cast<const V1_0::Event*>(events), numToWrite);
}
virtual bool write(const std::vector<V2_1::Event>& events) override {
const std::vector<V1_0::Event>& oldEvents = convertToOldEvents(events);
return mQueue->write(oldEvents.data(), oldEvents.size());
}
bool writeBlocking(const V2_1::Event* events, size_t count, uint32_t readNotification,
uint32_t writeNotification, int64_t timeOutNanos,
android::hardware::EventFlag* evFlag) override {
return mQueue->writeBlocking(reinterpret_cast<const V1_0::Event*>(events), count,
readNotification, writeNotification, timeOutNanos, evFlag);
}
size_t getQuantumCount() override { return mQueue->getQuantumCount(); }
private:
std::unique_ptr<EventMessageQueue> mQueue;
};
class EventMessageQueueWrapperV2_1 : public EventMessageQueueWrapperBase {
public:
using EventMessageQueue = MessageQueue<V2_1::Event, kSynchronizedReadWrite>;
EventMessageQueueWrapperV2_1(std::unique_ptr<EventMessageQueue>& queue)
: mQueue(std::move(queue)) {}
const ::android::hardware::MQDescriptorSync<V2_1::Event>* getDesc() {
return mQueue->getDesc();
}
std::atomic<uint32_t>* getEventFlagWord() override { return mQueue->getEventFlagWord(); }
virtual size_t availableToRead() override { return mQueue->availableToRead(); }
size_t availableToWrite() override { return mQueue->availableToWrite(); }
virtual bool read(V2_1::Event* events, size_t numToRead) override {
return mQueue->read(events, numToRead);
}
bool write(const V2_1::Event* events, size_t numToWrite) override {
return mQueue->write(events, numToWrite);
}
bool write(const std::vector<V2_1::Event>& events) override {
return mQueue->write(events.data(), events.size());
}
bool writeBlocking(const V2_1::Event* events, size_t count, uint32_t readNotification,
uint32_t writeNotification, int64_t timeOutNanos,
android::hardware::EventFlag* evFlag) override {
return mQueue->writeBlocking(events, count, readNotification, writeNotification,
timeOutNanos, evFlag);
}
size_t getQuantumCount() override { return mQueue->getQuantumCount(); }
private:
std::unique_ptr<EventMessageQueue> mQueue;
};
} // namespace implementation
} // namespace V2_1
} // namespace sensors
} // namespace hardware
} // namespace android
#endif // ANDROID_HARDWARE_SENSORS_V2_1_EVENTMESSAGEQUEUEWRAPPER_H