From 377856d1bec154670ef1f703bb9fd7a45e92d906 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Fri, 1 Nov 2019 16:34:30 -0700 Subject: [PATCH] Fix accidental implicit fallthroughs -Wimplicit-fallthrough was printing warnings for these, they look like real errors. Fix them and re-enable the error. Test: treehugger Change-Id: I818e18a995760f17b85b4c72ee577e531fa2a601 --- modules/sensors/dynamic_sensor/Android.bp | 2 -- modules/sensors/dynamic_sensor/HidRawSensor.cpp | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/modules/sensors/dynamic_sensor/Android.bp b/modules/sensors/dynamic_sensor/Android.bp index 489cdf4c..214d97cf 100644 --- a/modules/sensors/dynamic_sensor/Android.bp +++ b/modules/sensors/dynamic_sensor/Android.bp @@ -22,8 +22,6 @@ cc_defaults { "-Wall", "-Werror", "-Wextra", - // Allow implicit fallthroughs in HidRawSensor.cpp until they are fixed. - "-Wno-error=implicit-fallthrough", ], export_include_dirs: ["."], diff --git a/modules/sensors/dynamic_sensor/HidRawSensor.cpp b/modules/sensors/dynamic_sensor/HidRawSensor.cpp index ae6ef473..46684128 100644 --- a/modules/sensors/dynamic_sensor/HidRawSensor.cpp +++ b/modules/sensors/dynamic_sensor/HidRawSensor.cpp @@ -676,6 +676,7 @@ bool HidRawSensor::detectAndroidCustomSensor(const std::string &description) { mFeatureInfo.type = SENSOR_TYPE_AMBIENT_TEMPERATURE; mFeatureInfo.typeString = SENSOR_STRING_TYPE_AMBIENT_TEMPERATURE; typeParsed = true; + break; case SENSOR_TYPE_LIGHT: mFeatureInfo.type = SENSOR_TYPE_LIGHT; mFeatureInfo.typeString = SENSOR_STRING_TYPE_LIGHT; @@ -917,12 +918,14 @@ int HidRawSensor::batch(int64_t samplingPeriod, int64_t batchingPeriod) { periodMs = std::min(periodMs, static_cast(UINT16_MAX)); buffer[mReportIntervalOffset] = periodMs & 0xFF; buffer[mReportIntervalOffset + 1] = (periodMs >> 8) & 0xFF; + break; case sizeof(uint32_t): periodMs = std::min(periodMs, static_cast(UINT32_MAX)); buffer[mReportIntervalOffset] = periodMs & 0xFF; buffer[mReportIntervalOffset + 1] = (periodMs >> 8) & 0xFF; buffer[mReportIntervalOffset + 2] = (periodMs >> 16) & 0xFF; buffer[mReportIntervalOffset + 3] = (periodMs >> 24) & 0xFF; + break; } ok = device->setFeature(id, buffer); }