Simple wrappers that associate a control delegate
or set of control options with a corresponding
metadata tag.
BUG: 30140438
TEST: unit tests pass
Change-Id: Ib4d769f4a860d661128c8af47d317937d96feb96
Part of moving towards composition over inheritance.
Ignored: Requests to set are ignored.
NoEffect: Tracks a value but does nothing.
V4L2: Goes through a V4l2 device.
TEST: unit tests pass
BUG: 30140438
Change-Id: I9ca636556f4a6ddfe4b8ddfbd042371ed56343b9
These interfaces will be used to increase composition
and decrease inheritance in the metadata controls.
ControlDelegates are responsible for getting/setting values,
While ControlOptions are responsible for validating values
(breaking these two apart allows, for example, unused sliders
and unused enums to share the same ControlDelegate, but have different
options, with minimal code duplication).
StateDelegates are for read-only values that may change.
ControlDelegate inherits from this because it will allow
the State interface to be passed around, while one owner
maintains control of updating it behind the scenes.
BUG: 30140438
TEST: unit tests pass. Interfaces only so no new tests
Change-Id: I8042c1ccf97655558f45a1f8411e3a4a36de7506
Scaling converters scale, as the name implies.
The two wrapping converters, map & ranged sanitize
data for sending to V4L2, either converting a value
to be within a map, or within a range, respectively.
(These are intended for use with V4L2 int menu and int
controls, respectively).
TEST: Unit tests pass
BUG: 30140438
Change-Id: Ie7d86118e00c0b59e6457fc16449228706098952
Using composition for conversion will allow more
code to be shared by different V4L2 controls.
BUG: 30140438
TEST: unit tests pass
Change-Id: I467efc72d71b9593d2476a61615fa44f7a975649
The normal G_CTRL and S_CTRL ioctls are only intended
for the basic user control interface. For the HAL,
we want access to quite a few extended controls as well.
BUG: 30140438
Change-Id: I750e9b1dc5e9e18cf5ad25daf1e1c1e34e756169
Was previously running the clang-format command incorrectly;
was not using the .clang-format file, and so was formatting
in some different style.
Change-Id: I09e81b919d1e6d40a56eb4f3f519aaed281a0c86
TEST: unit tests pass
Add all current enum controls and their mappings
to the metadata constructor.
BUG: https://b/30140438
Change-Id: Ie4a5b89d8bc4bc75531425e5fc8bfb4a181b0a03
Some V4L2 controls are simple enum menus, and are directly
analagous to metadata controls. The new V4L2EnumControl class
is a generalized converter between the two.
BUG: https://b/30140438, https://b/29394024
TEST: unit tests pass
Change-Id: I9f8bed200e21cb7e3f3336608fe210f094b7aa42
Common static functions for manipulating metadata moved
from patial_metadata_interface to metadata_common.h
Common static functions for comparing equivalence with
metadata for tests moved to test_common.h
BUG: 30140438
TEST: Unit tests pass
Change-Id: I4310b4ff05bdd68f7f92f533028989914d0f4c82
Query formats, sizes, and frame rates.
BUG: https://b/29394024, https://b/30605346
TEST: Test java program shows a bunch of formats & rates,
can take pictures in different sizes now.
Change-Id: I203fd8f200dda79cf6946c58f130548b05269fbd
Ignored controls are optioned controls where the value
set by the user is tracked, but doesn't actually matter.
BUG: 30140438
Change-Id: I45819c3c6c855922418f76fd34309a44660fc3f0
TEST: unit tests pass
An optioned control is a control with a fixed list of
accepted options.
BUG: 30140438
Change-Id: Ibf82840629cb23f9082889058f7d11350beffb2a
TEST: unit tests pass
Partial implementation of tagged_partial_metadata. A control
is a value that can be changed.
Implements supported/get/set of parent class, abstracting
into simpler supported/get/set methods for children to implement.
BUG: 30140438
Change-Id: Iaba6fc2f54f6a8786c5ca379972ee1da9604c7a3
TEST: unit tests pass
Fixed properties are, as the name implies, just a single
value that doesn't change.
BUG: 30140438
Change-Id: I2d8d10f16a3665532946a8abca17d01f5c022fdc
TEST: unit tests pass
Partial implementation of tagged partial metadata.
Has a single static tag and implements the populate/supports/set
methods. Adds Value() virtual method that must be overriden.
BUG: 30140438
Change-Id: I2b4927e0d3550235106593cc1ba501c95ba9d2c4
Partial implementation of partial_metadata_interface.
Implements a fixed set of tags at constructor time.
BUG: 30140438
Change-Id: Ie5bde7abf822191ee643d663705f39ba12147ba3
Ownership is much more clear than with the various double
raw metadata pointers.
BUG: 30140438
TEST: unit tests pass
Change-Id: Ib0de3bb4b9e6dc30594230e46f40ffaea06df51d
v4l2_metadata and metadata/metadata. The previous design did not work
as intended for testing (it incorrectly assumed that a constructor
would call an overridden method of a child class), plus this way
makes more sense.
BUG: 30140438
Change-Id: I1293535932fed6daed766682421b1215739e17dd
TEST: Unit tests pass
Breaks metadata down into distinct pieces (to be added later).
BUG: 29330282
TEST: unit tests pass
Change-Id: I7156e420e7cdb14b5c3155006ecefd8ff2a49500
Fixes file name style and include guard style, before
even more and more files get added.
BUG: 30224839
Change-Id: Ie5ebcf14672c7e9d3faae86b88d4f62b516ae00d
TEST: test program that takes a picture still works.
Also updates naming of max streams to be in line with what they
technically are, not what they usually are (i.e. a non-stalling
processed stream is usually YUV, but not necessarily).
BUG: 30140438
Change-Id: Idb78c466a41c9c0e5957200fc7c8afc0cfdb88a6
Switch to a factory model so that initialization can
fail when the gralloc module can't be found or isn't supported.
BUG: 30140438
Change-Id: I6e0a62a207797aef96c532cff7632c1a4da8818f
This reverts commit a147f83c8c58f078fad95f99a19ac4441bcb5914.
Was reverted originally due to an issue in a parent CL. Now
that has been fixed, and this CL can be reinstated.
Change-Id: Ie281b6cc80705d8843572f21edde2398c892e35b
This reverts commit a485a7e60db95039df5de82119e47878372550ac
(which reverts the original version of this CL).
Fixed build errors - put reinterpret_cast around delete [] in
V4L2Gralloc destructor, and fixed missing parens around another
reinterpret cast.
BUG: 29335262
Change-Id: Iaa5a71afef8850ba499cb1a7159a831da4f7014a
This abstraction will both clean up the code in V4L2Camera.cpp, and make it
easier to implement tests in the future (by mocking over the class).
This CL only adds the class and implementation, it does not yet replace
the logic in V4L2Camera.cpp.
Also gates building the module, to prevent checkbuilds without the
proper v4l2 kernel headers from trying to build it.
BUG: 30140438
Change-Id: I4e5feee30fdf896b1f71f0df492ca313f5581e78
This reverts commit 00debb6c12c7d7cb70307c4d48ea92a298e44852.
Shamu checkbuild fails because it doesn't have extended query control in the header.
Change-Id: I004ebb70f617cb5f440c7dc076ebbce81fec2136
* Puts in the basics for enqueuing and dequeing buffers from
V4L2.
*Also adds very basic result metadata (spoofed timestamp)
so that the image is returned cleanly.
BUG: 29335262
TEST: A sample Java program is able to take a 640x480 picture, both
JPEG and and YUV (requires ag/1217869).
Change-Id: I853dcc2b5430ea2822006269f57bdf44c1eaa11a
The helper class deals with choosing the correct locking/unlocking,
and conversion to correct yuv buffer format.
BUG: 29335262
TEST: With some follow up CLs to implement data capture, manually
tested by adjusting gralloc implementation:
* Jpeg
* YUV
* Packed planar
* Packed semiplanar
* cstep 4 semiplanar
* packed planar with extra y padding
* packed planar with extra y & c padding
* packed semiplanar with extra y & c padding
Did not test gralloc with less padding than camera, as the test
camera being used has 0 padding to begin with.
Change-Id: Icc5e9b8955cf6e983072b269fd60aefbfd79f883
This abstraction will both clean up the code in V4L2Camera.cpp, and make it
easier to implement tests in the future (by mocking over the class).
This CL only adds the class and implementation, it does not yet replace
the logic in V4L2Camera.cpp.
BUG: 30140438
Change-Id: I2ebf2e615eedaed6294ddb52d3b3c4c1bd0a0460
Set up the camera HAL according to the request streams.
Upgrades this flow from the 3.0 to 3.4 version, where
streams are not registered with buffers, and have a few
additional fields.
BUG: http://b/29921457, http://b/29221641
Change-Id: I36f67da374e6919caad6f202f31b72b0de2bb3bf
Repaces them with just doing the error check,
and a loop for available characteristic keys.
BUG: 29872714
Change-Id: Idc48c5c51ef081dc4a2d380e2d23ee17347e3115
As part of this, refactored characteristic initialization into its own
function so it can be used by both templates and static info.
BUG: 29221795
Change-Id: I88bb2e6a96256e3641c7c5d387769880b260535f
Fills in initial values for all required static info
fields for LIMITED devices. Currently fakes entries
that will eventually be queried from the device (open
bug https://b/29394024).
BUG: https://b/29214526, https://b/29221641
Change-Id: I6b4bfa172c882df22159da63378902cea7cc76fd
Since V4L2CameraHAL now populates its list of cameras,
also added a necessary piece of metadata that was
causing cameraservice to crash.
BUG: 29160300
TEST: Ran on rpi3. HAL finds dev/video* nodes. When a
sym link (/dev/video5 -> /dev/video0) was added, the HAL
correctly did not add a 3rd device.
Change-Id: I95656ac9c062b193c12712b1c73e888bf1f1a961
