tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

RefBase: make Renamer destructor virtual

Browse source 
This patch makes the Renamer class destructor virtual and fixes
the incorrect constructor initialization list ordering.

These issues and related compiler warnings have been suppressed
by the build system which uses the gcc –isystem command
line option, unless a project explicitly adds the include the path
system/core/include to Android.mk and uses the templates.

Change-Id: Iff76a655eb8bd547adfe994c7315a005e98aed41
Signed-off-by: Ukri Niemimuukko <ukri.niemimuukko@intel.com>
Signed-off-by: Mingwei Shi <mingwei.shi@intel.com>
Signed-off-by: Yong Yao <yong.yao@intel.com>
This commit is contained in:
Ukri Niemimuukko 2014-04-29 06:25:28 +08:00 committed by Yong Yao
parent 8022ce1e87
commit 00e56a248d
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
include/utils/RefBase.h
View file

@ -484,7 +484,8 @@ public:
TYPE::renameRefId(d[i].get(), &s[i], &d[i]);
}
public:
Renamer(sp<TYPE>* d, sp<TYPE> const* s) : s(s), d(d) { }
Renamer(sp<TYPE>* d, sp<TYPE> const* s) : d(d), s(s) { }
virtual ~Renamer() { }
};
memmove(d, s, n*sizeof(sp<TYPE>));
@ -503,7 +504,8 @@ public:
TYPE::renameRefId(d[i].get_refs(), &s[i], &d[i]);
}
public:
Renamer(wp<TYPE>* d, wp<TYPE> const* s) : s(s), d(d) { }
Renamer(wp<TYPE>* d, wp<TYPE> const* s) : d(d), s(s) { }
virtual ~Renamer() { }
};
memmove(d, s, n*sizeof(wp<TYPE>));