tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

use epoll_create1

Browse source 
epoll_create leaks file descriptors. Use epoll_create1(EPOLL_CLOEXEC)
instead.

Bug: 120983106
Test: compiles and boots
Change-Id: I7c135ee22aee61cc7895486fda904b1790c093d1
This commit is contained in:
Nick Kralevich 2018-12-17 09:35:12 -08:00
parent 8fe0eb46c0
commit 0a8b4d1a8b
1 changed files with 1 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
libutils/Looper.cpp
View file

@ -51,9 +51,6 @@ int SimpleLooperCallback::handleEvent(int fd, int events, void* data) {
// --- Looper ---
// Hint for number of file descriptors to be associated with the epoll instance.
static const int EPOLL_SIZE_HINT = 8;
// Maximum number of file descriptors for which to retrieve poll events each iteration.
static const int EPOLL_MAX_EVENTS = 16;
@ -139,7 +136,7 @@ void Looper::rebuildEpollLocked() {
}
// Allocate the new epoll instance and register the wake pipe.
mEpollFd.reset(epoll_create(EPOLL_SIZE_HINT));
mEpollFd.reset(epoll_create1(EPOLL_CLOEXEC));
LOG_ALWAYS_FATAL_IF(mEpollFd < 0, "Could not create epoll instance: %s", strerror(errno));
struct epoll_event eventItem;