From 16649d22ca639b14bd7fd831cfa8ce6855ad1d70 Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Wed, 9 Jan 2019 07:49:21 -0800 Subject: [PATCH] llkd: do not call sync() sync() will never return if the io subsystem is locked up, drop it. Test: llkd_unit_test Bug: 122263600 Change-Id: Ib378124415ce94da987d73391b027dc10317dbe9 --- llkd/libllkd.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/llkd/libllkd.cpp b/llkd/libllkd.cpp index 3c295b506..b26ad4df6 100644 --- a/llkd/libllkd.cpp +++ b/llkd/libllkd.cpp @@ -525,7 +525,7 @@ void llkPanicKernel(bool dump, pid_t tid, const char* state, const std::string& // NOTREACHED return; } - ::sync(); + // Wish could ::sync() here, if storage is locked up, we will not continue. if (dump) { // Show all locks that are held android::base::WriteStringToFd("d", sysrqTriggerFd);