tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fs_mgr: fix potential uses of nullptr

Browse source 
Clang's static analyzer flagged the following potential null pointer
dereferences. Looks like a transitive caller of this function has

```
if (change) *change = foo;
```

...and no nullness checks between that and these unconditional
assignments to `*change`.

> system/core/fs_mgr/fs_mgr_overlayfs.cpp:1100:13: warning: Dereference
of null pointer (loaded from variable 'change')
[clang-analyzer-core.NullDereference] >
system/core/fs_mgr/fs_mgr_overlayfs.cpp:1167:17: warning: Dereference of
null pointer (loaded from variable 'change')
[clang-analyzer-core.NullDereference]

Bug: None
Test: TreeHugger
Change-Id: I656e3b0f56b18ec3ca3d1db773feb81adf163122
This commit is contained in:
George Burgess IV 2020-11-09 22:15:16 -08:00
parent 2abdb1eb5b
commit 1c8d814cea
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs_mgr/fs_mgr_overlayfs.cpp
View file

@ -1045,7 +1045,7 @@ static bool CreateDynamicScratch(std::string* scratch_device, bool* partition_ex
static bool CreateScratchOnData(std::string* scratch_device, bool* partition_exists, bool* change) {
*partition_exists = false;
*change = false;
if (change) *change = false;
auto images = IImageManager::Open("remount", 10s);
if (!images) {
@ -1065,7 +1065,7 @@ static bool CreateScratchOnData(std::string* scratch_device, bool* partition_exi
return false;
}
*change = true;
if (change) *change = true;
// Note: calling RemoveDisabledImages here ensures that we do not race with
// clean_scratch_files and accidentally try to map an image that will be