From 89169a372fd67862398f486bce5aea711b9274d3 Mon Sep 17 00:00:00 2001
From: Joshua Duong <joshuaduong@google.com>
Date: Fri, 17 Jul 2020 14:14:00 -0700
Subject: [PATCH] [clang-tidy] Add bugprone-inaccurate-erase check.

This will hopefully identify misusage of the erase-remove idiom.

Test: "foo.erase(std::remove_if(...))" produces error.
Test: mmm system/core/adb -j (no warnings)
Change-Id: Iba0a6fc40cb6e7c65a7a3926d915874dc89a60c6
---
 adb/Android.bp | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/adb/Android.bp b/adb/Android.bp
index 2fc205fae..87ac54d06 100644
--- a/adb/Android.bp
+++ b/adb/Android.bp
@@ -12,6 +12,11 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+tidy_errors = [
+    "-*",
+    "bugprone-inaccurate-erase",
+]
+
 cc_defaults {
     name: "adb_defaults",
 
@@ -73,6 +78,10 @@ cc_defaults {
             ],
         },
     },
+
+    tidy: true,
+    tidy_checks: tidy_errors,
+    tidy_checks_as_errors: tidy_errors,
 }
 
 cc_defaults {