diff --git a/init/apex_init_util.cpp b/init/apex_init_util.cpp index d88da390e..6d17f36e2 100644 --- a/init/apex_init_util.cpp +++ b/init/apex_init_util.cpp @@ -82,7 +82,7 @@ static Result> CollectRcScriptsFromApex( return configs; } -static std::set GetApexListFrom(const std::string& apex_dir) { +std::set GetApexListFrom(const std::string& apex_dir) { std::set apex_list; auto dirp = std::unique_ptr(opendir(apex_dir.c_str()), closedir); if (!dirp) { diff --git a/init/apex_init_util.h b/init/apex_init_util.h index e55b3c0c9..75dfee1ae 100644 --- a/init/apex_init_util.h +++ b/init/apex_init_util.h @@ -16,6 +16,7 @@ #pragma once +#include #include #include @@ -24,6 +25,9 @@ namespace android { namespace init { +// Scans apex_dir (/apex) to get the list of active APEXes. +std::set GetApexListFrom(const std::string& apex_dir); + // Parse all RC scripts for a given apex. Result ParseRcScriptsFromApex(const std::string& apex_name); diff --git a/init/builtins.cpp b/init/builtins.cpp index 2ced66d11..a5b762cbb 100644 --- a/init/builtins.cpp +++ b/init/builtins.cpp @@ -1269,26 +1269,15 @@ static Result do_update_linker_config(const BuiltinArguments&) { /* * Creates a directory under /data/misc/apexdata/ for each APEX. */ -static Result create_apex_data_dirs() { - auto dirp = std::unique_ptr(opendir("/apex"), closedir); - if (!dirp) { - return ErrnoError() << "Unable to open apex directory"; - } - struct dirent* entry; - while ((entry = readdir(dirp.get())) != nullptr) { - if (entry->d_type != DT_DIR) continue; - - const char* name = entry->d_name; - // skip any starting with "." - if (name[0] == '.') continue; - - if (strchr(name, '@') != nullptr) continue; - - auto path = "/data/misc/apexdata/" + std::string(name); +static void create_apex_data_dirs() { + for (const auto& name : GetApexListFrom("/apex")) { + auto path = "/data/misc/apexdata/" + name; auto options = MkdirOptions{path, 0771, AID_ROOT, AID_SYSTEM, FscryptAction::kNone, "ref"}; - make_dir_with_options(options); + auto result = make_dir_with_options(options); + if (!result.ok()) { + LOG(ERROR) << result.error(); + } } - return {}; } static Result do_perform_apex_config(const BuiltinArguments& args) { @@ -1301,10 +1290,7 @@ static Result do_perform_apex_config(const BuiltinArguments& args) { } if (!bootstrap) { - auto create_dirs = create_apex_data_dirs(); - if (!create_dirs.ok()) { - return create_dirs.error(); - } + create_apex_data_dirs(); } auto parse_result = ParseRcScriptsFromAllApexes(bootstrap);