tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't include android-base/macros.h from android-base/unique_fd.h

Browse source 
This prevents a ton of macro collisions when libfoo includes libbinder
includes unique_fd.h.

Bug: 27804373
Change-Id: Ide834afb1052b32e86fad3fcba10cff3dafeb899
This commit is contained in:
Christopher Wiley 2016-04-19 14:09:41 -07:00
parent 603df0e875
commit 2a7b86337f
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
base/include/android-base/unique_fd.h
View file

@ -19,7 +19,10 @@
#include <unistd.h>
#include <android-base/macros.h>
// DO NOT INCLUDE OTHER LIBBASE HEADERS!
// This file gets used in libbinder, and libbinder is used everywhere.
// Including other headers from libbase frequently results in inclusion of
// android-base/macros.h, which causes macro collisions.
// Container for a file descriptor that automatically closes the descriptor as
// it goes out of scope.
@ -75,7 +78,8 @@ class unique_fd final {
private:
int value_;
DISALLOW_COPY_AND_ASSIGN(unique_fd);
unique_fd(const unique_fd&);
void operator=(const unique_fd&);
};
} // namespace base