From eab48ce0d5b0eab438e86b500288ad44e267c5df Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Tue, 10 Apr 2018 14:31:29 -0700 Subject: [PATCH] Remove extra semicolon at end of namespace Upcoming clang update to r328903 adds a new warning: warning: extra ';' outside of a function is incompatible with C++98 [-Wc++98-compat-extra-semi] which is included in -Weverything. We can just delete the extra semicolon (even though we use gnu99), and save the extra byte. Test: Build Change-Id: I49b6e6af483e011632e6a34c0663c93e5c385aa6 --- libutils/include/utils/Errors.h | 4 ++-- libutils/include/utils/LightRefBase.h | 2 +- libutils/include/utils/RefBase.h | 2 +- libutils/include/utils/String16.h | 2 +- libutils/include/utils/StrongPointer.h | 2 +- libutils/include/utils/TypeHelpers.h | 2 +- libutils/include/utils/misc.h | 2 +- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libutils/include/utils/Errors.h b/libutils/include/utils/Errors.h index 16e1fa2c2..7093a206a 100644 --- a/libutils/include/utils/Errors.h +++ b/libutils/include/utils/Errors.h @@ -81,8 +81,8 @@ enum { # define NO_ERROR 0L #endif -}; // namespace android - +} // namespace android + // --------------------------------------------------------------------------- #endif // ANDROID_ERRORS_H diff --git a/libutils/include/utils/LightRefBase.h b/libutils/include/utils/LightRefBase.h index 65257edb9..e488e602d 100644 --- a/libutils/include/utils/LightRefBase.h +++ b/libutils/include/utils/LightRefBase.h @@ -69,4 +69,4 @@ public: virtual ~VirtualLightRefBase() = default; }; -}; // namespace android +} // namespace android diff --git a/libutils/include/utils/RefBase.h b/libutils/include/utils/RefBase.h index 223b6669d..e817ee4d6 100644 --- a/libutils/include/utils/RefBase.h +++ b/libutils/include/utils/RefBase.h @@ -683,7 +683,7 @@ void move_backward_type(wp* d, wp const* s, size_t n) { ReferenceMover::move_references(d, s, n); } -}; // namespace android +} // namespace android // --------------------------------------------------------------------------- diff --git a/libutils/include/utils/String16.h b/libutils/include/utils/String16.h index 5f0ce0691..afbc2edc5 100644 --- a/libutils/include/utils/String16.h +++ b/libutils/include/utils/String16.h @@ -243,7 +243,7 @@ inline String16::operator const char16_t*() const return mString; } -}; // namespace android +} // namespace android // --------------------------------------------------------------------------- diff --git a/libutils/include/utils/StrongPointer.h b/libutils/include/utils/StrongPointer.h index ae6d9c82e..9cd278f1f 100644 --- a/libutils/include/utils/StrongPointer.h +++ b/libutils/include/utils/StrongPointer.h @@ -239,7 +239,7 @@ void sp::set_pointer(T* ptr) { m_ptr = ptr; } -}; // namespace android +} // namespace android // --------------------------------------------------------------------------- diff --git a/libutils/include/utils/TypeHelpers.h b/libutils/include/utils/TypeHelpers.h index 28fbca508..1554f52ee 100644 --- a/libutils/include/utils/TypeHelpers.h +++ b/libutils/include/utils/TypeHelpers.h @@ -329,7 +329,7 @@ template inline hash_t hash_type(T* const & value) { return hash_type(uintptr_t(value)); } -}; // namespace android +} // namespace android // --------------------------------------------------------------------------- diff --git a/libutils/include/utils/misc.h b/libutils/include/utils/misc.h index af5ea0241..32615b3e5 100644 --- a/libutils/include/utils/misc.h +++ b/libutils/include/utils/misc.h @@ -35,6 +35,6 @@ typedef void (*sysprop_change_callback)(void); void add_sysprop_change_callback(sysprop_change_callback cb, int priority); void report_sysprop_change(); -}; // namespace android +} // namespace android #endif // _LIBS_UTILS_MISC_H