From 42fb2821ccdb8461239cab4e2203bade07b65ce4 Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Tue, 5 Jun 2018 07:33:35 -0700 Subject: [PATCH] liblog: expect content only if ro.logd.kernel is enabled On svelte devices, CTS test liblog#android_logger_get_ fails on the missing kernel buffer because it is not enabled to save space. Test: gTest liblog_unit_tests Bug: 109669791 Change-Id: Iaf46fe9713d3462a56885515a67db640544345ab --- liblog/tests/log_read_test.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/liblog/tests/log_read_test.cpp b/liblog/tests/log_read_test.cpp index 444a5ac64..443c3ea58 100644 --- a/liblog/tests/log_read_test.cpp +++ b/liblog/tests/log_read_test.cpp @@ -27,6 +27,7 @@ // Test the APIs in this standalone include file #include // Do not use anything in log/log_time.h despite side effects of the above. +#include TEST(liblog, __android_log_write__android_logger_list_read) { #ifdef __ANDROID__ @@ -105,7 +106,10 @@ TEST(liblog, android_logger_get_) { // framework (b/68266385). EXPECT_LE( // boolean 1 or 0 depending on expected content or empty !!((strcmp("crash", name) != 0) && - ((strcmp("kernel", name) != 0) || __android_log_is_debuggable()) && + ((strcmp("kernel", name) != 0) || + __android_logger_property_get_bool( + "ro.logd.kernel", BOOL_DEFAULT_TRUE | BOOL_DEFAULT_FLAG_ENG | + BOOL_DEFAULT_FLAG_SVELTE)) && (strcmp("stats", name) != 0)), android_logger_get_log_readable_size(logger)); } else {