tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

subcontext: Change a std::string argument into std::string_view

Browse source 
This change prevents that a later CL will trigger the following warning:

parameter 'test_context' is passed by value and only copied once; consider
moving it to avoid unnecessary copies

Change-Id: If5837ee6438efdf194781de041779c1089897789
Signed-off-by: Bart Van Assche <bvanassche@google.com>
This commit is contained in:
Bart Van Assche 2022-10-26 09:31:35 -07:00
parent 5e524e28ee
commit 462ea55095
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
init/subcontext.h
View file

@ -36,8 +36,10 @@ static constexpr const char kTestContext[] = "test-test-test";
class Subcontext {
public:
Subcontext(std::vector<std::string> path_prefixes, std::string context, bool host = false)
: path_prefixes_(std::move(path_prefixes)), context_(std::move(context)), pid_(0) {
Subcontext(std::vector<std::string> path_prefixes, std::string_view context, bool host = false)
: path_prefixes_(std::move(path_prefixes)),
context_(context.begin(), context.end()),
pid_(0) {
if (!host) {
Fork();
}