tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove PauseTiming/ResumeTiming calls.

Browse source 
These calls can only be used after the call to state.KeepRunning(),
which handles the start/stop itself.

Bug: 68170209

Test: Ran the benchmark and got reasonable results.
Change-Id: Ie12eb3a983f6fe60c85d6dfc90957eedc16b5526
This commit is contained in:
Christopher Ferris 2017-10-24 12:39:10 -07:00
parent cada8d74d0
commit 5169c167c5
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
libbacktrace/backtrace_benchmarks.cpp
View file

@ -70,7 +70,6 @@ static bool CountMaps(pid_t pid, size_t* num_maps) {
}
static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t, bool)) {
state.PauseTiming();
// Create a remote process so that the map data is exactly the same.
// Also, so that we can create a set number of maps.
pid_t pid;
@ -132,7 +131,6 @@ static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t,
return;
}
state.ResumeTiming();
while (state.KeepRunning()) {
for (size_t i = 0; i < static_cast<size_t>(state.range(0)); i++) {
BacktraceMap* map = map_func(pid, false);
@ -143,7 +141,6 @@ static void CreateMap(benchmark::State& state, BacktraceMap* (*map_func)(pid_t,
delete map;
}
}
state.PauseTiming();
kill(pid, SIGKILL);
waitpid(pid, nullptr, 0);