tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

storaged: change log level for health HAL calls

Browse source 
Devices that does not implement getDiskStats and getStorageInfo
returns NOT_SUPPORTED as a value. Do not log to error stream in
this case.
Fixes: 114475810
Test: boots

Change-Id: I95e9ebe23b4dee451cb8f6e8dc0b60a224006600
This commit is contained in:
Yifan Hong 2018-09-13 09:39:41 -07:00
parent abf8ff7e81
commit 539ee58b41
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
storaged/storaged_diskstats.cpp
View file

@ -129,6 +129,10 @@ bool get_disk_stats_from_health_hal(const sp<IHealth>& service, struct disk_stat
bool success = false;
auto ret = service->getDiskStats([&success, stats](auto result, const auto& halStats) {
if (result == Result::NOT_SUPPORTED) {
LOG_TO(SYSTEM, DEBUG) << "getDiskStats is not supported on health HAL.";
return;
}
if (result != Result::SUCCESS || halStats.size() == 0) {
LOG_TO(SYSTEM, ERROR) << "getDiskStats failed with result " << toString(result)
<< " and size " << halStats.size();

8
storaged/storaged_info.cpp
View file

@ -370,8 +370,12 @@ void ufs_info_t::report()
void health_storage_info_t::report() {
auto ret = mHealth->getStorageInfo([this](auto result, const auto& halInfos) {
if (result == Result::NOT_SUPPORTED) {
LOG_TO(SYSTEM, DEBUG) << "getStorageInfo is not supported on health HAL.";
return;
}
if (result != Result::SUCCESS || halInfos.size() == 0) {
LOG_TO(SYSTEM, DEBUG) << "getStorageInfo failed with result " << toString(result)
LOG_TO(SYSTEM, ERROR) << "getStorageInfo failed with result " << toString(result)
<< " and size " << halInfos.size();
return;
}
@ -380,7 +384,7 @@ void health_storage_info_t::report() {
});
if (!ret.isOk()) {
LOG_TO(SYSTEM, DEBUG) << "getStorageInfo failed with " << ret.description();
LOG_TO(SYSTEM, ERROR) << "getStorageInfo failed with " << ret.description();
}
}