From fd7ffb1089cf3ce43a33a157ed748641adb7b95b Mon Sep 17 00:00:00 2001 From: Johan Redestig Date: Mon, 29 Apr 2013 09:11:57 +0200 Subject: [PATCH] Log an error if property pool is exhausted Failing to set properties due to an exhausted pool leads to difficult to debug problems. This change adds an error log to make the situation a bit easier to handle. Change-Id: Icc1d97a80882fb23e74428a0195f1d28dba68fa8 --- init/property_service.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/init/property_service.c b/init/property_service.c index 61dd86fdc..48488be9c 100755 --- a/init/property_service.c +++ b/init/property_service.c @@ -353,7 +353,11 @@ int property_set(const char *name, const char *value) __futex_wake(&pa->serial, INT32_MAX); } else { pa = __system_property_area__; - if(pa->count == PA_COUNT_MAX) return -1; + if(pa->count == PA_COUNT_MAX) { + ERROR("Failed to set '%s'='%s', property pool is exhausted at %d entries", + name, value, PA_COUNT_MAX); + return -1; + } pi = pa_info_array + pa->count; pi->serial = (valuelen << 24);