diff --git a/liblog/include/android/log.h b/liblog/include/android/log.h index 2e6210e29..7290789af 100644 --- a/liblog/include/android/log.h +++ b/liblog/include/android/log.h @@ -124,8 +124,6 @@ int __android_log_vprint(int prio, const char* tag, const char* fmt, va_list ap) void __android_log_assert(const char* cond, const char* tag, const char* fmt, ...) __attribute__((__noreturn__)) __attribute__((__format__(printf, 3, 4))); -#ifndef log_id_t_defined -#define log_id_t_defined /** * Identifies a specific log buffer for __android_log_buf_write() * and __android_log_buf_print(). @@ -152,7 +150,6 @@ typedef enum log_id { LOG_ID_MAX } log_id_t; -#endif /** * Writes the constant string `text` to the log buffer `id`, diff --git a/liblog/include/log/log_id.h b/liblog/include/log/log_id.h index 4c6d809fe..c8fafe760 100644 --- a/liblog/include/log/log_id.h +++ b/liblog/include/log/log_id.h @@ -16,30 +16,12 @@ #pragma once +#include + #ifdef __cplusplus extern "C" { #endif -#ifndef log_id_t_defined -#define log_id_t_defined -typedef enum log_id { - LOG_ID_MIN = 0, - - LOG_ID_MAIN = 0, - LOG_ID_RADIO = 1, - LOG_ID_EVENTS = 2, - LOG_ID_SYSTEM = 3, - LOG_ID_CRASH = 4, - LOG_ID_STATS = 5, - LOG_ID_SECURITY = 6, - LOG_ID_KERNEL = 7, /* place last, third-parties can not use it */ - - LOG_ID_MAX -} log_id_t; -#endif -#define sizeof_log_id_t sizeof(typeof_log_id_t) -#define typeof_log_id_t unsigned char - /* * Send a simple string to the log. */ diff --git a/liblog/include/private/android_logger.h b/liblog/include/private/android_logger.h index d3cb571dc..d3b72bcee 100644 --- a/liblog/include/private/android_logger.h +++ b/liblog/include/private/android_logger.h @@ -47,7 +47,7 @@ typedef struct __attribute__((__packed__)) { /* Header Structure to logd, and second header for pstore */ typedef struct __attribute__((__packed__)) { - typeof_log_id_t id; + uint8_t id; uint16_t tid; log_time realtime; } android_log_header_t; diff --git a/logd/LogListener.cpp b/logd/LogListener.cpp index 443570fd3..ba610424f 100644 --- a/logd/LogListener.cpp +++ b/logd/LogListener.cpp @@ -41,8 +41,7 @@ bool LogListener::onDataAvailable(SocketClient* cli) { } // + 1 to ensure null terminator if MAX_PAYLOAD buffer is received - char buffer[sizeof_log_id_t + sizeof(uint16_t) + sizeof(log_time) + - LOGGER_ENTRY_MAX_PAYLOAD + 1]; + char buffer[sizeof(android_log_header_t) + LOGGER_ENTRY_MAX_PAYLOAD + 1]; struct iovec iov = { buffer, sizeof(buffer) - 1 }; alignas(4) char control[CMSG_SPACE(sizeof(struct ucred))];