tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libcutils: android_reboot command should be unsigned.

Browse source 
Hex literals have the type of the first type they fit in. The reboot
constants are large enough that that's `unsigned` rather than `int`.

Bug: http://b/76110968
Test: treehugger
Change-Id: Iac4fe61d1fe572297febf0b57e34d698942469f9
This commit is contained in:
Elliott Hughes 2019-04-02 09:19:46 -07:00
parent 43f29072a9
commit 66e5ae0f5a
2 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libcutils/android_reboot.cpp
View file

@ -23,12 +23,12 @@
#define TAG "android_reboot"
int android_reboot(int cmd, int /*flags*/, const char* arg) {
int android_reboot(unsigned cmd, int /*flags*/, const char* arg) {
int ret;
const char* restart_cmd = NULL;
char* prop_value;
switch (static_cast<unsigned>(cmd)) {
switch (cmd) {
case ANDROID_RB_RESTART: // deprecated
case ANDROID_RB_RESTART2:
restart_cmd = "reboot";

9
libcutils/include/cutils/android_reboot.h
View file

@ -14,8 +14,7 @@
* limitations under the License.
*/
#ifndef __CUTILS_ANDROID_REBOOT_H__
#define __CUTILS_ANDROID_REBOOT_H__
#pragma once
#include <sys/cdefs.h>
@ -36,10 +35,8 @@ __BEGIN_DECLS
/* Reboot or shutdown the system.
* This call uses ANDROID_RB_PROPERTY to request reboot to init process.
* Due to that, process calling this should have proper selinux permission
* to write to the property. Otherwise, the call will fail.
* to write to the property or the call will fail.
*/
int android_reboot(int cmd, int flags, const char *arg);
int android_reboot(unsigned cmd, int flags, const char* arg);
__END_DECLS
#endif /* __CUTILS_ANDROID_REBOOT_H__ */