diff --git a/adb/adb_trace.h b/adb/adb_trace.h index d50f94799..5206a99c6 100644 --- a/adb/adb_trace.h +++ b/adb/adb_trace.h @@ -41,7 +41,7 @@ enum AdbTrace { }; #define VLOG_IS_ON(TAG) \ - ((adb_trace_mask & (1 << TAG)) != 0) + ((adb_trace_mask & (1 << (TAG))) != 0) #define VLOG(TAG) \ if (LIKELY(!VLOG_IS_ON(TAG))) \ diff --git a/debuggerd/elf_utils.cpp b/debuggerd/elf_utils.cpp index 9959f2e1f..3d99cab31 100644 --- a/debuggerd/elf_utils.cpp +++ b/debuggerd/elf_utils.cpp @@ -29,7 +29,7 @@ #include "elf_utils.h" -#define NOTE_ALIGN(size) ((size + 3) & ~3) +#define NOTE_ALIGN(size) (((size) + 3) & ~3) template static bool get_build_id( diff --git a/debuggerd/test/host_signal_fixup.h b/debuggerd/test/host_signal_fixup.h index c7796efed..762bae5fb 100644 --- a/debuggerd/test/host_signal_fixup.h +++ b/debuggerd/test/host_signal_fixup.h @@ -57,7 +57,7 @@ #endif #if !defined(SI_DETHREAD) -#define SI_DETHREAD -7 +#define SI_DETHREAD (-7) #endif #endif diff --git a/libbacktrace/GetPss.cpp b/libbacktrace/GetPss.cpp index b4dc48d56..6d750ea81 100644 --- a/libbacktrace/GetPss.cpp +++ b/libbacktrace/GetPss.cpp @@ -24,7 +24,7 @@ // This is an extremely simplified version of libpagemap. -#define _BITS(x, offset, bits) (((x) >> offset) & ((1LL << (bits)) - 1)) +#define _BITS(x, offset, bits) (((x) >> (offset)) & ((1LL << (bits)) - 1)) #define PAGEMAP_PRESENT(x) (_BITS(x, 63, 1)) #define PAGEMAP_SWAPPED(x) (_BITS(x, 62, 1)) diff --git a/libbacktrace/backtrace_test.cpp b/libbacktrace/backtrace_test.cpp index df6c6c1fc..7066c798c 100644 --- a/libbacktrace/backtrace_test.cpp +++ b/libbacktrace/backtrace_test.cpp @@ -1420,7 +1420,7 @@ TEST(libbacktrace, unwind_thread_doesnt_exist) { #if defined(ENABLE_PSS_TESTS) #include "GetPss.h" -#define MAX_LEAK_BYTES 32*1024UL +#define MAX_LEAK_BYTES (32*1024UL) void CheckForLeak(pid_t pid, pid_t tid) { // Do a few runs to get the PSS stable.