From 37c9451349425652eb90434f61b8fe9a064957ba Mon Sep 17 00:00:00 2001 From: Mark Salyzyn Date: Tue, 4 Oct 2016 08:54:28 -0700 Subject: [PATCH] system/core: drop or replace log/logger.h debuggerd does not require log/logger.h, can use android/log.h In some cases, mark why log/logger.h was required. Test: Compile and boot smoke test Bug: 26552300 Bug: 31289077 Bug: 31456426 Change-Id: Ia34987e25a01d81971ec8d785415f732b8376c4f --- debuggerd/debuggerd.cpp | 6 ++---- debuggerd/signal_sender.cpp | 2 +- debuggerd/test/log_fake.cpp | 1 - debuggerd/tombstone.cpp | 1 - include/log/logprint.h | 2 +- include/private/android_logger.h | 2 +- liblog/logprint.c | 1 + 7 files changed, 6 insertions(+), 9 deletions(-) diff --git a/debuggerd/debuggerd.cpp b/debuggerd/debuggerd.cpp index 77c138f1e..a6d3d382e 100644 --- a/debuggerd/debuggerd.cpp +++ b/debuggerd/debuggerd.cpp @@ -19,6 +19,7 @@ #include #include #include +#include #include #include #include @@ -39,16 +40,13 @@ #include -#include - +#include #include #include #include #include #include -#include - #include #include diff --git a/debuggerd/signal_sender.cpp b/debuggerd/signal_sender.cpp index 4be7e6e2b..3adbef2db 100644 --- a/debuggerd/signal_sender.cpp +++ b/debuggerd/signal_sender.cpp @@ -24,7 +24,7 @@ #include #include -#include +#include #include "signal_sender.h" diff --git a/debuggerd/test/log_fake.cpp b/debuggerd/test/log_fake.cpp index ebf966faa..59910adab 100644 --- a/debuggerd/test/log_fake.cpp +++ b/debuggerd/test/log_fake.cpp @@ -21,7 +21,6 @@ #include #include -#include // Forward declarations. class Backtrace; diff --git a/debuggerd/tombstone.cpp b/debuggerd/tombstone.cpp index 5c7f02423..c87182e88 100644 --- a/debuggerd/tombstone.cpp +++ b/debuggerd/tombstone.cpp @@ -37,7 +37,6 @@ #include #include #include -#include #include #include diff --git a/include/log/logprint.h b/include/log/logprint.h index f70633d43..e5cd1de7a 100644 --- a/include/log/logprint.h +++ b/include/log/logprint.h @@ -21,7 +21,7 @@ #include #include -#include +#include /* struct logger_entry */ #ifdef __cplusplus extern "C" { diff --git a/include/private/android_logger.h b/include/private/android_logger.h index b6a20c305..d477ac1c4 100644 --- a/include/private/android_logger.h +++ b/include/private/android_logger.h @@ -25,7 +25,7 @@ #include #include -#include +#include /* log_time */ #define LOGGER_MAGIC 'l' diff --git a/liblog/logprint.c b/liblog/logprint.c index 2c4e619e4..f9b14bd6e 100644 --- a/liblog/logprint.c +++ b/liblog/logprint.c @@ -33,6 +33,7 @@ #include #include +#include #include #include "log_portability.h"