From d71f9e5fbbbc1b4a0f910c2c7606915bfeae68a4 Mon Sep 17 00:00:00 2001
From: Bart Van Assche <bvanassche@google.com>
Date: Fri, 20 Oct 2023 13:26:42 -0700
Subject: [PATCH] Reapply "Migrate the blkio controller to the v2 cgroup
 hierarchy"

This reverts commit c7a6fe684c7cea3fb9fba6dbb5cceeb698bfd318.
Repply the blkio controller migration because it was not responsible
for the test failures that led to the revert. See also the following bugs:
* https://b.corp.google.com/issues/260143932
  (v2/android-virtual-infra/test_mapping/presubmit-avd test failure)
* https://b.corp.google.com/issues/264620181
  (CtsInitTestCases.RebootTest#StopServicesSIGKILL failure)

The only change compared with the previous version is that the io
controller has been declared optional. This is necessary because some
devices have a kernel that does not support the io controller.

Bug: 213617178
Test: Cuttlefish and various phones
Change-Id: I490740e1c9ee4f7bb5bb7afba721a083f952c8f2
Signed-off-by: Bart Van Assche <bvanassche@google.com>
---
 libprocessgroup/profiles/cgroups.json       | 13 ++++++-------
 libprocessgroup/profiles/task_profiles.json | 12 ++++--------
 rootdir/init.rc                             | 20 --------------------
 3 files changed, 10 insertions(+), 35 deletions(-)

diff --git a/libprocessgroup/profiles/cgroups.json b/libprocessgroup/profiles/cgroups.json
index 3e4393df2..d013ec858 100644
--- a/libprocessgroup/profiles/cgroups.json
+++ b/libprocessgroup/profiles/cgroups.json
@@ -1,12 +1,5 @@
 {
   "Cgroups": [
-    {
-      "Controller": "blkio",
-      "Path": "/dev/blkio",
-      "Mode": "0775",
-      "UID": "system",
-      "GID": "system"
-    },
     {
       "Controller": "cpu",
       "Path": "/dev/cpuctl",
@@ -39,6 +32,12 @@
       {
         "Controller": "freezer",
         "Path": "."
+      },
+      {
+        "Controller": "io",
+        "Path": ".",
+        "NeedsActivation": true,
+        "Optional": true
       }
     ]
   }
diff --git a/libprocessgroup/profiles/task_profiles.json b/libprocessgroup/profiles/task_profiles.json
index 1fc66ba10..6314667ef 100644
--- a/libprocessgroup/profiles/task_profiles.json
+++ b/libprocessgroup/profiles/task_profiles.json
@@ -442,8 +442,7 @@
           "Name": "JoinCgroup",
           "Params":
           {
-            "Controller": "blkio",
-            "Path": "background"
+            "Controller": "io"
           }
         }
       ]
@@ -455,8 +454,7 @@
           "Name": "JoinCgroup",
           "Params":
           {
-            "Controller": "blkio",
-            "Path": ""
+            "Controller": "io"
           }
         }
       ]
@@ -468,8 +466,7 @@
           "Name": "JoinCgroup",
           "Params":
           {
-            "Controller": "blkio",
-            "Path": ""
+            "Controller": "io"
           }
         }
       ]
@@ -481,8 +478,7 @@
           "Name": "JoinCgroup",
           "Params":
           {
-            "Controller": "blkio",
-            "Path": ""
+            "Controller": "io"
           }
         }
       ]
diff --git a/rootdir/init.rc b/rootdir/init.rc
index 317f80908..fb6473666 100644
--- a/rootdir/init.rc
+++ b/rootdir/init.rc
@@ -219,26 +219,6 @@ on init
     write /dev/stune/nnapi-hal/schedtune.boost 1
     write /dev/stune/nnapi-hal/schedtune.prefer_idle 1
 
-    # Create blkio group and apply initial settings.
-    # This feature needs kernel to support it, and the
-    # device's init.rc must actually set the correct values.
-    mkdir /dev/blkio/background
-    chown system system /dev/blkio
-    chown system system /dev/blkio/background
-    chown system system /dev/blkio/tasks
-    chown system system /dev/blkio/background/tasks
-    chown system system /dev/blkio/cgroup.procs
-    chown system system /dev/blkio/background/cgroup.procs
-    chmod 0664 /dev/blkio/tasks
-    chmod 0664 /dev/blkio/background/tasks
-    chmod 0664 /dev/blkio/cgroup.procs
-    chmod 0664 /dev/blkio/background/cgroup.procs
-    write /dev/blkio/blkio.weight 1000
-    write /dev/blkio/background/blkio.weight 200
-    write /dev/blkio/background/blkio.bfq.weight 10
-    write /dev/blkio/blkio.group_idle 0
-    write /dev/blkio/background/blkio.group_idle 0
-
     restorecon_recursive /mnt
 
     mount configfs none /config nodev noexec nosuid