tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add NULL check to CallStack::toString

Browse source 
CallStack::toString() has a 0 default argument, which ends up getting
passed to strlen(), resulting in a crash.

Change-Id: If706aff8c400983670f49cdbb66e11191ac76e0e
This commit is contained in:
Marco Nelissen 2012-12-17 10:28:20 -08:00 committed by Alex Ray
parent 551fcf4fe3
commit 99ec303e45
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libs/utils/CallStack.cpp
View file

@ -118,7 +118,9 @@ String8 CallStack::toString(const char* prefix) const {
char line[MAX_BACKTRACE_LINE_LENGTH];
format_backtrace_line(i, &mStack[i], &symbols[i],
line, MAX_BACKTRACE_LINE_LENGTH);
str.append(prefix);
if (prefix) {
str.append(prefix);
}
str.append(line);
str.append("\n");
}