tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix off by one error.

Browse source 
Change-Id: I18a2d177f3212626b7091150f42dfe151e47570e
This commit is contained in:
Florian Mayer 2018-10-23 14:09:48 +01:00
parent 33eb652783
commit 9c36a99ebc
2 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libunwindstack/RegsInfo.h
View file

@ -41,7 +41,7 @@ struct RegsInfo {
}
inline AddressType* Save(uint32_t reg) {
if (reg > MAX_REGISTERS) {
if (reg >= MAX_REGISTERS) {
// This should never happen since all currently supported
// architectures have < 64 total registers.
abort();

7
libunwindstack/tests/RegsInfoTest.cpp
View file

@ -82,4 +82,11 @@ TEST(RegsInfoTest, all) {
}
}
TEST(RegsInfoTest, invalid_register) {
RegsImplFake<uint64_t> regs(64);
RegsInfo<uint64_t> info(&regs);
EXPECT_DEATH(info.Save(RegsInfo<uint64_t>::MAX_REGISTERS), "");
}
} // namespace unwindstack