tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "adb: fix IOKit handle leaks on OS X."

Browse source
This commit is contained in:
Josh Gao 2016-09-27 20:38:36 +00:00 committed by Gerrit Code Review
commit a2aff3f809
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
adb/usb_osx.cpp
View file

@ -177,6 +177,7 @@ AndroidInterfaceAdded(io_iterator_t iterator)
kr = (*iface)->GetDevice(iface, &usbDevice);
if (kIOReturnSuccess != kr || !usbDevice) {
LOG(ERROR) << "Couldn't grab device from interface (" << std::hex << kr << ")";
(*iface)->Release(iface);
continue;
}
@ -191,6 +192,7 @@ AndroidInterfaceAdded(io_iterator_t iterator)
(void)IOObjectRelease(usbDevice);
if ((kIOReturnSuccess != kr) || (!plugInInterface)) {
LOG(ERROR) << "Unable to create a device plug-in (" << std::hex << kr << ")";
(*iface)->Release(iface);
continue;
}
@ -200,6 +202,7 @@ AndroidInterfaceAdded(io_iterator_t iterator)
(*plugInInterface)->Release(plugInInterface);
if (result || !dev) {
LOG(ERROR) << "Couldn't create a device interface (" << std::hex << result << ")";
(*iface)->Release(iface);
continue;
}
@ -211,6 +214,8 @@ AndroidInterfaceAdded(io_iterator_t iterator)
if (kr == KERN_SUCCESS) {
devpath = android::base::StringPrintf("usb:%" PRIu32 "X", locationId);
if (IsKnownDevice(devpath)) {
(*dev)->Release(dev);
(*iface)->Release(iface);
continue;
}
}