Merge "Revert "libprocessgroup: return false on failure""

This commit is contained in:
Jiyong Park 2022-04-12 19:50:54 +00:00 committed by Gerrit Code Review
commit a2b180ab64

View file

@ -806,7 +806,6 @@ const IProfileAttribute* TaskProfiles::GetAttribute(const std::string& name) con
bool TaskProfiles::SetProcessProfiles(uid_t uid, pid_t pid,
const std::vector<std::string>& profiles, bool use_fd_cache) {
bool success = true;
for (const auto& name : profiles) {
TaskProfile* profile = GetProfile(name);
if (profile != nullptr) {
@ -815,19 +814,16 @@ bool TaskProfiles::SetProcessProfiles(uid_t uid, pid_t pid,
}
if (!profile->ExecuteForProcess(uid, pid)) {
PLOG(WARNING) << "Failed to apply " << name << " process profile";
success = false;
}
} else {
PLOG(WARNING) << "Failed to find " << name << " process profile";
success = false;
PLOG(WARNING) << "Failed to find " << name << "process profile";
}
}
return success;
return true;
}
bool TaskProfiles::SetTaskProfiles(int tid, const std::vector<std::string>& profiles,
bool use_fd_cache) {
bool success = true;
for (const auto& name : profiles) {
TaskProfile* profile = GetProfile(name);
if (profile != nullptr) {
@ -836,12 +832,10 @@ bool TaskProfiles::SetTaskProfiles(int tid, const std::vector<std::string>& prof
}
if (!profile->ExecuteForTask(tid)) {
PLOG(WARNING) << "Failed to apply " << name << " task profile";
success = false;
}
} else {
PLOG(WARNING) << "Failed to find " << name << " task profile";
success = false;
PLOG(WARNING) << "Failed to find " << name << "task profile";
}
}
return success;
return true;
}