tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove the weird range variants of String8::toLower() and String8::toUpper().

Browse source 
I want to remove these bad ASCII-only APIs completely, but it might be
easier to remove the range variants first.

Test: treehugger
Change-Id: I4c11f959a7bd8e670708cc03281ea72e9c461ff7
This commit is contained in:
Elliott Hughes 2021-04-08 13:26:49 -07:00
parent 05a7dfa104
commit a858395f91
2 changed files with 10 additions and 34 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
libutils/String8.cpp
View file

@ -415,50 +415,28 @@ bool String8::removeAll(const char* other) {
void String8::toLower()
{
toLower(0, size());
}
const size_t length = size();
if (length == 0) return;
void String8::toLower(size_t start, size_t length)
{
const size_t len = size();
if (start >= len) {
return;
}
if (start+length > len) {
length = len-start;
}
char* buf = lockBuffer(len);
buf += start;
while (length > 0) {
char* buf = lockBuffer(length);
for (size_t i = length; i > 0; --i) {
*buf = static_cast<char>(tolower(*buf));
buf++;
length--;
}
unlockBuffer(len);
unlockBuffer(length);
}
void String8::toUpper()
{
toUpper(0, size());
}
const size_t length = size();
if (length == 0) return;
void String8::toUpper(size_t start, size_t length)
{
const size_t len = size();
if (start >= len) {
return;
}
if (start+length > len) {
length = len-start;
}
char* buf = lockBuffer(len);
buf += start;
while (length > 0) {
char* buf = lockBuffer(length);
for (size_t i = length; i > 0; --i) {
*buf = static_cast<char>(toupper(*buf));
buf++;
length--;
}
unlockBuffer(len);
unlockBuffer(length);
}
// ---------------------------------------------------------------------------

2
libutils/include/utils/String8.h
View file

@ -130,9 +130,7 @@ public:
bool removeAll(const char* other);
void toLower();
void toLower(size_t start, size_t numChars);
void toUpper();
void toUpper(size_t start, size_t numChars);
/*