tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove double check of fd value.

Browse source 
The output.text.fd value is only ever -1 when there is a failure.
There is no need to check both < 0 or -1, so only check for -1.

Test: Unit tests pass.
Test: Verified the message is seen on intercept and not on
Test: regular crashes.
Change-Id: I1eddcd5d2342b268ceb261b246c98b10cee85bb4
This commit is contained in:
Christopher Ferris 2021-09-01 13:36:03 -07:00
parent 055abbb4d6
commit ab9f0cd759
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
debuggerd/tombstoned/tombstoned.cpp
View file

@ -448,10 +448,8 @@ static void crash_completed(borrowed_fd sockfd, std::unique_ptr<Crash> crash) {
return;
}
if (crash->output.text.fd < 0) {
if (crash->output.text.fd == -1) {
LOG(WARNING) << "skipping tombstone file creation due to intercept";
}
if (crash->output.text.fd == -1) {
LOG(WARNING) << "skipping tombstone file creation due to intercept";
return;
}