tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

storaged:Thread out of sync will cause null pointer crash

Browse source 
if other process binder calls dumpPerfHistory when storaged is started, there will be a problem with the storage_sp null pointer

Test: Manual

Bug: 149251684

Change-Id: I9bf61ceb7c34326e95f2355129714d28153a994c
Signed-off-by: shaozhongqi <shaozhongqi@xiaomi.com>
This commit is contained in:
shaozhongqi 2020-02-11 15:27:10 +08:00
parent cd8b982e40
commit cda9b2a500
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
storaged/main.cpp
View file

@ -46,11 +46,6 @@ sp<storaged_t> storaged_sp;
// Function of storaged's main thread
void* storaged_main(void* /* unused */) {
storaged_sp = new storaged_t();
storaged_sp->init();
storaged_sp->report_storage_info();
LOG(INFO) << "storaged: Start";
for (;;) {
@ -123,6 +118,9 @@ int main(int argc, char** argv) {
if (flag_main_service) { // start main thread
// Start the main thread of storaged
storaged_sp = new storaged_t();
storaged_sp->init();
storaged_sp->report_storage_info();
pthread_t storaged_main_thread;
errno = pthread_create(&storaged_main_thread, NULL, storaged_main, NULL);
if (errno != 0) {