tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add volatile to temporary variable.

Browse source 
FuseBuffer::HandleNotImpl save the value of |request.header.unique| to the
temporary variable, clear the buffer which is a union of |request| and
|response|, then write back the unique value to response.header.unique.

Before the CL, the temporary variable was wrongly removed by the compiler
optimization, and response.header.unique was always 0. The CL adds
volatile modifier as workaround to prevent the compiler optimization
from removing the temporary value.

Bug: 62429763
Test: libappfuse_tests
Change-Id: Ia853f805633f646f316f585a35c7b018000b6eb3
(cherry picked from commit a6dee5e279)
This commit is contained in:
Daichi Hirono 2017-06-20 16:18:32 +09:00
parent 1d873b3512
commit d9cda90ad4
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
libappfuse/FuseBuffer.cc
View file

@ -251,7 +251,9 @@ void FuseBuffer::HandleInit() {
void FuseBuffer::HandleNotImpl() {
LOG(VERBOSE) << "NOTIMPL op=" << request.header.opcode << " uniq="
<< request.header.unique << " nid=" << request.header.nodeid;
const uint64_t unique = request.header.unique;
// Add volatile as a workaround for compiler issue which removes the temporary
// variable.
const volatile uint64_t unique = request.header.unique;
response.Reset(0, -ENOSYS, unique);
}