tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

logd: kill(0,0) issue

Browse source 
- Recognize pid=0 as special case (kernel or pre-init sourced)
  and refrain from treating it in the general case.

Bug: 17526159
Change-Id: I74796043ac34753c6dd10018719ebc0bcd94e012
This commit is contained in:
Mark Salyzyn 2014-09-21 14:22:18 -07:00
parent 09dc063319
commit df5aa61f05
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
logd/LogStatistics.cpp
View file

@ -54,6 +54,9 @@ bool PidStatistics::pidGone() {
if (mGone || (pid == gone)) {
return true;
}
if (pid == 0) {
return false;
}
if (kill(pid, 0) && (errno != EPERM)) {
mGone = true;
return true;
@ -92,7 +95,9 @@ void PidStatistics::addTotal(size_t size, size_t element) {
// which debuggerd prints as a process is crashing.
char *PidStatistics::pidToName(pid_t pid) {
char *retval = NULL;
if (pid != gone) {
if (pid == 0) { // special case from auditd for kernel
retval = strdup("logd.auditd");
} else if (pid != gone) {
char buffer[512];
snprintf(buffer, sizeof(buffer), "/proc/%u/cmdline", pid);
int fd = open(buffer, O_RDONLY);