From ef5d0340e4ff3fe11b7668ebaf2f4f0c4c06134d Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Wed, 10 Oct 2012 11:26:54 -0700 Subject: [PATCH] toolbox: silence some compiler warnings Comparison of signed and unsigned integers. Use parenthesis around a group of bitwise OR operations. Change-Id: Ia404380593ce2c2a291133c07c0fc7a016a3ad3f --- toolbox/ls.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/toolbox/ls.c b/toolbox/ls.c index a4db99ca8..b7ba1b748 100644 --- a/toolbox/ls.c +++ b/toolbox/ls.c @@ -276,12 +276,12 @@ static int listfile_maclabel(const char *path, int flags) switch(s.st_mode & S_IFMT) { case S_IFLNK: { char linkto[256]; - int len; + ssize_t len; len = readlink(path, linkto, sizeof(linkto)); if(len < 0) return -1; - if(len > sizeof(linkto)-1) { + if((size_t)len > sizeof(linkto)-1) { linkto[sizeof(linkto)-4] = '.'; linkto[sizeof(linkto)-3] = '.'; linkto[sizeof(linkto)-2] = '.'; @@ -307,7 +307,7 @@ static int listfile_maclabel(const char *path, int flags) static int listfile(const char *dirname, const char *filename, int flags) { - if ((flags & LIST_LONG | LIST_SIZE | LIST_CLASSIFY | LIST_MACLABEL) == 0) { + if ((flags & (LIST_LONG | LIST_SIZE | LIST_CLASSIFY | LIST_MACLABEL)) == 0) { printf("%s\n", filename); return 0; }