tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Just use snprintf for android_get_control_socket.

Browse source 
Change-Id: I3d0da03847f79c9f9b2cfd7189a07f63b17fc4a2
This commit is contained in:
Elliott Hughes 2015-04-02 17:42:56 -07:00
parent 8e192f626e
commit edc49d7b98
1 changed files with 9 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
include/cutils/sockets.h
View file

@ -18,6 +18,7 @@
#define __CUTILS_SOCKETS_H
#include <errno.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdbool.h>
@ -46,30 +47,19 @@ extern "C" {
*/
static inline int android_get_control_socket(const char *name)
{
char key[64] = ANDROID_SOCKET_ENV_PREFIX;
const char *val;
int fd;
char key[64];
snprintf(key, sizeof(key), ANDROID_SOCKET_ENV_PREFIX "%s", name);
/* build our environment variable, counting cycles like a wolf ... */
#if HAVE_STRLCPY
strlcpy(key + sizeof(ANDROID_SOCKET_ENV_PREFIX) - 1,
name,
sizeof(key) - sizeof(ANDROID_SOCKET_ENV_PREFIX));
#else /* for the host, which may lack the almightly strncpy ... */
strncpy(key + sizeof(ANDROID_SOCKET_ENV_PREFIX) - 1,
name,
sizeof(key) - sizeof(ANDROID_SOCKET_ENV_PREFIX));
key[sizeof(key)-1] = '\0';
#endif
val = getenv(key);
if (!val)
const char* val = getenv(key);
if (!val) {
return -1;
}
errno = 0;
fd = strtol(val, NULL, 10);
if (errno)
int fd = strtol(val, NULL, 10);
if (errno) {
return -1;
}
return fd;
}