tequilaOS/platform_system_core
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

libsparse: fix 32 bit overflow when calculating last chunk

Browse source 
last_block * s->block_size can overflow when writing large filesystems,
cast to 64 bits before multiplying.

Change-Id: I3e54097852ce7d0fd271eab53d65e666284898e4
This commit is contained in:
Colin Cross 2012-07-23 17:09:42 -07:00
parent ec7d9dc713
commit f1ec8ac84a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libsparse/sparse.c
View file

@ -139,7 +139,7 @@ static int write_all_blocks(struct sparse_file *s, struct output_file *out)
DIV_ROUND_UP(backed_block_len(bb), s->block_size);
}
pad = s->len - last_block * s->block_size;
pad = s->len - (int64_t)last_block * s->block_size;
assert(pad >= 0);
if (pad > 0) {
write_skip_chunk(out, pad);