tequilaOS/platform_system_core

Fork 0

Commit graph

Author	SHA1	Message	Date
Josh Gao	05a3abfef3	adb: make sure that file mode macros match linux. We use <sys/stat.h> mode macros on the host to parse modes sent over from the device, so they had better match. Add static_asserts to ensure this. (Also, fix the cases where they don't.) Test: mma -j48, compiled the static_asserts on darwin manually Change-Id: I883e4e6c7489ea64d3c02d26790ac8293366d989	2016-11-21 18:39:21 -08:00
Josh Gao	f551ea0f63	adb: fix stat on Windows. stat on Windows fails with ENOENT when passed a path with a trailing slash or backslash, regardless of whether the target is actually a directory. Emulate the correct POSIX behavior by stripping trailing path separators and then checking if the target is a directory if successful. Bug: http://b/30481559 Bug: https://code.google.com/p/android/issues/detail?id=214633 Change-Id: I1d398d19a9bce1ecb3fdc4aabc31aa98c82c3f93 Test: Relevant adb_tests pass on Linux and Windows 10.	2016-08-01 12:36:04 -07:00

Author

SHA1

Message

Date

Josh Gao

05a3abfef3

adb: make sure that file mode macros match linux.

We use <sys/stat.h> mode macros on the host to parse modes sent over
from the device, so they had better match. Add static_asserts to ensure
this.

(Also, fix the cases where they don't.)

Test: mma -j48, compiled the static_asserts on darwin manually
Change-Id: I883e4e6c7489ea64d3c02d26790ac8293366d989

2016-11-21 18:39:21 -08:00

Josh Gao

f551ea0f63

adb: fix stat on Windows.

stat on Windows fails with ENOENT when passed a path with a trailing
slash or backslash, regardless of whether the target is actually a
directory. Emulate the correct POSIX behavior by stripping trailing
path separators and then checking if the target is a directory if
successful.

Bug: http://b/30481559
Bug: https://code.google.com/p/android/issues/detail?id=214633
Change-Id: I1d398d19a9bce1ecb3fdc4aabc31aa98c82c3f93
Test: Relevant adb_tests pass on Linux and Windows 10.

2016-08-01 12:36:04 -07:00

2 commits