Josh Gao
55259f320b
Merge "DO NOT MERGE: debuggerd: verify that traced threads belong to the right process." into klp-dev am: 23effb07ee am: ac3fbb1a4a am: 7ed0995930 -s ours
...
am: 58dd6f7cba
2016-08-15 19:05:10 +00:00
Josh Gao
7fe65ab421
DO NOT MERGE: debuggerd: verify that traced threads belong to the right process. am: 8d6ca194ee am: 8f7cc0e387 -s ours am: be9d9fc379 -s ours
...
am: 2071bcfa75
2016-08-15 19:05:10 +00:00
Josh Gao
58dd6f7cba
Merge "DO NOT MERGE: debuggerd: verify that traced threads belong to the right process." into klp-dev am: 23effb07ee am: ac3fbb1a4a
...
am: 7ed0995930
2016-08-15 19:01:10 +00:00
Josh Gao
2071bcfa75
DO NOT MERGE: debuggerd: verify that traced threads belong to the right process. am: 8d6ca194ee am: 8f7cc0e387 -s ours
...
am: be9d9fc379
2016-08-15 19:01:10 +00:00
Josh Gao
7ed0995930
Merge "DO NOT MERGE: debuggerd: verify that traced threads belong to the right process." into klp-dev am: 23effb07ee
...
am: ac3fbb1a4a
2016-08-15 18:57:27 +00:00
Josh Gao
be9d9fc379
DO NOT MERGE: debuggerd: verify that traced threads belong to the right process. am: 8d6ca194ee
...
am: 8f7cc0e387
2016-08-15 18:57:09 +00:00
Josh Gao
ac3fbb1a4a
Merge "DO NOT MERGE: debuggerd: verify that traced threads belong to the right process." into klp-dev
...
am: 23effb07ee
2016-08-15 18:29:09 +00:00
Josh Gao
8f7cc0e387
DO NOT MERGE: debuggerd: verify that traced threads belong to the right process.
...
am: 8d6ca194ee
2016-08-15 18:29:09 +00:00
Josh Gao
23effb07ee
Merge "DO NOT MERGE: debuggerd: verify that traced threads belong to the right process." into klp-dev
2016-08-15 18:18:44 +00:00
Hans Boehm
23c857ebd6
Make RefBase more robust and debuggable
...
This prevents two different kinds of client errors from causing
undetected memory corruption, and helps with the detection of others:
1. We no longer deallocate objects when the weak count goes to zero
and there have been no strong references. This otherwise causes
us to return a garbage object from a constructor if the constructor
allocates and deallocates a weak pointer to this. And we do know
that clients allocate such weak pointers in constructors and their
lifetime is hard to trace.
2. We abort if a RefBase object is explicitly destroyed while
the weak count is nonzero. Otherwise a subsequent decrement
would cause a write to potentially reallocated memory.
3. We check counter values returned by atomic decrements for
plausibility, and fail immediately if they are not plausible.
We unconditionally log any cases in which 1 changes behavior
from before. We abort in cases in which 2 changes behavior, since
those reflect clear bugs.
In case 1, a log message now indicates a possible leak. We have
not seen such a message in practice.
The third point introduces a small amount of overhead into the
reference count decrement path. But this should be negligible
compared to the actual decrement cost.
Add a test for promote/attemptIncStrong that tries to check for
both (1) above and concurrent operation of attemptIncStrong.
Add some additional warnings and explanations to the RefBase
documentation.
Bug: 30503444
Bug: 30292291
Bug: 30292538
Change-Id: Ida92b9a2e247f543a948a75d221fbc0038dea66c
2016-08-13 11:17:51 -07:00
Josh Gao
27259667ec
Merge "debuggerd: remove unnecessary arguments." am: 7a746f3a68
...
am: 60083bed75
2016-08-13 00:41:56 +00:00
Josh Gao
60083bed75
Merge "debuggerd: remove unnecessary arguments."
...
am: 7a746f3a68
2016-08-13 00:38:54 +00:00
Josh Gao
7a746f3a68
Merge "debuggerd: remove unnecessary arguments."
2016-08-13 00:29:29 +00:00
Josh Gao
f648fb4539
Merge "Clean up key handling in adb." am: b859830450
...
am: 81a3f71e45
2016-08-12 21:25:22 +00:00
Josh Gao
81a3f71e45
Merge "Clean up key handling in adb."
...
am: b859830450
2016-08-12 21:21:57 +00:00
Josh Gao
b859830450
Merge "Clean up key handling in adb."
2016-08-12 21:11:26 +00:00
Josh Gao
4a984ced34
Merge "debuggerd: remove useless timeout from wait_for_signal." am: 5f2bc28ebf
...
am: 4c4a172ee9
2016-08-12 20:17:41 +00:00
Josh Gao
4c4a172ee9
Merge "debuggerd: remove useless timeout from wait_for_signal."
...
am: 5f2bc28ebf
2016-08-12 20:02:10 +00:00
Josh Gao
5f2bc28ebf
Merge "debuggerd: remove useless timeout from wait_for_signal."
2016-08-12 19:52:55 +00:00
Josh Gao
a04c80255c
debuggerd: remove unnecessary arguments.
...
These were previously required when bionic used tgkill to reraise
signals, but now that we use rt_tgsigqueueinfo to reraise signals, they
are no longer necessary.
Change-Id: I46ba9f14039a727d0a2c4c3a9d93a3532ba8f263
2016-08-12 11:00:18 -07:00
Josh Gao
f5a960a187
debuggerd: remove useless timeout from wait_for_signal.
...
The watchdog already handles things for us, so the timeout logic in
wait_for_signal is pointless.
Change-Id: Id81ad5f294068216b73e04c4e2ceca072ae1bbc0
2016-08-12 11:00:18 -07:00
Greg Kaiser
3ab37d8844
Merge "fastboot: Don't leak file in error case" am: 3a197b3799
...
am: 0c8a67bbfd
2016-08-12 17:48:59 +00:00
Greg Kaiser
0c8a67bbfd
Merge "fastboot: Don't leak file in error case"
...
am: 3a197b3799
2016-08-12 17:45:32 +00:00
Treehugger Robot
3a197b3799
Merge "fastboot: Don't leak file in error case"
2016-08-12 17:34:49 +00:00
Greg Kaiser
dc9b62ba74
fastboot: Don't leak file in error case
...
This is probably not very significant in this standalone tool,
but makes it easier for us to find leaks in our other system
code via static analysis.
(cherry-pick of 407a2195391685627e6be947491041ae3c8cbe61.)
Change-Id: I4e14cadc1e53bac0848e0e0c7f531f920e43cb0a
2016-08-12 08:57:22 -07:00
Mark Salyzyn
6d2e1c73a3
Merge "logd: klogd crash (part deux)" am: 96c36d35ce
...
am: e36dbdda43
2016-08-12 14:34:47 +00:00
Mark Salyzyn
e36dbdda43
Merge "logd: klogd crash (part deux)"
...
am: 96c36d35ce
2016-08-12 14:30:50 +00:00
Mark Salyzyn
96c36d35ce
Merge "logd: klogd crash (part deux)"
2016-08-12 14:22:00 +00:00
Mark Salyzyn
83b247891c
logd: klogd crash (part deux)
...
LogBuffer::pidToUid(pid_t pid) { return stats.pidToUid(pid); }
needs to have LogBuffer::lock()/unlock() to prevent unordered_map
data corruption. This can lead to multiple symptoms, crashes and
continuous spins on corrupted iterators.
Bug: 30688716
Bug: 30050636
Bug: 30614675
Bug: 25620123
Bug: 30792935
Change-Id: I1d8fec8e5fda98c6a08645e7456b081507696b3c
2016-08-11 16:13:01 -07:00
Elliott Hughes
0aeb50500c
Clean up key handling in adb.
...
This includes the locking we need to be able to re-load the keys at runtime.
We should rename "adb_auth_client.cpp" to "adb_auth_adbd.cpp" or
"adbd_auth.cpp" in a later change.
Change-Id: I9e1d5b6b7d0497d6f6e5d9c4fb660118cdff05a8
Test: "adb devices" works against a non-AOSP device with $ADB_VENDOR_KEYS set, says "unauthorized" without.
Bug: http://b/29273531
2016-08-11 13:53:18 -07:00
Josh Gao
de37556d65
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev am: 73c59ad77c am: 015d662cb8 am: 00d389f392 am: 8dad649c6d -s ours
...
am: cfb8b6aea6
2016-08-11 20:32:49 +00:00
Josh Gao
b5edff33e3
DO NOT MERGE: adb: reenable (and fix) Windows build. am: 804de7a29e am: 5c4bf3d66f am: 5cee87ea25 am: 09b5b49e9b -s ours
...
am: 8b2a975e12
2016-08-11 20:32:48 +00:00
Josh Gao
cfb8b6aea6
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev am: 73c59ad77c am: 015d662cb8 am: 00d389f392
...
am: 8dad649c6d
2016-08-11 20:29:12 +00:00
Josh Gao
8b2a975e12
DO NOT MERGE: adb: reenable (and fix) Windows build. am: 804de7a29e am: 5c4bf3d66f am: 5cee87ea25
...
am: 09b5b49e9b
2016-08-11 20:29:11 +00:00
Josh Gao
8dad649c6d
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev am: 73c59ad77c am: 015d662cb8
...
am: 00d389f392
2016-08-11 20:26:11 +00:00
Josh Gao
09b5b49e9b
DO NOT MERGE: adb: reenable (and fix) Windows build. am: 804de7a29e am: 5c4bf3d66f
...
am: 5cee87ea25
2016-08-11 20:26:11 +00:00
Josh Gao
00d389f392
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev am: 73c59ad77c
...
am: 015d662cb8
2016-08-11 20:22:40 +00:00
Josh Gao
5cee87ea25
DO NOT MERGE: adb: reenable (and fix) Windows build. am: 804de7a29e
...
am: 5c4bf3d66f
2016-08-11 20:22:40 +00:00
Josh Gao
015d662cb8
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev
...
am: 73c59ad77c
2016-08-11 20:19:09 +00:00
Josh Gao
5c4bf3d66f
DO NOT MERGE: adb: reenable (and fix) Windows build.
...
am: 804de7a29e
2016-08-11 20:19:09 +00:00
TreeHugger Robot
73c59ad77c
Merge "DO NOT MERGE: adb: reenable (and fix) Windows build." into mnc-dev
2016-08-11 20:09:30 +00:00
Josh Gao
804de7a29e
DO NOT MERGE: adb: reenable (and fix) Windows build.
...
This branch is still getting used to build some SDK targets.
Bug: http://b/30767018
Change-Id: I85b03a80d69ceef5e5333505f0832129387ed2da
2016-08-11 11:29:43 -07:00
Josh Gao
98c4d5c4fe
Merge "Define TARGET_IS_64_BIT when building libdebuggerd_client for android64." am: 07f14c9cdd
...
am: 40efc4c664
2016-08-10 22:25:57 +00:00
Josh Gao
40efc4c664
Merge "Define TARGET_IS_64_BIT when building libdebuggerd_client for android64."
...
am: 07f14c9cdd
2016-08-10 22:23:06 +00:00
Josh Gao
07f14c9cdd
Merge "Define TARGET_IS_64_BIT when building libdebuggerd_client for android64."
2016-08-10 22:17:01 +00:00
Hans Boehm
f997434b06
Merge "Improve RefBase documentation, especially for clients." am: 0f39fe22ae
...
am: df6c464e9a
2016-08-10 16:26:59 +00:00
Hans Boehm
df6c464e9a
Merge "Improve RefBase documentation, especially for clients."
...
am: 0f39fe22ae
2016-08-10 16:24:01 +00:00
Hans Boehm
0f39fe22ae
Merge "Improve RefBase documentation, especially for clients."
2016-08-10 16:16:22 +00:00
Narayan Kamath
d5d7abe3d1
zip_archive: Improve error message on fallocate failure.
...
Noticed on b/30765660.
Change-Id: I1a98f83fef02a7368bdc2e1f8f24a0771eebe468
2016-08-10 12:24:05 +01:00
Josh Gao
a200a4d592
debuggerd: fix missed use of ptrace(PTRACE_ATTACH). am: 8b6b654a5f am: fe59793375 am: 073f731836 am: 647ec18a9d -s ours
...
am: 364188b9d8
2016-08-09 23:55:08 +00:00
