Commit graph

81685 commits

Author SHA1 Message Date
David Anderson
b6df0138e5 snapuserd: Return void from RespondIOError.
RespondIOError could return "true" which is not the correct value for
its callers, usually. However since RespondIOError is not specifically
needed anymore, we can also avoid calling it in most places.

This also fixes a bug where ReadUnalignedSector's return value was
implicitly converted to boolean.

Bug: 288273605
Test: snapuserd_test
Change-Id: I62140b2b05d0f9f53cb669c5c0d7e0ffc7f4c9a1
2023-07-05 12:10:42 -07:00
David Anderson
572692c04c snapuserd: Make header_response a state variable.
header_response is meant to only be true for the first call to
WriteDmUserPayload. Codify this by making it a member variable and
resetting it on each request.

Bug: 288273605
Test: snapuserd_test
Change-Id: Ic92f5932391a607b63345d579f379d12e78e8f6c
2023-07-05 12:10:42 -07:00
Treehugger Robot
732d410d21 Merge "add 'nodad' support to ifc_add_address()" 2023-07-01 03:15:34 +00:00
Treehugger Robot
f5d4edaa31 Merge "libutils: rewrite Vector fuzzer" 2023-07-01 01:28:13 +00:00
Steven Moreland
379d5c83d5 libutils: rewrite Vector fuzzer
It could never have gotten much coverage.

Bug: 288741501
Test: libutils_fuzz_vector (2,000,000 iterations)
                           (~60k-100k iterations/s)
Change-Id: I6f442642b5a3246dd08784f735db5aad5fd4d398
2023-07-01 00:28:48 +00:00
Maciej Żenczykowski
25ec9c4db1 add 'nodad' support to ifc_add_address()
Test: TreeHugger
Bug: 242067762
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Change-Id: I2c022f6af45eac7631213801a89aa270709d4a57
2023-06-30 16:36:21 +00:00
Jiakai Zhang
f43e20c9b4 Merge "Add a variant of ReadFstabFromFile for /proc/mounts." 2023-06-30 13:24:25 +00:00
Tomasz Wasilczyk
6ecea169ce Merge "Make atrace_*_body explicitly a part of API." 2023-06-29 22:23:16 +00:00
Jiakai Zhang
29ad6c2aa2 Add a variant of ReadFstabFromFile for /proc/mounts.
The variant excludes the code that is not for /proc/mounts, and
therefore saves code size when being called.

Also, after this change, the call to `SkipMountingPartitions` is skipped
for /proc/mounts because it is not needed.

Bug: 287958783
Test: atest CtsFsMgrTestCases
Change-Id: Ie243257fa2e87e666be7decf97ec36c806bc4524
2023-06-29 21:46:15 +00:00
Tomasz Wasilczyk
0c44d8d68d Make atrace_*_body explicitly a part of API.
Also, remove leftover atrace_set_debuggable(bool) symbol.

Bug: 289151149
Test: it builds
Change-Id: Id9fdf9451567d85b64971a6bb409336b12d3f535
2023-06-29 13:28:37 -07:00
Treehugger Robot
a33362ed50 Merge "libmodprobe: LPM: Cleanup of redundant check" 2023-06-29 17:21:18 +00:00
Daeho Jeong
47c0bfa8c7 Merge "init.rc: set f2fs seq_file_ra_mul to 128" 2023-06-29 15:52:51 +00:00
Tomasz Wasilczyk
d0e499f287 Merge "Drop const assignment operator." 2023-06-29 13:36:00 +00:00
Daeho Jeong
d6d8c1f81c init.rc: set f2fs seq_file_ra_mul to 128
Based on experiments, we fount out 128 (128 x global readahead window
size = 16mb) is the optimal multiple to boost up read speeds for the
sequentially accessed files with POSIX_FADV_SEQUENTIAL.

Bug: 195311558
Test: check the /sys/fs/f2fs/<userdata partition>/seq_file_ra_mul value
Change-Id: I7563ad6e47b9ab76ae7fe36978d0e5970a7490e8
Signed-off-by: Daeho Jeong <daehojeong@google.com>
2023-06-28 14:35:30 -07:00
Matthew Maurer
de4ad68fa7 Merge "Bindgen 0.65.1 no longer supports size_t-is-usize" 2023-06-28 18:48:34 +00:00
Tomasz Wasilczyk
aab4105ef6 Drop const assignment operator.
Also, silence cert-oop54-cpp - self-assignment is already handled in
VectorImpl class.

Bug: 289151149
Test: it builds
Change-Id: I8be7714ed53d1515df7cfdf6de6f3c90b3e5cc76
2023-06-28 11:21:47 -07:00
Treehugger Robot
38b572c9e5 Merge "Improve error message of libmodprobe" 2023-06-27 22:31:27 +00:00
Kelvin Zhang
db15b6f93d Improve error message of libmodprobe
Log path of module if that module is not found.

Bug: 273752147
Test: th
Change-Id: I428a116ee26f97455229df642acbdc1297098a32
2023-06-27 13:53:43 -07:00
Kelvin Zhang
fe7a3dae2c Merge "Update some fs_mgr/debuggerd to use getpagesize() instead of PAGE_SIZE" 2023-06-27 19:18:53 +00:00
Kelvin Zhang
786dac3d50 Update some fs_mgr/debuggerd to use getpagesize() instead of PAGE_SIZE
Test: th
Bug: 279808236
Change-Id: I9d30cfe19d2b1a7d624cc5425e4315dc6e3b2ad2
2023-06-27 10:50:07 -07:00
Treehugger Robot
8ec7d3da58 Merge "Revert "snapuserd: Make header_response a state variable."" 2023-06-27 06:55:22 +00:00
David Anderson
e2e8f55b81 Revert "snapuserd: Make header_response a state variable."
This reverts commit d4e035ebc3.

Reason for revert: Breaks incremental OTAs

Change-Id: Ib9703a66b83e08114ca4d11370d669b8bcdf4789
2023-06-27 05:29:20 +00:00
Jooyung Han
c288e14001 Merge "No need to read ro.apex.updatable now" 2023-06-27 00:55:25 +00:00
David Anderson
53bb327f29 Merge "snapuserd: Make header_response a state variable." 2023-06-26 22:51:41 +00:00
Matthew Maurer
dee32db249 Bindgen 0.65.1 no longer supports size_t-is-usize
The flag has been a default, and now is not accepted.

Test: Treehugger, m rust
Bug: 279198502
Bug: 276464273
Change-Id: Ifdf9968bfcdb278f73cf31ab68bc6b488b39436b
2023-06-26 22:27:09 +00:00
David Anderson
b41cd681aa Merge changes I07031e89,I1ba276e1
* changes:
  libsnapshot: Remove direct accesses of CowOperation::source and compression.
  libsnapshot: Add helpers for accessing CowOperation offsets.
2023-06-26 18:39:57 +00:00
Nikita Ioffe
4ad8a68f2d Merge "init selinux.cpp: use a better way to detect if we run in Microdroid" 2023-06-26 18:31:34 +00:00
Treehugger Robot
c5d1978666 Merge "Make libfstab available to APEXes." 2023-06-26 16:29:26 +00:00
Nikita Ioffe
a66adf45aa init selinux.cpp: use a better way to detect if we run in Microdroid
We are now conditionally compiling init binaries & libinit for
Microdroid (adding -DMICRODROID=1 cflag), so instead of checking for the
presence of the /system/etc/selinux/microdroid_precompiled_sepolicy we
can check if the code is compiled for Microdroid.

In a follow-up changes we can split the sepolicy loading logic into 2
separate headers (one for Android and one for Microdroid) and include
the necessary one depending on the target we compile for.

Bug: 287206497
Test: atest MicrodroidTestApp
Change-Id: Id9c837d03a96ff9564688d33955ec85094eee487
2023-06-26 16:43:16 +01:00
Jiakai Zhang
cf16f4d794 Make libfstab available to APEXes.
The ART module needs this library to determine whether to put dexopt
artifacts in dalvik-cache.

Bug: 287958783
Test: m
Change-Id: Idf338702d4f54e9c40c0692ea29e7d83e91aca38
2023-06-23 22:28:49 +01:00
David Anderson
d4e035ebc3 snapuserd: Make header_response a state variable.
header_response is meant to only be true for the first call to
WriteDmUserPayload. Codify this by making it a member variable and
resetting it on each request.

Bug: 288273605
Test: snapuserd_test
Change-Id: Ia125f86b7f22f4801be1e0796e8f85540ed5f31f
2023-06-23 13:14:50 -07:00
David Anderson
cf311bd00f libsnapshot: Remove direct accesses of CowOperation::source and compression.
For the remaining use cases of accessing CowOperation::source and
compression, directly, introduce helper functions, since these fields
will be removed in the v3 format.

Bug: 280529365
Test: cow_api_test
Change-Id: I07031e8968525a7c1314ca45c284e476b51d8104
2023-06-23 13:14:50 -07:00
David Anderson
09ccef4961 libsnapshot: Add helpers for accessing CowOperation offsets.
These helpers avoid manual inspection of CowOperation::source, and
fiddling with block sizes.

Bug: 280529365
Test: cow_api_test
      vts_libsnapshot_test
      apply OTA
Change-Id: I1ba276e155eb8232a3115066caaa11030c171e11
2023-06-23 13:14:50 -07:00
Treehugger Robot
8790a71bc4 Merge "Remove dead code from fs_mgr" 2023-06-23 20:07:09 +00:00
David Anderson
c6d615dd17 Merge "libsnapshot: Add a helper around CowReader::GetRawBytes." 2023-06-23 18:33:44 +00:00
Paul Lawrence
c7998f2abb Remove dead code from fs_mgr
Test: Compiles
Change-Id: I76402758396b658fc1539f81541b162723b709a2
2023-06-23 09:27:55 -07:00
Jooyung Han
918971c69e No need to read ro.apex.updatable now
Bug: 288202251
Test: m
Test: device boots
Change-Id: I97a3c2fab69489cdfbb5103b148194d7e2ee4d1a
2023-06-23 14:22:44 +09:00
David Anderson
27fb5200aa libsnapshot: Add a helper around CowReader::GetRawBytes.
This avoids having to use op->source which will require more work after
the new format lands.

Bug: 280529365
Test: inspect_cow
Change-Id: Iffa18974bb0152dad73d69bb03c683f1aa549031
2023-06-22 20:52:10 -07:00
Treehugger Robot
c7465ab5d2 Merge "Build libsparse and simg2img for Mac OS X as part of Cuttlefish launcher tools" 2023-06-23 02:12:44 +00:00
Treehugger Robot
b190adfc2e Merge "init_kill_services_test: wait 120s for apexd" 2023-06-23 01:07:14 +00:00
A. Cody Schuffelen
0236af54cd Build libsparse and simg2img for Mac OS X as part of Cuttlefish launcher tools
Bug: 288493595
Test: m libsparse simg2img
Change-Id: I9e0c5c77b9b2b5994bf52e1ca9fdb84bc1523d5d
2023-06-22 17:11:37 -07:00
Treehugger Robot
fe4066520e Merge "Only skip checkpointing for freshly formatted ext4" 2023-06-22 23:28:01 +00:00
Daniel Zheng
6c58df5766 Merge "Change HardcodedFlash to add flashtasks" 2023-06-22 20:32:43 +00:00
Daniel Zheng
7e0a31e79d Merge "use FlashingPlan sparse_limit for testing" 2023-06-22 20:32:29 +00:00
David Anderson
9fd1147017 Merge changes Icaeba861,I19007a78,I11863dcb
* changes:
  inspect_cow: Add --show_raw_ops.
  inspect_cow: Switch to gflags.
  libsnapshot: Remove dependence between CowWriterV2 and CowReader.
2023-06-22 20:10:41 +00:00
Steven Moreland
14e7b76dcf init_kill_services_test: wait 120s for apexd
This is likely waiting for the Java garbage collector to run,
and due to the lockless implementation of BinderProxyNativeData
and BpBinder, it's very difficult to efficiently force this
object to be deleted.

Change-Id: I4df667b9b47327967a43d75664fb506b8704f905
Fixes: 285458033
Test: N/A
2023-06-22 18:56:09 +00:00
Daniel Zheng
90fc835d48 Merge "Add flag to disable super optimization" 2023-06-22 18:02:13 +00:00
Daniel Zheng
77ac76c094 Merge "Removing local image lookup from load_buf" 2023-06-22 18:02:06 +00:00
Daniel Zheng
93710811ca Merge "Moving source class declaration" 2023-06-22 18:01:59 +00:00
Daniel Zheng
ba07ef5732 Change HardcodedFlash to add flashtasks
Changing Hardcoded FLash to add flash tasks, also modifying do_flash to
download signature data if a source is provided

Test: fastboot flashall
Change-Id: Ic33bc4076f269d0d48146a3de457a72eedd5e6df
2023-06-22 09:52:08 -07:00