0484b3b575
A mixture of fixes and cleanup for LogKlog.cpp and friends. - sscanf calls strlen. Check if the string is missing a nul terminator, if it is, do not call sscanf. - replace NULL with nullptr for stronger typechecking. - pass by reference for simpler code. - Use ssize_t where possible to check for negative values. - fix FastCmp to add some validity checking since ASAN reports that callers are not making sure pre-conditions are met. - add fasticmp templates for completeness. - if the buffer is too small to contain a meaningful time, do not call down to log_time::strptime() because it does not limit its accesses to the buffer boundaries, instead stopping at a terminating nul or invalid match. - move strnstr to LogUtils.h, drop size checking of needle and clearly report the list of needles used with android::strnstr - replace 'sizeof(static const char[]) - 1' with strlen. Test: gTest liblog-unit-test, logd-unit-tests & logcat-unit-tests Bug: 30792935 Bug: 36536248 Bug: 35468874 Bug: 34949125 Bug: 34606909 Bug: 36075298 Bug: 36608728 Change-Id: I161bf03ba029050e809b31cceef03f729d318866
76 lines
2.3 KiB
C++
76 lines
2.3 KiB
C++
/*
|
|
* Copyright (C) 2012-2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#ifndef _LOGD_LOG_UTILS_H__
|
|
#define _LOGD_LOG_UTILS_H__
|
|
|
|
#include <sys/cdefs.h>
|
|
#include <sys/types.h>
|
|
|
|
#include <private/android_logger.h>
|
|
#include <sysutils/SocketClient.h>
|
|
#include <utils/FastStrcmp.h>
|
|
|
|
// Hijack this header as a common include file used by most all sources
|
|
// to report some utilities defined here and there.
|
|
|
|
namespace android {
|
|
|
|
// Furnished in main.cpp. Caller must own and free returned value
|
|
char* uidToName(uid_t uid);
|
|
void prdebug(const char* fmt, ...) __printflike(1, 2);
|
|
|
|
// Furnished in LogStatistics.cpp.
|
|
size_t sizesTotal();
|
|
// Caller must own and free returned value
|
|
char* pidToName(pid_t pid);
|
|
char* tidToName(pid_t tid);
|
|
|
|
// Furnished in LogTags.cpp. Thread safe.
|
|
const char* tagToName(uint32_t tag);
|
|
void ReReadEventLogTags();
|
|
|
|
// Furnished by LogKlog.cpp
|
|
char* log_strntok_r(char* s, ssize_t& len, char*& saveptr, ssize_t& sublen);
|
|
|
|
// needle should reference a string longer than 1 character
|
|
static inline const char* strnstr(const char* s, ssize_t len,
|
|
const char* needle) {
|
|
if (len <= 0) return nullptr;
|
|
|
|
const char c = *needle++;
|
|
const size_t needleLen = strlen(needle);
|
|
do {
|
|
do {
|
|
if (len <= (ssize_t)needleLen) return nullptr;
|
|
--len;
|
|
} while (*s++ != c);
|
|
} while (fastcmp<memcmp>(s, needle, needleLen));
|
|
s--;
|
|
return s;
|
|
}
|
|
}
|
|
|
|
// Furnished in LogCommand.cpp
|
|
bool clientHasLogCredentials(uid_t uid, gid_t gid, pid_t pid);
|
|
bool clientHasLogCredentials(SocketClient* cli);
|
|
|
|
static inline bool worstUidEnabledForLogid(log_id_t id) {
|
|
return (id == LOG_ID_MAIN) || (id == LOG_ID_SYSTEM) ||
|
|
(id == LOG_ID_RADIO) || (id == LOG_ID_EVENTS);
|
|
}
|
|
|
|
#endif // _LOGD_LOG_UTILS_H__
|