7827991d7f
r.android.com/2108505 was intended to fix a crash in Scudo in the case where the stack depot, region info or ring buffer were unreadable. However, it also ended up introducing a number of bugs into the code. It failed to call __scudo_get_error_info if the page at the fault address was unreadable. This can happen in legitimate crash cases if a primary allocation was close to the boundary of a mapped region, or if the allocation was a secondary allocation with guard pages. It also used long as the type for tags, whereas Scudo expects it to be char. In combination this ended up causing most of the MTE tests to fail. Therefore, mostly revert that change. Fix the original crash by null checking the pointers returned by AllocAndReadFully before proceeding with the rest of the function. Bug: 233720136 Change-Id: I04d70d2abffaa35fe315d15d9224f9b412a9825d |
||
|---|---|---|
| .. | ||
| dump_memory_test.cpp | ||
| elf_fake.cpp | ||
| elf_fake.h | ||
| host_signal_fixup.h | ||
| log_fake.cpp | ||
| log_fake.h | ||
| open_files_list_test.cpp | ||
| UnwinderMock.h | ||
| utility_test.cpp | ||