60521c7d52
- Rewrite the Maps::Parse to use open, and a buffer on the stack. - Rewrite the line parser away from sscanf. The current way sscanf is used does not catch many malformed lines. In addition, this new version improves performance by 50% over sscanf on sailfish. - Add a lot of unit tests for the parser to make sure there are no problems. In addition, add a special line that was not rejected with the previous version of the code. - Add new accessor to get the map at a particular index. - Add a backtrace benchmark for map creation for both new and old. This cl results in ~5% speedup and makes the new unwinder map creation about the same for 64 bit. It's still a bit slower, but not by much. On 32 bit, we are still about 5% slower than the old creation method, though. Bug: 23762183 Test: libunwindstack unit tests pass. Ran the new benchmarks. Change-Id: Id4431e539f400984e6fad62153fdf4152d518322
293 lines
6.8 KiB
C++
293 lines
6.8 KiB
C++
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <errno.h>
|
|
#include <fcntl.h>
|
|
#include <inttypes.h>
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <sys/mman.h>
|
|
#include <sys/types.h>
|
|
#include <unistd.h>
|
|
|
|
#include <android-base/unique_fd.h>
|
|
|
|
#include <cctype>
|
|
#include <memory>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include <unwindstack/Elf.h>
|
|
#include <unwindstack/Maps.h>
|
|
#include <unwindstack/Memory.h>
|
|
|
|
namespace unwindstack {
|
|
|
|
MapInfo* Maps::Find(uint64_t pc) {
|
|
if (maps_.empty()) {
|
|
return nullptr;
|
|
}
|
|
size_t first = 0;
|
|
size_t last = maps_.size();
|
|
while (first < last) {
|
|
size_t index = (first + last) / 2;
|
|
MapInfo* cur = &maps_[index];
|
|
if (pc >= cur->start && pc < cur->end) {
|
|
return cur;
|
|
} else if (pc < cur->start) {
|
|
last = index;
|
|
} else {
|
|
first = index + 1;
|
|
}
|
|
}
|
|
return nullptr;
|
|
}
|
|
|
|
// Assumes that line does not end in '\n'.
|
|
static bool InternalParseLine(const char* line, MapInfo* map_info) {
|
|
// Do not use a sscanf implementation since it is not performant.
|
|
|
|
// Example linux /proc/<pid>/maps lines:
|
|
// 6f000000-6f01e000 rwxp 00000000 00:0c 16389419 /system/lib/libcomposer.so
|
|
char* str;
|
|
const char* old_str = line;
|
|
map_info->start = strtoul(old_str, &str, 16);
|
|
if (old_str == str || *str++ != '-') {
|
|
return false;
|
|
}
|
|
|
|
old_str = str;
|
|
map_info->end = strtoul(old_str, &str, 16);
|
|
if (old_str == str || !std::isspace(*str++)) {
|
|
return false;
|
|
}
|
|
|
|
while (std::isspace(*str)) {
|
|
str++;
|
|
}
|
|
|
|
// Parse permissions data.
|
|
if (*str == '\0') {
|
|
return false;
|
|
}
|
|
map_info->flags = 0;
|
|
if (*str == 'r') {
|
|
map_info->flags |= PROT_READ;
|
|
} else if (*str != '-') {
|
|
return false;
|
|
}
|
|
str++;
|
|
if (*str == 'w') {
|
|
map_info->flags |= PROT_WRITE;
|
|
} else if (*str != '-') {
|
|
return false;
|
|
}
|
|
str++;
|
|
if (*str == 'x') {
|
|
map_info->flags |= PROT_EXEC;
|
|
} else if (*str != '-') {
|
|
return false;
|
|
}
|
|
str++;
|
|
if (*str != 'p' && *str != 's') {
|
|
return false;
|
|
}
|
|
str++;
|
|
|
|
if (!std::isspace(*str++)) {
|
|
return false;
|
|
}
|
|
|
|
old_str = str;
|
|
map_info->offset = strtoul(old_str, &str, 16);
|
|
if (old_str == str || !std::isspace(*str)) {
|
|
return false;
|
|
}
|
|
|
|
// Ignore the 00:00 values.
|
|
old_str = str;
|
|
(void)strtoul(old_str, &str, 16);
|
|
if (old_str == str || *str++ != ':') {
|
|
return false;
|
|
}
|
|
if (std::isspace(*str)) {
|
|
return false;
|
|
}
|
|
|
|
// Skip the inode.
|
|
old_str = str;
|
|
(void)strtoul(str, &str, 16);
|
|
if (old_str == str || !std::isspace(*str++)) {
|
|
return false;
|
|
}
|
|
|
|
// Skip decimal digit.
|
|
old_str = str;
|
|
(void)strtoul(old_str, &str, 10);
|
|
if (old_str == str || (!std::isspace(*str) && *str != '\0')) {
|
|
return false;
|
|
}
|
|
|
|
while (std::isspace(*str)) {
|
|
str++;
|
|
}
|
|
if (*str == '\0') {
|
|
map_info->name = str;
|
|
return true;
|
|
}
|
|
|
|
// Save the name data.
|
|
map_info->name = str;
|
|
|
|
// Mark a device map in /dev/ and not in /dev/ashmem/ specially.
|
|
if (map_info->name.substr(0, 5) == "/dev/" && map_info->name.substr(5, 7) != "ashmem/") {
|
|
map_info->flags |= MAPS_FLAGS_DEVICE_MAP;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool Maps::Parse() {
|
|
int fd = open(GetMapsFile().c_str(), O_RDONLY | O_CLOEXEC);
|
|
if (fd == -1) {
|
|
return false;
|
|
}
|
|
|
|
bool return_value = true;
|
|
char buffer[2048];
|
|
size_t leftover = 0;
|
|
while (true) {
|
|
ssize_t bytes = read(fd, &buffer[leftover], 2048 - leftover);
|
|
if (bytes == -1) {
|
|
return_value = false;
|
|
break;
|
|
}
|
|
if (bytes == 0) {
|
|
break;
|
|
}
|
|
bytes += leftover;
|
|
char* line = buffer;
|
|
while (bytes > 0) {
|
|
char* newline = static_cast<char*>(memchr(line, '\n', bytes));
|
|
if (newline == nullptr) {
|
|
memmove(buffer, line, bytes);
|
|
break;
|
|
}
|
|
*newline = '\0';
|
|
|
|
MapInfo map_info;
|
|
if (!InternalParseLine(line, &map_info)) {
|
|
return_value = false;
|
|
break;
|
|
}
|
|
maps_.push_back(map_info);
|
|
|
|
bytes -= newline - line + 1;
|
|
line = newline + 1;
|
|
}
|
|
leftover = bytes;
|
|
}
|
|
close(fd);
|
|
return return_value;
|
|
}
|
|
|
|
Maps::~Maps() {
|
|
for (auto& map : maps_) {
|
|
delete map.elf;
|
|
map.elf = nullptr;
|
|
}
|
|
}
|
|
|
|
bool BufferMaps::Parse() {
|
|
const char* start_of_line = buffer_;
|
|
do {
|
|
std::string line;
|
|
const char* end_of_line = strchr(start_of_line, '\n');
|
|
if (end_of_line == nullptr) {
|
|
line = start_of_line;
|
|
} else {
|
|
line = std::string(start_of_line, end_of_line - start_of_line);
|
|
end_of_line++;
|
|
}
|
|
|
|
MapInfo map_info;
|
|
if (!InternalParseLine(line.c_str(), &map_info)) {
|
|
return false;
|
|
}
|
|
maps_.push_back(map_info);
|
|
|
|
start_of_line = end_of_line;
|
|
} while (start_of_line != nullptr && *start_of_line != '\0');
|
|
return true;
|
|
}
|
|
|
|
const std::string RemoteMaps::GetMapsFile() const {
|
|
return "/proc/" + std::to_string(pid_) + "/maps";
|
|
}
|
|
|
|
bool OfflineMaps::Parse() {
|
|
// Format of maps information:
|
|
// <uint64_t> StartOffset
|
|
// <uint64_t> EndOffset
|
|
// <uint64_t> offset
|
|
// <uint16_t> flags
|
|
// <uint16_t> MapNameLength
|
|
// <VariableLengthValue> MapName
|
|
android::base::unique_fd fd(TEMP_FAILURE_RETRY(open(file_.c_str(), O_RDONLY)));
|
|
if (fd == -1) {
|
|
return false;
|
|
}
|
|
|
|
std::vector<char> name;
|
|
while (true) {
|
|
MapInfo map_info;
|
|
ssize_t bytes = TEMP_FAILURE_RETRY(read(fd, &map_info.start, sizeof(map_info.start)));
|
|
if (bytes == 0) {
|
|
break;
|
|
}
|
|
if (bytes == -1 || bytes != sizeof(map_info.start)) {
|
|
return false;
|
|
}
|
|
bytes = TEMP_FAILURE_RETRY(read(fd, &map_info.end, sizeof(map_info.end)));
|
|
if (bytes == -1 || bytes != sizeof(map_info.end)) {
|
|
return false;
|
|
}
|
|
bytes = TEMP_FAILURE_RETRY(read(fd, &map_info.offset, sizeof(map_info.offset)));
|
|
if (bytes == -1 || bytes != sizeof(map_info.offset)) {
|
|
return false;
|
|
}
|
|
bytes = TEMP_FAILURE_RETRY(read(fd, &map_info.flags, sizeof(map_info.flags)));
|
|
if (bytes == -1 || bytes != sizeof(map_info.flags)) {
|
|
return false;
|
|
}
|
|
uint16_t len;
|
|
bytes = TEMP_FAILURE_RETRY(read(fd, &len, sizeof(len)));
|
|
if (bytes == -1 || bytes != sizeof(len)) {
|
|
return false;
|
|
}
|
|
if (len > 0) {
|
|
name.resize(len);
|
|
bytes = TEMP_FAILURE_RETRY(read(fd, name.data(), len));
|
|
if (bytes == -1 || bytes != len) {
|
|
return false;
|
|
}
|
|
map_info.name = std::string(name.data(), len);
|
|
}
|
|
maps_.push_back(map_info);
|
|
}
|
|
return true;
|
|
}
|
|
|
|
} // namespace unwindstack
|