No description
Find a file
Tom Cherry 2adbece108 logd: Fix ClearUidLogs() when writer_active_ is true
Previously ClearUidLogs() would Compress() the log buffer in all
cases, however that is the wrong behavior when writer_active_ is true
and would leave the SerializedLogChunk object in an invalid state.  If
more logs are written to the log, then write_offset() will be higher
than the compressed size of the log, violating a CHECK() when later
decompressing the log.

This change does not call Compress() in ClearUidLogs() if
writer_active_ is true.  It upgrades a check in Compress() from a
simple if statement to a CHECK() to prevent against this happening in
the future.

It adds a test that exercises the previously failing path.

Bug: 166187079
Test: unit tests
Change-Id: Ic5fbcf16f724af1c20170b8f4e6e2daadf6a9529
2020-09-09 20:26:59 +00:00
adb Don't enable version lib for libadb_sysdeps 2020-08-28 13:30:34 +09:00
bootstat Update language to comply with Android's inclusive language guidance 2020-07-31 16:36:06 -06:00
cli-test cli-test: a tool for testing command-line programs. 2019-12-13 12:23:51 -08:00
code_coverage extend syscall minijail for clang code coverage 2020-07-13 13:39:05 -07:00
cpio Remove EXCLUDE_FS_CONFIG_STRUCTURES 2020-03-04 15:34:09 -08:00
debuggerd libdebuggerd: do a to-do. 2020-08-03 18:56:35 +00:00
deprecated-adf remove deprecated bp 'subdirs' 2020-01-14 12:18:40 -08:00
diagnose_usb Make the udev vs plugdev distinction a bit clearer. 2020-07-31 15:09:35 -07:00
fastboot libfastboot uses usb_linux.cpp for all Linux targets 2020-08-28 13:30:35 +09:00
fs_mgr Merge "liblp: fix host lpdump cannot work issue" 2020-09-02 17:36:00 +00:00
gatekeeperd Use optional for nullable types 2020-02-24 09:31:47 +09:00
healthd Assume UNSUPPORTED if the battery capacity level sysfs node does 2020-08-13 14:31:02 -07:00
include
init Merge "Store userspace reboot info in /metadata" 2020-08-26 21:47:19 +00:00
janitors Add the two best build system janitors. 2019-03-25 10:25:13 -07:00
libappfuse Fix Deadlock Issue On AppFuseBridge 2020-02-18 04:33:06 +00:00
libasyncio Revert "Revert "Set apex_available property"" 2020-03-26 00:23:56 +00:00
libbacktrace Cleanup for #inclusivefixit. 2020-07-28 12:08:03 -07:00
libbinderwrapper
libcrypto_utils libcrypto_utils: switch to C++. 2020-08-21 10:34:56 -07:00
libcutils Add systrace tag for system property 2020-08-19 12:48:07 +08:00
libdiskconfig
libgrallocusage gralloc: Set min_sdk_version 2020-04-23 23:50:08 +09:00
libkeyutils Update language to comply with Android's inclusive language guidance 2020-07-31 16:36:06 -06:00
liblog Remove android_lookupEventTagNum() and related code 2020-08-17 18:04:00 +00:00
libmodprobe libmodprobe: remove SetMinimumLogSeverity() from constructor 2020-08-04 08:28:36 -07:00
libnetutils Add a libipchecksum that contains the C IP checksum code. 2020-07-09 16:35:47 +09:00
libpackagelistparser Add require_root to adbd_test and libpackagelistparser_test 2019-09-24 09:13:32 -07:00
libpixelflinger Fix an issue with C-compatibility due to a missing tag name 2020-07-14 14:38:43 -07:00
libprocessgroup libprocessgroup: json prototype for cgroups v2 2020-08-20 15:53:48 -07:00
libprocinfo Make libbacktrace buildable for native_bridge 2020-06-18 22:02:46 +02:00
libqtaguid
libsparse libsparse: Fix overflow of merged sparse chunk length 2020-08-11 08:34:28 +09:00
libstats Revert "Make libstatssocket a shared_lib" 2020-05-08 07:57:09 +00:00
libsuspend Remove libsuspend from VNDK. 2018-08-14 13:39:55 -07:00
libsync Make libsync a stubs library 2020-06-05 17:13:57 +09:00
libsystem Set min_sdk_version to be part of mainline modules 2020-05-13 08:18:06 +09:00
libsysutils SocketClient: don't ignore SIGPIPE 2020-07-31 15:53:18 -07:00
libunwindstack Do not create a map with start == end. 2020-09-01 12:36:26 -07:00
libusbhost Prevent infinite loop on zero length USB descriptors 2020-02-21 11:11:02 -08:00
libutils Fix API for C compatibility 2020-08-24 17:29:25 +00:00
libvndksupport remove deprecated bp 'subdirs' 2020-01-14 12:18:40 -08:00
llkd llkd: Use more inclusive language 2020-06-16 10:28:14 -07:00
logcat logcat: fix tests broken from new formatting 2020-09-01 21:33:34 +00:00
logd logd: Fix ClearUidLogs() when writer_active_ is true 2020-09-09 20:26:59 +00:00
logwrapper logwrap: add missing O_CLOEXEC 2020-02-26 10:29:04 -08:00
property_service Cleanup for #inclusivefixit. 2020-07-27 11:37:19 -07:00
qemu_pipe Use more inclusive language for #inclusivefixit 2020-07-28 00:22:59 +00:00
reboot adb: replace reboot service with exec of /system/bin/reboot. 2019-10-23 14:33:36 -07:00
rootdir Merge "Store userspace reboot info in /metadata" 2020-08-26 21:47:19 +00:00
run-as run-as: improve error messages. 2020-03-04 18:11:18 -08:00
sdcard Move layout_version to /data/misc/installd 2019-08-21 10:12:18 -07:00
set-verity-state set-verity-state: Link to libfs_mgr_binder. 2019-12-30 13:42:57 -08:00
shell_and_utilities Add the rough toybox version numbers to the docs. 2020-08-06 10:15:25 -07:00
storaged storaged: ignore SIGPIPE 2020-03-17 09:31:01 -07:00
toolbox Merge "toolbox: make all janitors the owners." 2020-07-13 17:31:11 +00:00
trusty Merge "Add support for tipc_send()" 2020-08-03 19:35:55 +00:00
usbd Remove libhwbinder/libhidltransport deps 2019-09-05 14:17:42 -07:00
watchdogd Move watchdogd out of init 2018-08-02 12:25:58 -07:00
.clang-format
.clang-format-2 Move clang-formats to build. 2019-01-18 14:26:33 -08:00
.clang-format-4 Move clang-formats to build. 2019-01-18 14:26:33 -08:00
.gitignore
Android.bp remove deprecated bp 'subdirs' 2020-01-14 12:18:40 -08:00
base Migrate system/core/base to system/libbase. 2020-05-19 21:32:42 +00:00
CleanSpec.mk snapshotctl don't auto-merge. 2020-03-03 13:19:49 -08:00
METADATA Add METADATA to system/core: Apache2+BSD=NOTICE 2020-04-29 13:16:41 -07:00
MODULE_LICENSE_APACHE2
NOTICE
OWNERS Move per-file OWNERS directives to their directories. 2018-06-06 11:49:40 +09:00
PREUPLOAD.cfg Add AOSP preupload hook. 2020-04-23 11:02:00 -07:00
TEST_MAPPING Run liblog and logd CTS tests in presubmit 2020-07-29 08:02:52 -07:00